Chris Smith | 18 Mar 2012 23:41
Picon

Review Request: Removed unused code from kword/part/KWApplicationConfig.cpp

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104341/

Review request for KOffice and Robert Mathias Marmorstein.
By Chris Smith.

Description

Removed unused code from kword/part/KWApplicationConfig.cpp Undo variable with related code and comments. Spelling variable with related code and comments.

Testing

built, installed, and runs

Diffs

  • kword/part/KWApplicationConfig.cpp (00e2bcb)

View Diff

_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
Thomas Zander | 20 Mar 2012 09:06
Picon
Favicon

Re: Review Request: Removed unused code from kword/part/KWApplicationConfig.cpp

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104341/

Ship it!

simple, yet useful. I approve! :) Thanks!

- Thomas


On March 18th, 2012, 10:41 p.m., Chris Smith wrote:

Review request for KOffice and Robert Mathias Marmorstein.
By Chris Smith.

Updated March 18, 2012, 10:41 p.m.

Description

Removed unused code from kword/part/KWApplicationConfig.cpp Undo variable with related code and comments. Spelling variable with related code and comments.

Testing

built, installed, and runs

Diffs

  • kword/part/KWApplicationConfig.cpp (00e2bcb)

View Diff

_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
Albert Astals Cid | 7 Feb 2013 22:23
Picon
Favicon
Gravatar

Re: Review Request 104341: Removed unused code from kword/part/KWApplicationConfig.cpp

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104341/

I see this has a ship it but marked as uncommited. Was it commited and you forgot to close the request or is still uncommited?

- Albert


On March 18th, 2012, 10:41 p.m. UTC, Chris Smith wrote:

Review request for KOffice and Robert Mathias Marmorstein.
By Chris Smith.

Updated March 18, 2012, 10:41 p.m.

Description

Removed unused code from kword/part/KWApplicationConfig.cpp Undo variable with related code and comments. Spelling variable with related code and comments.

Testing

built, installed, and runs

Diffs

  • kword/part/KWApplicationConfig.cpp (00e2bcb)

View Diff

_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
Commit Hook | 5 Apr 2013 22:03
Picon
Favicon

Re: Review Request 104341: Removed unused code from kword/part/KWApplicationConfig.cpp

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104341/

This review has been submitted with commit 0060d473c1171476c5d7c11e9c2b0ff89b0c80e0 by Albert Astals Cid on behalf of Chris Smith to branch master.

- Commit


On March 18th, 2012, 10:41 p.m. UTC, Chris Smith wrote:

Review request for KOffice and Robert Mathias Marmorstein.
By Chris Smith.

Updated March 18, 2012, 10:41 p.m.

Description

Removed unused code from kword/part/KWApplicationConfig.cpp Undo variable with related code and comments. Spelling variable with related code and comments.

Testing

built, installed, and runs

Diffs

  • kword/part/KWApplicationConfig.cpp (00e2bcb)

View Diff

_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
Commit Hook | 5 Apr 2013 22:03
Picon
Favicon

Re: Review Request 104341: Removed unused code from kword/part/KWApplicationConfig.cpp

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104341/

This change has been marked as submitted.


Review request for KOffice and Robert Mathias Marmorstein.
By Chris Smith.

Updated April 5, 2013, 8:03 p.m.

Description

Removed unused code from kword/part/KWApplicationConfig.cpp Undo variable with related code and comments. Spelling variable with related code and comments.

Testing

built, installed, and runs

Diffs

  • kword/part/KWApplicationConfig.cpp (00e2bcb)

View Diff

_______________________________________________
koffice-devel mailing list
koffice-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

Gmane