headers
Florian Zumkeller-Quast | 10 Nov 13:05
Gravatar

Review Request: Fix compile break of quanta

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103106/

Review request for KDevelop and Quanta.
By Florian Zumkeller-Quast.

Description

Some changes on the Interface of ISourceFormatter from the kdevplatform project broke compiling of quanta. This Patch fixes the interface of the SourceFormatter derived classes and some calls to these methods with the new KUrl parameter inserted.

Testing

Quanta compiles fine with that patch.

Diffs

  • languages/xml/formatter/formatterplugin.h (e8799f1)
  • languages/xml/formatter/formatterplugin.cpp (4b04725)
  • languages/xml/formatter/sgmlformatter.cpp (4a99d79)
  • languages/xml/language/completion/sgmlcodecompletionmodel.cpp (803760f)
  • plugins/phpformatter/formatterplugin.h (8b462bc)
  • plugins/phpformatter/formatterplugin.cpp (761d635)

View Diff

 
_______________________________________________
quanta-devel mailing list
quanta-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel
Permalink | Reply |
headers
Milian Wolff | 10 Nov 15:18
Picon
Favicon
Gravatar

Re: Review Request: Fix compile break of quanta

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103106/

Ship it!

commit is fine besides a few style issues, put the &,* always adjacent to the typename for consistency please. if you have commit rights, please fix this before pushing. otherwise send me this patch as created by "git format-patch" - if possible with the style issue fixed. otherwise I'll do that. thanks
languages/xml/formatter/formatterplugin.cpp (Diff revision 1) 162 162
QString FormatterPlugin::highlightModeForMime ( const KMimeType::Ptr &mime ) {
QString FormatterPlugin::formatSource ( const QString& text, const KMimeType::Ptr& mime, const QString& leftContext, const QString& rightContext ) { QString FormatterPlugin::formatSource(const QString &text, const KUrl& url, const KMimeType::Ptr &mime, const QString& leftContext = QString(), const QString& rightContext = QString())
please put the & adjacent to the typename for consistency

languages/xml/formatter/formatterplugin.cpp (Diff revision 1) 167 168
QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle style, const QString& text, const KMimeType::Ptr& mime, const QString& leftContext, const QString& rightContext)
QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle style, const QString& text, const KMimeType::Ptr& mime, const QString& leftContext, const QString& rightContext) QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle style, const QString& text, const KUrl& url, const KMimeType::Ptr &mime, const QString& leftContext = QString(), const QString& rightContext = QString())
also here, & adjacent to the typename please

plugins/phpformatter/formatterplugin.h (Diff revision 1) 55 55
public:
virtual QString formatSourceWithStyle(KDevelop::SourceFormatterStyle , const QString& text, const KMimeType::Ptr& mime, const QString& leftContext = QString(), const QString& rightContext = QString()); virtual QString formatSourceWithStyle(KDevelop::SourceFormatterStyle, const QString& text, const KUrl& url, const KMimeType::Ptr &mime, const QString& leftContext, const QString& rightContext);
again, please & adjacent to typename

plugins/phpformatter/formatterplugin.cpp (Diff revision 1) 92 92
QString FormatterPlugin::description() {
QString FormatterPlugin::formatSource ( const QString& text, const KMimeType::Ptr& mime, const QString& leftContext, const QString& rightContext ) { QString FormatterPlugin::formatSource(const QString &text, const KUrl& url, const KMimeType::Ptr &mime, const QString& leftContext = QString(), const QString& rightContext = QString())
& again... :)

plugins/phpformatter/formatterplugin.cpp (Diff revision 1) 102 103
QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle style, const QString& text, const KMimeType::Ptr& mime, const QString& leftContext, const QString& rightContext)
QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle style, const QString& text, const KMimeType::Ptr& mime, const QString& leftContext, const QString& rightContext) QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle style, const QString& text, const KUrl& url, const KMimeType::Ptr &mime, const QString& leftContext = QString(), const QString& rightContext = QString())
& again... :)

- Milian


On November 10th, 2011, 12:05 p.m., Florian Zumkeller-Quast wrote:

Review request for KDevelop and Quanta.
By Florian Zumkeller-Quast.

Updated Nov. 10, 2011, 12:05 p.m.

Description

Some changes on the Interface of ISourceFormatter from the kdevplatform project broke compiling of quanta. This Patch fixes the interface of the SourceFormatter derived classes and some calls to these methods with the new KUrl parameter inserted.

Testing

Quanta compiles fine with that patch.

Diffs

  • languages/xml/formatter/formatterplugin.h (e8799f1)
  • languages/xml/formatter/formatterplugin.cpp (4b04725)
  • languages/xml/formatter/sgmlformatter.cpp (4a99d79)
  • languages/xml/language/completion/sgmlcodecompletionmodel.cpp (803760f)
  • plugins/phpformatter/formatterplugin.h (8b462bc)
  • plugins/phpformatter/formatterplugin.cpp (761d635)

View Diff

 
_______________________________________________
quanta-devel mailing list
quanta-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel
Permalink | Reply |
headers
Milian Wolff | 10 Nov 15:18
Picon
Favicon
Gravatar

Re: Review Request: Fix compile break of quanta

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103106/

Ship it!

commit is fine besides a few style issues, put the &,* always adjacent to the typename for consistency please. if you have commit rights, please fix this before pushing. otherwise send me this patch as created by "git format-patch" - if possible with the style issue fixed. otherwise I'll do that. thanks
languages/xml/formatter/formatterplugin.cpp (Diff revision 1) 162 162
QString FormatterPlugin::highlightModeForMime ( const KMimeType::Ptr &mime ) {
QString FormatterPlugin::formatSource ( const QString& text, const KMimeType::Ptr& mime, const QString& leftContext, const QString& rightContext ) { QString FormatterPlugin::formatSource(const QString &text, const KUrl& url, const KMimeType::Ptr &mime, const QString& leftContext = QString(), const QString& rightContext = QString())
please put the & adjacent to the typename for consistency

languages/xml/formatter/formatterplugin.cpp (Diff revision 1) 167 168
QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle style, const QString& text, const KMimeType::Ptr& mime, const QString& leftContext, const QString& rightContext)
QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle style, const QString& text, const KMimeType::Ptr& mime, const QString& leftContext, const QString& rightContext) QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle style, const QString& text, const KUrl& url, const KMimeType::Ptr &mime, const QString& leftContext = QString(), const QString& rightContext = QString())
also here, & adjacent to the typename please

plugins/phpformatter/formatterplugin.h (Diff revision 1) 55 55
public:
virtual QString formatSourceWithStyle(KDevelop::SourceFormatterStyle , const QString& text, const KMimeType::Ptr& mime, const QString& leftContext = QString(), const QString& rightContext = QString()); virtual QString formatSourceWithStyle(KDevelop::SourceFormatterStyle, const QString& text, const KUrl& url, const KMimeType::Ptr &mime, const QString& leftContext, const QString& rightContext);
again, please & adjacent to typename

plugins/phpformatter/formatterplugin.cpp (Diff revision 1) 92 92
QString FormatterPlugin::description() {
QString FormatterPlugin::formatSource ( const QString& text, const KMimeType::Ptr& mime, const QString& leftContext, const QString& rightContext ) { QString FormatterPlugin::formatSource(const QString &text, const KUrl& url, const KMimeType::Ptr &mime, const QString& leftContext = QString(), const QString& rightContext = QString())
& again... :)

plugins/phpformatter/formatterplugin.cpp (Diff revision 1) 102 103
QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle style, const QString& text, const KMimeType::Ptr& mime, const QString& leftContext, const QString& rightContext)
QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle style, const QString& text, const KMimeType::Ptr& mime, const QString& leftContext, const QString& rightContext) QString FormatterPlugin::formatSourceWithStyle(SourceFormatterStyle style, const QString& text, const KUrl& url, const KMimeType::Ptr &mime, const QString& leftContext = QString(), const QString& rightContext = QString())
& again... :)

- Milian


On November 10th, 2011, 12:05 p.m., Florian Zumkeller-Quast wrote:

Review request for KDevelop and Quanta.
By Florian Zumkeller-Quast.

Updated Nov. 10, 2011, 12:05 p.m.

Description

Some changes on the Interface of ISourceFormatter from the kdevplatform project broke compiling of quanta. This Patch fixes the interface of the SourceFormatter derived classes and some calls to these methods with the new KUrl parameter inserted.

Testing

Quanta compiles fine with that patch.

Diffs

  • languages/xml/formatter/formatterplugin.h (e8799f1)
  • languages/xml/formatter/formatterplugin.cpp (4b04725)
  • languages/xml/formatter/sgmlformatter.cpp (4a99d79)
  • languages/xml/language/completion/sgmlcodecompletionmodel.cpp (803760f)
  • plugins/phpformatter/formatterplugin.h (8b462bc)
  • plugins/phpformatter/formatterplugin.cpp (761d635)

View Diff

 
--

-- 
KDevelop-devel mailing list
KDevelop-devel@...
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
Permalink | Reply |
headers
Florian Zumkeller-Quast | 10 Nov 16:42
Gravatar

Re: Review Request: Fix compile break of quanta

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103106/

Review request for KDevelop and Quanta.
By Florian Zumkeller-Quast.

Updated Nov. 10, 2011, 3:42 p.m.

Changes

The patch created by git format-patch. I fixed the style issues.

Description

Some changes on the Interface of ISourceFormatter from the kdevplatform project broke compiling of quanta. This Patch fixes the interface of the SourceFormatter derived classes and some calls to these methods with the new KUrl parameter inserted.

Testing

Quanta compiles fine with that patch.

Diffs

  • languages/xml/formatter/formatterplugin.h (e8799f1)
  • languages/xml/formatter/formatterplugin.cpp (4b04725)
  • languages/xml/formatter/sgmlformatter.cpp (4a99d79)
  • languages/xml/language/completion/sgmlcodecompletionmodel.cpp (803760f)
  • plugins/phpformatter/formatterplugin.h (8b462bc)
  • plugins/phpformatter/formatterplugin.cpp (761d635)

View Diff

 
_______________________________________________
quanta-devel mailing list
quanta-devel <at> kde.org
https://mail.kde.org/mailman/listinfo/quanta-devel
Permalink | Reply |
headers
Commit Hook | 10 Nov 16:45
Picon
Favicon

Re: Review Request: Fix compile break of quanta

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103106/

This review has been submitted with commit 73ce55abeec8f6317a6840d2a875d2cfc38d4555 by Florian Zumkeller-Quast to branch master.

- Commit


On November 10th, 2011, 3:42 p.m., Florian Zumkeller-Quast wrote:

Review request for KDevelop and Quanta.
By Florian Zumkeller-Quast.

Updated Nov. 10, 2011, 3:42 p.m.

Description

Some changes on the Interface of ISourceFormatter from the kdevplatform project broke compiling of quanta. This Patch fixes the interface of the SourceFormatter derived classes and some calls to these methods with the new KUrl parameter inserted.

Testing

Quanta compiles fine with that patch.

Diffs

  • languages/xml/formatter/formatterplugin.h (e8799f1)
  • languages/xml/formatter/formatterplugin.cpp (4b04725)
  • languages/xml/formatter/sgmlformatter.cpp (4a99d79)
  • languages/xml/language/completion/sgmlcodecompletionmodel.cpp (803760f)
  • plugins/phpformatter/formatterplugin.h (8b462bc)
  • plugins/phpformatter/formatterplugin.cpp (761d635)

View Diff

 
--

-- 
KDevelop-devel mailing list
KDevelop-devel@...
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
Permalink | Reply |
headers
Florian Zumkeller-Quast | 10 Nov 16:42
Gravatar

Re: Review Request: Fix compile break of quanta

This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103106/

Review request for KDevelop and Quanta.
By Florian Zumkeller-Quast.

Updated Nov. 10, 2011, 3:42 p.m.

Changes

The patch created by git format-patch. I fixed the style issues.

Description

Some changes on the Interface of ISourceFormatter from the kdevplatform project broke compiling of quanta. This Patch fixes the interface of the SourceFormatter derived classes and some calls to these methods with the new KUrl parameter inserted.

Testing

Quanta compiles fine with that patch.

Diffs

  • languages/xml/formatter/formatterplugin.h (e8799f1)
  • languages/xml/formatter/formatterplugin.cpp (4b04725)
  • languages/xml/formatter/sgmlformatter.cpp (4a99d79)
  • languages/xml/language/completion/sgmlcodecompletionmodel.cpp (803760f)
  • plugins/phpformatter/formatterplugin.h (8b462bc)
  • plugins/phpformatter/formatterplugin.cpp (761d635)

View Diff

 
--

-- 
KDevelop-devel mailing list
KDevelop-devel@...
https://barney.cs.uni-potsdam.de/mailman/listinfo/kdevelop-devel
Permalink | Reply |

Gmane