nigeltao | 15 Jun 2012 06:05
Favicon

code review 6298085: exp/html/atom: add some more atoms. (issue 6298085)

Reviewers: r,

Message:
Hello r <at> golang.org (cc: golang-dev@...),

I'd like you to review this change to
https://code.google.com/p/go/

Description:
exp/html/atom: add some more atoms.

Please review this at http://codereview.appspot.com/6298085/

Affected files:
   M src/pkg/exp/html/atom/gen.go
   M src/pkg/exp/html/atom/table.go
   M src/pkg/exp/html/atom/table_test.go

David Symonds | 15 Jun 2012 06:07
Favicon
Gravatar

Re: code review 6298085: exp/html/atom: add some more atoms. (issue 6298085)

On Fri, Jun 15, 2012 at 2:05 PM,  <nigeltao@...> wrote:

> Description:
> exp/html/atom: add some more atoms.

Careful you don't trigger fission on that package.

Russ Cox | 15 Jun 2012 18:41
Favicon

Re: code review 6298085: exp/html/atom: add some more atoms. (issue 6298085)

On Fri, Jun 15, 2012 at 12:07 AM, David Symonds <dsymonds@...> wrote:
> Careful you don't trigger fission on that package.

I actually worry about this. Eventually the hash table is going to
need 1024 entries instead of 512.

Russ

r | 15 Jun 2012 06:22
Favicon

Re: code review 6298085: exp/html/atom: add some more atoms. (issue 6298085)

LGTM
the unbearable lightness of HTML5

http://codereview.appspot.com/6298085/

nigeltao | 15 Jun 2012 07:39
Favicon

Re: code review 6298085: exp/html/atom: add some more atoms. (issue 6298085)

*** Submitted as
http://code.google.com/p/go/source/detail?r=c868b808b7a7 ***

exp/html/atom: add some more atoms.

R=r, dsymonds
CC=golang-dev
http://codereview.appspot.com/6298085

http://codereview.appspot.com/6298085/


Gmane