gri | 16 Jun 2012 00:21
Favicon

code review 6304086: go/ast: Walk: do not walk comment list (issue 6304086)

Reviewers: golang-dev_googlegroups.com,

Message:
Hello golang-dev@...,

I'd like you to review this change to
https://code.google.com/p/go

Description:
go/ast: Walk: do not walk comment list

A comment to that effect was introduced
with rev d332f4b9cef5 but the respective
code wasn't deleted.

Please review this at http://codereview.appspot.com/6304086/

Affected files:
   M src/pkg/go/ast/walk.go

Index: src/pkg/go/ast/walk.go
===================================================================
--- a/src/pkg/go/ast/walk.go
+++ b/src/pkg/go/ast/walk.go
 <at>  <at>  -344,9 +344,6  <at>  <at> 
  		}
  		Walk(v, n.Name)
  		walkDeclList(v, n.Decls)
-		for _, g := range n.Comments {
-			Walk(v, g)
(Continue reading)

David Symonds | 16 Jun 2012 01:20
Favicon
Gravatar

Re: code review 6304086: go/ast: Walk: do not walk comment list (issue 6304086)

LGTM

gri | 16 Jun 2012 01:55
Favicon

Re: code review 6304086: go/ast: Walk: do not walk comment list (issue 6304086)

*** Submitted as
http://code.google.com/p/go/source/detail?r=5e3661048f2e ***

go/ast: Walk: do not walk comment list

A comment to that effect was introduced
with rev d332f4b9cef5 but the respective
code wasn't deleted.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/6304086

http://codereview.appspot.com/6304086/


Gmane