Shlomi Fish | 23 Oct 2010 11:44
Picon
Gravatar

[Resend] Patch to Get Rid of \t in perlipc.pod [was Re: [PATCH] Start revamping perlipc.pod]

I'm resending this patch because it was not applied yet. Please apply it, 
because I'd like to further patch perlipc.pod.

More details below.

Regards,

	Shlomi Fish

On Sunday 05 September 2010 08:13:02 Jesse Vincent wrote:
> On Sun, Sep 05, 2010 at 08:03:41AM +0300, Shlomi Fish wrote:
> > Hi all,
> > 
> > Inspired by a message ot the perl documentation proejct, I started
> > working on revamping perlipc.pod here:
> > 
> > http://github.com/shlomif/perl/tree/perlipc-revamp
> > 
> > What I did so far is convert all tabs to spaces (as the indentation was
> > very erratic) and started modernising the code
> 
> Shlomi,
> 
> Thanks for starting to look at perlipc. Is there a chance you could send
> your patch as a series that splits out the whitespace changes from the
> code/prose changes?  Heavy whitespace changes tend to make it much
> harder to review "contentful" changes in a patch, since there are
> so many lines of diff that aren't actually semantically meaningful.
> 
> Thanks,
(Continue reading)

David Golden | 23 Oct 2010 13:39
Picon
Gravatar

Re: [Resend] Patch to Get Rid of \t in perlipc.pod [was Re: [PATCH] Start revamping perlipc.pod]

Shlomi,

The inline format made the patch impossible to apply (for me), so I
cherry picked two whitespace commits out of your branch and then
squashed them and pushed the result to blead.  Your patch below also
started off by adding "our $shucks", so I just fixed that in blead
myself directly.

In the future, if you could please rebase your branches against blead
periodically instead of merging blead into your branch periodically,
that would make it much easier to follow your work in a branch and
apply it.

Thank you for taking on the work of cleaning up perlipc -- it
definitely needs it!

Regards,
David

On Sat, Oct 23, 2010 at 5:44 AM, Shlomi Fish <shlomif <at> iglu.org.il> wrote:
> I'm resending this patch because it was not applied yet. Please apply it,
> because I'd like to further patch perlipc.pod.
>
> More details below.
>
> Regards,
>
>        Shlomi Fish
>
> On Sunday 05 September 2010 08:13:02 Jesse Vincent wrote:
(Continue reading)


Gmane