Randy W. Sims | 2 Oct 2005 07:05

Re: [Module::Build] Solving the common-MANIFEST.SKIP entries problem

Ken Williams wrote:
> 
> On Sep 28, 2005, at 5:40 PM, Randy W. Sims wrote:
> 
>> Michael G Schwern wrote:
>>
>>> B)  Get 0.28 out the door, damnit!  I want my fixed installbase! [1]
>>> [1] Consider this to be a gentle prod towards release.
>>
>>
>> I finally got some relief at work; this weekend will be the first, in 
>> many months, that I haven't had to work. I had planned to celebrate 
>> and take it easy this weekend, but I'll try to go ahead and clean up 
>> the remaining issues that I introduced or have been involved in, 
>> excluding the integration of the new argument processing code.
> 
> 
> I think the only issues we need to clear up before the next beta are 
> currently-failing tests.  There's one that I added to t/moduleinfo.t for 
> another $VERSION-parsing thing that it's currently failing on, I think 
> we could just make that a TODO item.

Fixed.

> There's a test failure that I'm 
> seeing on Cygwin in t/destinations.t that should really get fixed, 
> though, since I think it's likely to actually bite people.  I've been 
> looking at it but I don't understand it yet (I unfortunately can't spend 
> much time on the Win32 box to narrow it down), so any help from anyone 
> (not just Randy S.) would be great.
(Continue reading)

Ken Williams | 3 Oct 2005 03:49
Favicon

Re: [Module::Build] Solving the common-MANIFEST.SKIP entries problem


On Oct 2, 2005, at 12:05 AM, Randy W. Sims wrote:

> Ken Williams wrote:
>> I think the only issues we need to clear up before the next beta are 
>> currently-failing tests.  There's one that I added to t/moduleinfo.t 
>> for another $VERSION-parsing thing that it's currently failing on, I 
>> think we could just make that a TODO item.
>
> Fixed.

Excellent.

>
>    File::Spec->catdir( File::Spec->rootdir, 'bin', File::Spec->curdir 
> );
> => //bin/
>
>    File::Spec->catdir( File::Spec->rootdir, File::Spec->curdir, 'bin' 
> );
> => //./bin
>
> The last example works; it removes the trailing slash

Weird - File::Spec on Cygwin is just a very thin wrapper around the 
Unix version, which doesn't seem to have this problem.

>
> This is with both the default 3.05 and the newer 3.11. Both File::Spec 
> and Module::Build will need fixes...
(Continue reading)

Randy W. Sims | 3 Oct 2005 05:16

Re: [Module::Build] Solving the common-MANIFEST.SKIP entries problem

Ken Williams wrote:
> 
> On Oct 2, 2005, at 12:05 AM, Randy W. Sims wrote:

>>    File::Spec->catdir( File::Spec->rootdir, 'bin', File::Spec->curdir );
>> => //bin/
>>
>>    File::Spec->catdir( File::Spec->rootdir, File::Spec->curdir, 'bin' );
>> => //./bin
>>
>> The last example works; it removes the trailing slash
> 
> 
> Weird - File::Spec on Cygwin is just a very thin wrapper around the Unix 
> version, which doesn't seem to have this problem.
> 
> 
>> This is with both the default 3.05 and the newer 3.11. Both File::Spec 
>> and Module::Build will need fixes...
> 
> 
> True, it would be a good fix, but I wonder if we could fix in the M::B 
> tests by just running the paths through canonpath()?

I played with this for a while last night and couldd not get anything 
that would work from File::Spec. I tried canonpath, rel2abs, etc. 
Anytime I try to turn it into a absolute path, it insists on adding an 
extra slash at the beginning and the end of the path. I'm thinking of 
just comitting a hack like:

(Continue reading)


Gmane