via RT | 22 Jun 2012 00:55
Favicon

[perl #113782] [PATCH variants] pp_sassign: explain the mix of left<=>right in the optree

# New Ticket Created by  rurban <at> cpanel.net 
# Please include the string:  [perl #113782]
# in the subject line of all future correspondence about this issue. 
# <URL: https://rt.perl.org:443/rt3/Ticket/Display.html?id=113782 >

This is a bug report for perl from rurban <at> cpanel.net,
generated with the help of perlbug 1.39 running under perl 5.17.0.

-----------------------------------------------------------------
I will attach two variants of patches to fix the pp_sassign 
left<=>right mixup problem.

1. Explain in the ASSIGNOP and in pp_sassign that the two arguments
   for sassign are backwards, right means left hand side in the source,
   left means right hand side.

2. (Preferred variant) Fix left and right in pp_sassign to make it readable.
    lhs and rhs reflect now the parsed source not the position on the optree
    stack. This matches aassign and the terminology in the parser.

-----------------------------------------------------------------
---
Flags:
    category=core
    severity=medium
---
Site configuration information for perl 5.17.0:

Configured by rurban at Tue Jun  5 09:17:02 CDT 2012.

(Continue reading)

Vincent Pit | 22 Jun 2012 10:43
Favicon
Gravatar

Re: [perl #113782] [PATCH variants] pp_sassign: explain the mix of left<=>right in the optree

On 22/06/2012 00:55, rurban <at> cpanel.net (via RT) wrote:
> 2. (Preferred variant) Fix left and right in pp_sassign to make it readable.
>      lhs and rhs reflect now the parsed source not the position on the optree
>      stack. This matches aassign and the terminology in the parser.

Now applied as commit 3e75a3c4.

Thanks.


Gmane