headers
Gavin Sinclair | 12 Dec 2003 08:18
Picon

I'm documenting optparse

Just letting you know...
Permalink | Reply |
headers
Gavin Sinclair | 29 Dec 2003 23:21
Picon

Re: I'm documenting optparse

On Friday, December 12, 2003, 6:18:39 PM, Gavin wrote:

> Just letting you know...

Made a decent start at that, uploaded socs v0.8.4, and am now working
on pathname.
Permalink | Reply |
headers
Tanaka Akira | 30 Dec 2003 04:31

pathname.rb

In article <181759371498.20031230092101 <at> soyabean.com.au>,
  Gavin Sinclair <gsinclair <at> soyabean.com.au> writes:

> Made a decent start at that, uploaded socs v0.8.4, and am now working
> on pathname.

I have some
comments.

http://www.ruby-lang.org/cgi-bin/cvsweb.cgi/ruby/lib/pathname.rb?cvsroot=src&r1=1.21&r2=1.22 :

| +# difference.  *All* functionality from File, FileTest, +ftools+ and FileUtils
| +# is included, in an unsurprising way.  It is essentially a facade for all of
| +# these, and more.

pathname.rb doesn't use ftools.

pathname.rb uses only 2 methods in FileUtils.  FileUtils has much more
methods which are not used by pathname.rb.

| +# These methods are effectively manipulating a String, because that's all a path
| +# is.  They (mostly) don't access the filesystem.
| +#
| +# - #cleanpath
| +# - #realpath (accesses filesystem)
| +# - #parent
| +# - #mountpoint?
| +# - #root?
| +# - #absolute?
| +# - #relative?
(Continue reading)

Permalink | Reply |
headers
Gavin Sinclair | 30 Dec 2003 11:11
Picon

Re: pathname.rb

On Tuesday, December 30, 2003, 2:31:30 PM, Tanaka wrote:

> |  <at>  <at>  -776,11 +946,9  <at>  <at>      def test_plus
> |        assert_pathname_plus('/', '/', '..')
> |        assert_pathname_plus('.', 'a', '..')
> |        assert_pathname_plus('a', 'a/b', '..')
> | -      assert_pathname_plus('../..', '..', '..')
> |        assert_pathname_plus('/c', '/', '../c')
> |        assert_pathname_plus('c', 'a', '../c')
> |        assert_pathname_plus('a/c', 'a/b', '../c')
> | -      assert_pathname_plus('../../c', '..', '../c')
> |      end
> |    end
> |  end

> Do you noticed that you removed 2 assertions?

You added those assertions in 1.21 and I committed 1.22 without them.
I was careful (in general) to ensure my CVS was up to date, and CVS
didn't give me a not-up-to-date error.  I'm baffled.

This fixed it, and I'm committing again.

  cvs up -j 1.20 -j 1.21 pathname.rb

Gavin
Permalink | Reply |
headers
Gavin Sinclair | 30 Dec 2003 04:37
Picon

Re: pathname.rb


Thanks for the comments.  I didn't notice the removal of assertions and am
very glad you did!  I'll fix that, and incorporate the comments, tonight.

Gavin
Permalink | Reply |
headers
Gavin Sinclair | 29 Dec 2003 23:24
Picon

Re: I'm documenting optparse

On Tuesday, December 30, 2003, 9:21:01 AM, Gavin wrote:

> On Friday, December 12, 2003, 6:18:39 PM, Gavin wrote:

>> Just letting you know...

> Made a decent start at that, uploaded socs v0.8.4, and am now working
                                        docs
> on pathname.
Permalink | Reply |

Gmane