Tim Blechmann | 1 Jul 2012 17:55
Favicon
Gravatar

thread & 1.50 issues

i came across two issues of boost.thread in 1.50.

the first is a minor issue: the 1.50 tarball contains a
libs/thread/src/shared_mutex.cpp source file, which includes
boost/thread/v2/shared_mutex.hpp, which does not exist. by default it is
not built, so it is not a big problem, but it is not really clean, either.

the second issue is a bit more severe, as it is an undocumented API
change: boost::TIME_UTC has been renamed to boost::TIME_UTC_ ... not
sure what's the reason for it, but it breaks code that used the old
symbol. this includes the boost-style threadpool library [1] ...

so i wonder, is this change really needed?

tim

[1] http://threadpool.sourceforge.net

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost

Vicente J. Botet Escriba | 1 Jul 2012 21:41
Picon

Re: thread & 1.50 issues

Le 01/07/12 17:55, Tim Blechmann a écrit :
> i came across two issues of boost.thread in 1.50.
Hi,

thanks for these reports.
> the first is a minor issue: the 1.50 tarball contains a
> libs/thread/src/shared_mutex.cpp source file, which includes
> boost/thread/v2/shared_mutex.hpp, which does not exist. by default it is
> not built, so it is not a big problem, but it is not really clean, either.
As you said this is not clean, could you create a ticket, please?
> the second issue is a bit more severe, as it is an undocumented API
> change: boost::TIME_UTC has been renamed to boost::TIME_UTC_ ... not
> sure what's the reason for it, but it breaks code that used the old
> symbol. this includes the boost-style threadpool library [1] ...
>
> so i wonder, is this change really needed?
>
>
The change TIME_UTC_ was motivated by  in 
https://svn.boost.org/trac/boost/ticket/6940 TIME_UTC is a macro in C11. 
As TIME_UTC was not documented this don't seem a break change. The 
change in threadpool seems quite simple.

Sorry for these inconveniences,
Vicente

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost

(Continue reading)

Tim Blechmann | 2 Jul 2012 09:57
Favicon
Gravatar

Re: thread & 1.50 issues


>> the second issue is a bit more severe, as it is an undocumented API
>> change: boost::TIME_UTC has been renamed to boost::TIME_UTC_ ... not
>> sure what's the reason for it, but it breaks code that used the old
>> symbol. this includes the boost-style threadpool library [1] ...
>>
>> so i wonder, is this change really needed?
>>
>>
> The change TIME_UTC_ was motivated by  in 
> https://svn.boost.org/trac/boost/ticket/6940 TIME_UTC is a macro in C11. 
> As TIME_UTC was not documented this don't seem a break change. The 
> change in threadpool seems quite simple.

sounds reasonable ... maybe TIME_UTC was not documented, but i found it
both in my code and in threadpool. unfortunately threadpool looks rather
unmaintained (no activity in 3 years and afaict it was supposed to be
submitted to boost), so i am not sure, if someone will actually fix it,
which is a shame, as i found the library very useful

tim

_______________________________________________
Unsubscribe & other changes: http://lists.boost.org/mailman/listinfo.cgi/boost


Gmane