Henry (Yu) Song - SISA | 25 Oct 21:27 2012

[patch] gl: for embedded device, we need smaller vbo size

From 702b7a6dbba035a1a0c71d3618c1d2b02be0561e Mon Sep 17 00:00:00 2001
From: Henry Song <henry.song <at> samsung.com>
Date: Thu, 25 Oct 2012 12:25:13 -0700
Subject: [PATCH] 256*1024 is really too big for embedded device to handle
 during glDraw() 16384 to 32768 seems to be the optimal size
 for VBO

---
 src/cairo-gl-private.h |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/cairo-gl-private.h b/src/cairo-gl-private.h
index d6b0554..a9e1d52 100644
--- a/src/cairo-gl-private.h
+++ b/src/cairo-gl-private.h
 <at>  <at>  -92,7 +92,11  <at>  <at> 
 #define CAIRO_GL_MAX_SHADERS_PER_CONTEXT 64

 /* VBO size that we allocate, smaller size means we gotta flush more often */
+#if CAIRO_HAS_GL_SURFACE
 #define CAIRO_GL_VBO_SIZE (256*1024)
+#elif CAIRO_HAS_GLESV2_SURFACE
+#define CAIRO_GL_VBO_SIZE 16384
+#endif

 typedef struct _cairo_gl_surface cairo_gl_surface_t;

-- 
1.7.9.5
--

-- 
(Continue reading)

Chris Wilson | 1 Nov 10:53 2012
Picon

Re: [patch] gl: for embedded device, we need smaller vbo size

On Thu, 25 Oct 2012 19:27:56 +0000, "Henry (Yu) Song - SISA" <hsong <at> sisa.samsung.com> wrote:
> From 702b7a6dbba035a1a0c71d3618c1d2b02be0561e Mon Sep 17 00:00:00 2001
> From: Henry Song <henry.song <at> samsung.com>
> Date: Thu, 25 Oct 2012 12:25:13 -0700
> Subject: [PATCH] 256*1024 is really too big for embedded device to handle
>  during glDraw() 16384 to 32768 seems to be the optimal size
>  for VBO

I'd rather keep most of these values the same between GL/GLES as the
optimisation constraints should be very similar, so I pushed a modified
patch to make it 16k for everyone until someone can present good
evidence for another value. At which point, they should also consider
how to automatically select the vbo size.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--

-- 
cairo mailing list
cairo <at> cairographics.org
http://lists.cairographics.org/mailman/listinfo/cairo


Gmane