headers
Mike Lischke | 12 Jun 2012 11:58

Auto complete choose single

Neil,

there's another (small) problem with auto completion, namely when setting to accept a single entry in the list. The problem here comes when you refresh the list while the user is typing by calling SCI_AUTOSHOW for each key press. When the list is already displayed from a previous call and ScintillaBase::AutoCompleteStart returns early because of the choose-single setting, the already displayed list is neither closed nor updated. Shouldn't it be closed then automatically?

--
You received this message because you are subscribed to the Google Groups "scintilla-interest" group.
To post to this group, send email to scintilla-interest <at> googlegroups.com.
To unsubscribe from this group, send email to scintilla-interest+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/scintilla-interest?hl=en.
Permalink | Reply |
headers
Neil Hodgson | 13 Jun 2012 00:57

Re: Auto complete choose single

Mike Lischke:

> there's another (small) problem with auto completion, namely when setting to accept a single entry in the
list. The problem here comes when you refresh the list while the user is typing by calling SCI_AUTOSHOW for
each key press. When the list is already displayed from a previous call and
ScintillaBase::AutoCompleteStart returns early because of the choose-single setting, the already
displayed list is neither closed nor updated. Shouldn't it be closed then automatically?

   I didn't write choose-single. Its quite old, from change set 246 which is credited to Ferda and Jan but I
can't find any relevant discussion. Its not something I have much feeling for - I'd detect that there was
only a single element in container code instead of calling into Scintilla. Its probably reasonable to
close an already displayed list.

   Neil

--

-- 
You received this message because you are subscribed to the Google Groups "scintilla-interest" group.
To post to this group, send email to scintilla-interest <at> googlegroups.com.
To unsubscribe from this group, send email to scintilla-interest+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/scintilla-interest?hl=en.
Permalink | Reply |
headers
Mike Lischke | 13 Jun 2012 08:58

Re: Auto complete choose single

>   I didn't write choose-single. Its quite old, from change set 246 which is credited to Ferda and Jan but I
can't find any relevant discussion. Its not something I have much feeling for - I'd detect that there was
only a single element in container code instead of calling into Scintilla. Its probably reasonable to
close an already displayed list.

That's what I did. I simply added an ac.Cancel() call right before the return.

Mike
-- 
www.soft-gems.net

--

-- 
You received this message because you are subscribed to the Google Groups "scintilla-interest" group.
To post to this group, send email to scintilla-interest <at> googlegroups.com.
To unsubscribe from this group, send email to scintilla-interest+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/scintilla-interest?hl=en.
Permalink | Reply |
headers
Neil Hodgson | 16 Jun 2012 12:52

Re: Auto complete choose single

Mike Lischke:

> That's what I did. I simply added an ac.Cancel() call right before the return.

   OK, committed.

   Neil

--

-- 
You received this message because you are subscribed to the Google Groups "scintilla-interest" group.
To post to this group, send email to scintilla-interest <at> googlegroups.com.
To unsubscribe from this group, send email to scintilla-interest+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/scintilla-interest?hl=en.
Permalink | Reply |

Gmane