Discussion of the Scintilla free source code editing component

John Vella | 16 Jun 2012 00:06

Using SCI_MARGINSETSTYLE doesn't trigger a redraw ... why not?

I noticed there's no notification of any kind sent to the parent(via NotifyParent) following a change in just a margin's style. I've got an RTEXT margin that I already have text in, but when I try to add some style data without modifying the text, there's no redraw triggered. This doesn't seem right as either a change in the text or the style data should require a redraw.

Am I missing something here or do I need to be responsible for scheduling a redraw manually?

Thanks,

-john

--
You received this message because you are subscribed to the Google Groups "scintilla-interest" group.
To view this discussion on the web visit https://groups.google.com/d/msg/scintilla-interest/-/kdMFnKmiKUMJ.
To post to this group, send email to scintilla-interest <at> googlegroups.com.
To unsubscribe from this group, send email to scintilla-interest+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/scintilla-interest?hl=en.

headers

Neil Hodgson | 16 Jun 2012 02:25

Re: Using SCI_MARGINSETSTYLE doesn't trigger a redraw ... why not?

John Vella:

I noticed there's no notification of any kind sent to the parent(via NotifyParent) following a change in just a margin's style. I've got an RTEXT margin that I already have text in, but when I try to add some style data without modifying the text, there's no redraw triggered. This doesn't seem right as either a change in the text or the style data should require a redraw.

OK, that's a bug. Committed a fix as changeset 4187.

http://scintilla.hg.sourceforge.net/hgweb/scintilla/scintilla/rev/4204ad136335

Neil

--
You received this message because you are subscribed to the Google Groups "scintilla-interest" group.
To post to this group, send email to scintilla-interest <at> googlegroups.com.
To unsubscribe from this group, send email to scintilla-interest+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/scintilla-interest?hl=en.

headers

John Vella | 16 Jun 2012 03:17

Re: Using SCI_MARGINSETSTYLE doesn't trigger a redraw ... why not?

Do you happen to know which release this fix will appear in? I need to add a workaround into my code and I wanted to add a comment about when the workaround is no longer needed.

-John

On Fri, Jun 15, 2012 at 5:25 PM, Neil Hodgson <nyamatongwe <at> me.com> wrote:

John Vella:

I noticed there's no notification of any kind sent to the parent(via NotifyParent) following a change in just a margin's style. I've got an RTEXT margin that I already have text in, but when I try to add some style data without modifying the text, there's no redraw triggered. This doesn't seem right as either a change in the text or the style data should require a redraw.

OK, that's a bug. Committed a fix as changeset 4187.

http://scintilla.hg.sourceforge.net/hgweb/scintilla/scintilla/rev/4204ad136335

Neil

--
You received this message because you are subscribed to the Google Groups "scintilla-interest" group.
To post to this group, send email to scintilla-interest <at> googlegroups.com.
To unsubscribe from this group, send email to scintilla-interest+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/scintilla-interest?hl=en.

headers

Neil Hodgson | 16 Jun 2012 03:31

Re: Using SCI_MARGINSETSTYLE doesn't trigger a redraw ... why not?

John Vella:

> Do you happen to know which release this fix will appear in? I need to add a workaround into my code and I
wanted to add a comment about when the workaround is no longer needed.

   The next release may be called 3.2.1. If a major change is added, it could be called 3.3.0 or even 4.0.0.

   Neil

--

-- 
You received this message because you are subscribed to the Google Groups "scintilla-interest" group.
To post to this group, send email to scintilla-interest <at> googlegroups.com.
To unsubscribe from this group, send email to scintilla-interest+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/scintilla-interest?hl=en.