headers
Nick | 11 Jun 2012 14:48
Picon
Favicon

[surf] patch to remove resizing if small

The most annoying feature of surf for me has been that when the 
window gets quite small suddenly everything is zoomed to a tiny and 
unreadable size. This can be a pain if for example I want to keep a 
couple of lines of text visible, and devote the rest to some other 
window. Given that it's so small, I can't see a useful use-case for 
the code, as the text is always thoroughly unreadable.

So, here is a patch to tip removing it. I think it should be applied 
to tip by somebody with Power.

Nick
Attachment (noresize.patch): text/x-diff, 1422 bytes
Permalink | Reply |
headers
pancake | 11 Jun 2012 14:51

Re: [surf] patch to remove resizing if small

i'm with you. your patch should be in tip.

On 06/11/12 14:48, Nick wrote:
> The most annoying feature of surf for me has been that when the
> window gets quite small suddenly everything is zoomed to a tiny and
> unreadable size. This can be a pain if for example I want to keep a
> couple of lines of text visible, and devote the rest to some other
> window. Given that it's so small, I can't see a useful use-case for
> the code, as the text is always thoroughly unreadable.
>
> So, here is a patch to tip removing it. I think it should be applied
> to tip by somebody with Power.
>
> Nick
Permalink | Reply |
headers
pancake | 11 Jun 2012 15:07

Re: [surf] patch to remove resizing if small

btw. without applying your patch:

surf.c: In function ‘gotheaders’:
surf.c:337:11: warning: variable ‘uri’ set but not used 
[-Wunused-but-set-variable]
surf.c: At top level:
surf.c:800:1: warning: ‘eval’ defined but not used [-Wunused-function]

On 06/11/12 14:48, Nick wrote:
> The most annoying feature of surf for me has been that when the
> window gets quite small suddenly everything is zoomed to a tiny and
> unreadable size. This can be a pain if for example I want to keep a
> couple of lines of text visible, and devote the rest to some other
> window. Given that it's so small, I can't see a useful use-case for
> the code, as the text is always thoroughly unreadable.
>
> So, here is a patch to tip removing it. I think it should be applied
> to tip by somebody with Power.
>
> Nick
Permalink | Reply |
headers
Connor Lane Smith | 11 Jun 2012 15:54
Gravatar

Re: [surf] patch to remove resizing if small

On 11 June 2012 13:48, Nick <suckless-dev <at> njw.me.uk> wrote:
> The most annoying feature of surf for me has been that when the
> window gets quite small suddenly everything is zoomed to a tiny and
> unreadable size.

Oh wow, until now I'd assumed this was some Webkit misfeature. Add me
to the patch tally.

On 11 June 2012 14:07, pancake <pancake <at> youterm.com> wrote:
> surf.c: In function ‘gotheaders’:
> surf.c:337:11: warning: variable ‘uri’ set but not used
> [-Wunused-but-set-variable]

This variable doesn't seem to have ever been used, since its inclusion in r182.

> surf.c: At top level:
> surf.c:800:1: warning: ‘eval’ defined but not used [-Wunused-function]

eval is a function for use in config.h; it might be nice to have an
example in config.def.h, which would also silence this warning.

cls
Permalink | Reply |
headers
Nick | 11 Jun 2012 16:12
Picon
Favicon

Re: [surf] patch to remove resizing if small

Quoth pancake:
> surf.c: In function ‘gotheaders’:
> surf.c:337:11: warning: variable ‘uri’ set but not used
> [-Wunused-but-set-variable]

Good spot. My gcc doesn't catch that, but you're right, it is 
unused. I'm attaching a patch that removes use of that variable, 
plus removes a couple of unused arguments from functions (found with 
-Wextra).

> surf.c: At top level:
> surf.c:800:1: warning: ‘eval’ defined but not used [-Wunused-function]

I think eval is probably useful to keep as a hook, though. For 
config.h funkiness or something else someone wants to do. I don't 
have strong feelings on the matter, though.

Nick
Attachment (misccleanup.patch): text/x-diff, 1907 bytes
Permalink | Reply |
headers
pancake | 11 Jun 2012 17:04

Re: [surf] patch to remove resizing if small

On 06/11/12 16:12, Nick wrote:
> Quoth pancake:
>> surf.c: In function ‘gotheaders’:
>> surf.c:337:11: warning: variable ‘uri’ set but not used
>> [-Wunused-but-set-variable]
> Good spot. My gcc doesn't catch that, but you're right, it is
> unused. I'm attaching a patch that removes use of that variable,
> plus removes a couple of unused arguments from functions (found with
> -Wextra).
didnt knew about this -Wextra flag, nice one!

the patch looks fine to me, so i'll commit it too.
>> surf.c: At top level:
>> surf.c:800:1: warning: ‘eval’ defined but not used [-Wunused-function]
> I think eval is probably useful to keep as a hook, though. For
> config.h funkiness or something else someone wants to do. I don't
> have strong feelings on the matter, though.
>
Yep, maybe someone is going to use it, so it's ok if we leave it here.

Anyway, i have noticed that META-h means go back and scroll left, which
is kinda weird, because i dont think anyone is going to scroll left few 
pixels
and then go back.. there are other dupped keybindings. we should fix that.

proposals?

--pancake
(Continue reading)

Permalink | Reply |
headers
stanio | 11 Jun 2012 18:32
Picon

Re: [surf] patch to remove resizing if small

* pancake <pancake <at> youterm.com> [2012-06-11 17:05]:
> Anyway, i have noticed that META-h means go back and scroll left, which

probably that originates from the snippet I posted and didn't post the
proper patch. In that case META-l should have the same issue. 

I have MOD|SHIFT-l/h for history navigation while MOD-l/h scroll
left/right as MOD-j/k do up/down. And that's my proposal. 

I like that MOD-j/k/l/h then behave the same way. It would be wired to
have another modificator for different directions of spatial navigation.

cheers
--s_
Permalink | Reply |
headers
pancake | 11 Jun 2012 18:37

Re: [surf] patch to remove resizing if small

On 06/11/12 18:32, stanio <at> cs.tu-berlin.de wrote:
> * pancake <pancake <at> youterm.com> [2012-06-11 17:05]:
>> Anyway, i have noticed that META-h means go back and scroll left, which
> probably that originates from the snippet I posted and didn't post the
> proper patch. In that case META-l should have the same issue.
>
> I have MOD|SHIFT-l/h for history navigation while MOD-l/h scroll
> left/right as MOD-j/k do up/down. And that's my proposal.
>
> I like that MOD-j/k/l/h then behave the same way. It would be wired to
> have another modificator for different directions of spatial navigation.
>
> cheers
> --s_
>
already commited, its MOD-[ui]
Permalink | Reply |
headers
stanio | 11 Jun 2012 15:12
Picon

Re: [surf] patch to remove resizing if small

> So, here is a patch to tip removing it. I think it should be applied 
> to tip by somebody with Power.

+1

--s_
Permalink | Reply |

Gmane