Bruno Prémont | 4 Feb 2009 10:11
Favicon

Let IPMI plugin skip periods "unsupported state" periods

On a server IPMI readings suddenly failed causing the plugin to stop
collecting data.
The following entries got logged:

ipmi plugin: sensor_read_handler: Removing sensor Temp 7 processor (3.6), because it failed with status 0x10000d5.
ipmi plugin: sensor_read_handler: Removing sensor Temp 6 processor (3.5), because it failed with status 0x10000d5.
ipmi plugin: sensor_read_handler: Removing sensor Temp 5 power_supply (10.5), because it failed with
status 0x10000d5.
ipmi plugin: sensor_read_handler: Removing sensor Temp 4 processor (3.4), because it failed with status 0x10000d5.
ipmi plugin: sensor_read_handler: Removing sensor Temp 3 processor (3.3), because it failed with status 0x10000d5.
ipmi plugin: sensor_read_handler: Removing sensor Temp 2 external_environment (39.1), because it
failed with status 0x10000d5.
ipmi plugin: sensor_read_handler: Removing sensor Temp 1 system_internal_expansion_board (16.1),
because it failed with status 0x10000d5.

This patch attempts to provide slightly better error message and just
skip current reading iteration if the error
IPMI_NOT_SUPPORTED_IN_PRESENT_STATE_CC is indicated.

This error happens e.g. when iLo firmware is upgraded (or reboots?) on
HP servers.

---
--- collectd-4.5.2/src/ipmi.c	2009-02-02 13:14:13.898736713 +0100
+++ collectd-4.5.2/src/ipmi.c	2009-02-02 13:21:58.987738365 +0100
 <at>  <at>  -148,11 +148,33  <at>  <at>  static void sensor_read_handler (ipmi_se
         }
       }
     }
+    else if (IPMI_IS_IPMI_ERR(err) && IPMI_GET_IPMI_ERR(err) == IPMI_NOT_SUPPORTED_IN_PRESENT_STATE_CC)
(Continue reading)

Florian Forster | 4 Feb 2009 23:07
Favicon

Re: Let IPMI plugin skip periods "unsupported state" periods

Hi Bruno,

On Wed, Feb 04, 2009 at 10:11:24AM +0100, Bruno Prémont wrote:
> This patch attempts to provide slightly better error message and just
> skip current reading iteration if the error
> IPMI_NOT_SUPPORTED_IN_PRESENT_STATE_CC is indicated.

thanks, I've applied the patch to master :)

If you think it should rather go into collectd-4.4, i. e. be included in
the next bugfix release(s), let me know..

Regards,
-octo
--

-- 
Florian octo Forster
Hacker in training
GnuPG: 0x91523C3D
http://verplant.org/

Gmane