headers
Alex Margarit | 1 Apr 2010 18:23
Picon

Re: A fix for Pylint #8776, inline message supression

Hi,

Thank you for your feedback, Sylvain. I agree that the root of the
problem lies in the block range.

I attached a new patch that removes the string comparison with a
cleaner instanceof check. Tests are included too.

Thank you,
Alex Margarit
Team Tahiti, U of T

On Mon, Mar 22, 2010 at 3:19 AM, Sylvain Thénault
<sylvain.thenault <at> logilab.fr> wrote:
> On 21 mars 11:33, Alex Margarit wrote:
>> Hey,
>
> Hi,
>
> sorry, I've been missing some time last week to review pylint patches.
> Hopefuly this week will be better :)
>
>> I was wondering if anyone had the time to take a look at the patch I
>> sent for Pylint ticket #8776. Do you think my solution is appropriate?
>>
>> http://www.logilab.org/ticket/8776
>>
>> I reattached the diff. Thanks,
>> diff -r f5f084e5267a ChangeLog
>> diff -r f5f084e5267a lint.py
(Continue reading)

Permalink | Reply |
headers
Sylvain Thénault | 2 Apr 2010 08:11
Picon
Favicon

Re: A fix for Pylint #8776, inline message supression

On 01 avril 12:23, Alex Margarit wrote:
> Hi,

Hi,

> Thank you for your feedback, Sylvain. I agree that the root of the
> problem lies in the block range.
> 
> I attached a new patch that removes the string comparison with a
> cleaner instanceof check. Tests are included too.

Great, some test. Now, if you agree the root of the pb lies in the block
range computation, why don't you try to find what's going wrong there ?
I definitly feel bad about fixing that pb  the way you propose it.

--

-- 
Sylvain Thénault                               LOGILAB, Paris (France)
Formations Python, Debian, Méth. Agiles: http://www.logilab.fr/formations
Développement logiciel sur mesure:       http://www.logilab.fr/services
CubicWeb, the semantic web framework:    http://www.cubicweb.org

_______________________________________________
Python-Projects mailing list
Python-Projects <at> lists.logilab.org
http://lists.logilab.org/mailman/listinfo/python-projects
Permalink | Reply |

Gmane