headers
Matthew Wakeling | 6 Jan 2011 13:22
Favicon

Patch for feature request


Attached is a patch for feature request 701101 for xdvik. This implements 
subpixel rendering. Only a small amount of code needed to be changed, as 
much of the required stuff was already there - just not quite finished.

There may be an issue with coloured text, which I may have time to look at 
later. Fixing it would involve putting the color_filter_image() step 
before the tinting step rather than after.

As it stands, B&W text looks really quite nice on my LCD screen with the 
patched version.

Thanks,

Matthew

--

-- 
 Experience is what allows you to recognise a mistake the second time you
 make it.
? patch1
? utils
? texk/kpathsea/stamp-auto
? texk/kpathsea/stamp-paths
Index: texk/xdvik/dvi-draw.c
===================================================================
RCS file: /cvsroot/xdvi/xdvik/texk/xdvik/dvi-draw.c,v
retrieving revision 1.384
diff -r1.384 dvi-draw.c
74c74,75
(Continue reading)

Permalink | Reply |
headers
Stefan Ulrich | 8 Jan 2011 23:24
Picon

Re: Patch for feature request

Hi,

thanks a lot for the patch - yes, I seem to recall that problems with
colours were one of the reasons that delayed finishing that code ...
also, I didn't have an LCD screen back then ;-) 
However it seems there's something buggy with the with computation - on
my system, anti-aliased text appears 3 times as wide:

Best regards,
Stefan

On Thu, 2011-01-06 at 12:22 +0000, Matthew Wakeling wrote:
> Attached is a patch for feature request 701101 for xdvik. This implements 
> subpixel rendering. Only a small amount of code needed to be changed, as 
> much of the required stuff was already there - just not quite finished.
> 
> There may be an issue with coloured text, which I may have time to look at 
> later. Fixing it would involve putting the color_filter_image() step 
> before the tinting step rather than after.
> 
> As it stands, B&W text looks really quite nice on my LCD screen with the 
> patched version.
> 
> Thanks,
> 
> Matthew
> 
> -- 
>  Experience is what allows you to recognise a mistake the second time you
>  make it.
(Continue reading)

Permalink | Reply |
headers
Stefan Ulrich | 8 Jan 2011 23:30
Picon

Re: Patch for feature request

Hi,

sorry, just discovered this new hotkey for "send" ... this should have
been:

> Hi,
> 
> thanks a lot for the patch - yes, I seem to recall that problems with
> colours were one of the reasons that delayed finishing that code ...
> also, I didn't have an LCD screen back then ;-) 
> However it seems there's something buggy with the with computation - on
> my system, anti-aliased text appears 3 times as wide:

http://i35.servimg.com/u/f35/13/85/91/89/screen10.png

(subpixel = rgb on the left, subpixel = none on the right.) This is on
Linux x86, X.Org 1.6.5. Which system did you test it on?

> Best regards,
> Stefan

------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web.   Learn how to 
best implement a security strategy that keeps consumers' information secure 
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl
Permalink | Reply |
headers
Matthew Wakeling | 9 Jan 2011 12:38
Favicon

Re: Patch for feature request

On Sat, 8 Jan 2011, Stefan Ulrich wrote:
> thanks a lot for the patch - yes, I seem to recall that problems with
> colours were one of the reasons that delayed finishing that code ...
> also, I didn't have an LCD screen back then ;-)
> However it seems there's something buggy with the with computation - on
> my system, anti-aliased text appears 3 times as wide:

That's weird. When I downloaded xdvik (from CVS), and compiled in subpixel 
rendering, all the characters were 1/3 too narrow. Most of my patch was 
specifically to correct that. Maybe you have a local change that fixes it 
as well as me?

I'm running on Debian Linux testing amd64, gcc 4.3.4, glibc 2.11.2

Matthew

--

-- 
"We did a risk management review.  We concluded that there was no risk
 of any management."        -- Hugo Mills <hugo <at> carfax.nildram.co.uk>

------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web.   Learn how to 
best implement a security strategy that keeps consumers' information secure 
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl
Permalink | Reply |
headers
Stefan Ulrich | 9 Jan 2011 14:13
Picon

Re: Patch for feature request

Hi,

OK, that's strange. My files were the vanilla CVS version. Which font
are you using? Here's my minimal example input file:

\documentclass{article}
\begin{document}
A
\end{document}

(Perhaps we should sort this out first via Email, off the list).
I'm using gcc 4.4.1, but when the first version of that code was written
about 6 years ago, I was using an older version of Linux, X, and gcc,
and had the same results ...

Cheers,
Stefan

------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web.   Learn how to 
best implement a security strategy that keeps consumers' information secure 
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl
Permalink | Reply |

Gmane