Re: [MERGE][BUG #276436] Simple fix to WT.open()

Martin Pool wrote:
> On Wed, Oct 1, 2008 at 6:32 AM, John Arbash Meinel
> <john <at> arbash-meinel.com> wrote:
>> This is just a simple fix to WT.open() and some associated tests. I
>> added them to bzrlib.tests.test_workingtree.TestDefaultFormat, because I
>> was surprised that there was no direct tests for the "TestWorkingTree"
>> to test the static members.
>>
>> I had considered deprecating not passing an argument (as obviously it
>> isn't being used), but I decided to keep it for now.
> 
> Actually I think the existence of these methods is a bit questionable:
> they just loop back in to BzrDir which eventually calls back in to
> WorkingTree.   So they're not adding much value in functionality, and
> I think any arguable simplicity in the api is outweighed by the
> potential confusion of having too many ways to do the same thing.
> 
> Of course that I'm still happy you stopped them failing in this case.

I personally use WT.open quite often in TIMEIT scripts or in interactive
discourse.

I *do* think that WT.open() is more concise than
BzrDir.open().open_workingtree().

> 
>> +    def test_open(self):
>> +        tree = self.make_branch_and_tree('.')
>> +        open_direct = tree.open('.')

Re: [MERGE][BUG #276436] Simple fix to WT.open()

Martin Pool wrote:

...

> It seems a bit strange or misleading to call these static methods on
> an instance.  Are you trying to make sure you get possibly overridden
> versions or something?  I'd at least hope for a comment...
> 

Fixed in attached.

John
=:->

# Bazaar merge directive format 2 (Bazaar 0.90)
# revision_id: john <at> arbash-meinel.com-20081001141438-goh72dzp4zmd69fr
# target_branch: http://bazaar-vcs.org/bzr/bzr.dev
# testament_sha1: 8ca62d2787f95c408a0eaebc24d473f15e54f4cc
# timestamp: 2008-10-01 09:14:55 -0500
# source_branch: http://bzr.arbash-meinel.com/branches/bzr/1.8-\
#   dev/trivial_276436
# base_revision_id: pqm <at> pqm.ubuntu.com-20080930002605-dfe533l96sx35va8
# 
# Begin patch
=== modified file 'bzrlib/tests/test_workingtree.py'
--- bzrlib/tests/test_workingtree.py	2008-05-12 04:07:49 +0000
+++ bzrlib/tests/test_workingtree.py	2008-10-01 14:14:38 +0000
@@ -81,6 +81,25 @@