A list for discussion of "Darcs Advanced Revision Control System".

Ganesh Sittampalam | 2 Jul 2009 22:34

failure in issue1248.sh

Hi,

In the 2.3 release branch and on HEAD, issue1248.sh fails for me, on a 
Debian lenny box (which is GHC 6.8.2, with some patch applied IIRC). I 
configured -fzlib (though I think that is now the default anyway, at least 
on the release branch).

The failure isn't actually related to what the test is checking for, but 
rather it happens in a call to darcs optimize --reorder, with the 
following error:

darcs: _darcs/patches/pending.new-0: openBinaryFile: resource busy (file 
is locked)

It seems to be triggered by the following patch:

Wed Jun  3 21:37:02 BST 2009  Petr Rockai <me <at> mornfall.net>
   * Fix index invalidation in the move command.
   Ignore-this: e2fa46552a1ac28aea587c96c0932298

Thorkil was unable to reproduce the problem on a couple of other machines 
with different GHCs etc, so it would be good to know if anyone else is 
seeing this.

Cheers,

Ganesh

headers

Petr Rockai | 6 Jul 2009 18:10

Re: failure in issue1248.sh

Hi,

Ganesh Sittampalam <ganesh <at> earth.li> writes:
> darcs: _darcs/patches/pending.new-0: openBinaryFile: resource busy (file is
> locked)
>
> It seems to be triggered by the following patch:
>
> Wed Jun  3 21:37:02 BST 2009  Petr Rockai <me <at> mornfall.net>
>   * Fix index invalidation in the move command.
>   Ignore-this: e2fa46552a1ac28aea587c96c0932298

I have managed to reproduce this a few times in various tests. It seems that
issue1248.sh is just the one that fails "most often", with a number of other
tests failing from time to time. I have seen issue1248.sh pass with same binary
that usually fails, too. All this with stock Debian GHC 6.8.2 (stable). I have
never seen the problem happen with GHC 6.10.3. Moreover, the mentioned patch
does not seem to change anything about this behaviour for me.

The code that is failing seems to reside in Darcs.Lock, likely the atomic write
file operations: writeAtomicFilePS and its helpers. I haven't had more time to
isolate the problem so far. I'll try to resolve this in time for beta 2 though.

Yours,
   Petr.

--

-- 
Petr Ročkai | http://web.mornfall.net
A physicist is an atom's way of knowing about atoms. (George Wald)
_______________________________________________

(Continue reading)

headers

Simon Marlow | 7 Jul 2009 13:01

Re: failure in issue1248.sh

On 06/07/2009 17:10, Petr Rockai wrote:
> Hi,
>
> Ganesh Sittampalam<ganesh <at> earth.li>  writes:
>> darcs: _darcs/patches/pending.new-0: openBinaryFile: resource busy (file is
>> locked)
>>
>> It seems to be triggered by the following patch:
>>
>> Wed Jun  3 21:37:02 BST 2009  Petr Rockai<me <at> mornfall.net>
>>    * Fix index invalidation in the move command.
>>    Ignore-this: e2fa46552a1ac28aea587c96c0932298
>
> I have managed to reproduce this a few times in various tests. It seems that
> issue1248.sh is just the one that fails "most often", with a number of other
> tests failing from time to time. I have seen issue1248.sh pass with same binary
> that usually fails, too. All this with stock Debian GHC 6.8.2 (stable). I have
> never seen the problem happen with GHC 6.10.3. Moreover, the mentioned patch
> does not seem to change anything about this behaviour for me.
>
> The code that is failing seems to reside in Darcs.Lock, likely the atomic write
> file operations: writeAtomicFilePS and its helpers. I haven't had more time to
> isolate the problem so far. I'll try to resolve this in time for beta 2 though.

Could be this bug:

http://hackage.haskell.org/trac/ghc/ticket/2122

fix in GHC 6.8.3.

(Continue reading)