Hyrum K. Wright | 1 Jun 2006 01:05
Picon

Re: [PATCH] Don't ignore multiple --target switches

Julian Foad wrote:
> Hyrum K. Wright wrote:
>> This patch fixes a bug where multiple --target switches fail silently
>> for all but the final one.  Instead, this patch concatenates all targets
>> specified by multiple --target switches into one array.
> 
> Ah, but is it a bug?

I believe you were the one to point it out :) [1]:
-------------
Existing Bugs:

* If multiple "--targets" options are given, all but the last are
silently ignored.
-------------
[1] http://svn.haxx.se/dev/archive-2006-04/0831.shtml

> We intentionally ignore all but the last of multiple occurrences of an
> option-taking-an-argument (except "-r"/"--revision"), perhaps in order
> to let the user have an alias which begins with some default option
> value and yet can be overridden with another value later on the command
> line.  e.g.
> 
> alias mysvn='svn --config-dir=~/my-svn-config/'
> mysvn diff                              # Uses ~/my-svn-config/
> mysvn diff --config-dir=~/.subversion/  # No error; uses ~/.subversion/

For the --config-dir option, this is understandable; it doesn't make
sense to use multiple config-dirs for a particular invocation of svn.
However, with --targets, a user could conceivably have an alias with a
(Continue reading)


Gmane