gmane.comp.version-control.subversion.trac.devel

Ted Gifford | 1 May 16:13

[Trac-dev] Patches I use


Here's two patches I use that I don't see in trunk. Is it better to 
submit them in the tracker?

1. I mentioned this one in trac-users. It redirects to the raw download 
for attachments that aren't rendered (wiki probably isn't the best 
section of config...)

--- c:\tracdev\trac\trac\attachment.py    2008-04-30 16:50:48.833972400 
-0400
+++ C:\Python25\lib\site-packages\trac\attachment.py    2008-04-30 
16:53:08.910304400 -0400
@@ -399,6 +399,9 @@
             data = self._render_form(req, attachment)
         else:
             data = self._render_view(req, attachment)
+            if self.env.config.get('wiki','forward_to_raw_href') and 
data['preview']['rendered'] is None:
+                req.redirect(data['preview']['raw_href'])
+                return # cancel all template processing

         add_stylesheet(req, 'common/css/code.css')
         return 'attachment.html', data, None

2. Added data argument to match post_process_request api, and pass None 
for post_process requests arguments.

--- c:\tracdev\trac\trac\versioncontrol\api.py    2008-04-30 
16:50:43.740287600 -0400
+++ C:\Python25\lib\site-packages\trac\versioncontrol\api.py

(Continue reading)

headers

John Hampton | 1 May 16:27

[Trac-dev] Re: Patches I use


Ted Gifford wrote:
> Here's two patches I use that I don't see in trunk. Is it better to 
> submit them in the tracker?

Yes.  Creating tickets explaining the patches and the reasons you think 
they are beneficial is the best method for actually getting them accepted.

-John

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Development" group.
To post to this group, send email to trac-dev <at> googlegroups.com
To unsubscribe from this group, send email to trac-dev-unsubscribe <at> googlegroups.com
For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

headers

Jeroen Ruigrok van der Werven | 1 May 19:56

[Trac-dev] Re: Patches I use


-On [20080501 16:49], Ted Gifford (tedfordgif <at> gmail.com) wrote:
>Here's two patches I use that I don't see in trunk. Is it better to 
>submit them in the tracker?

I'm probably going to sound like a smartalec for saying this, but Trac is an
issue tracking system. :-P

So yes. :)

--

-- 
Jeroen Ruigrok van der Werven <asmodai(-at-)in-nomine.org> / asmodai
イェルーン ラウフロック ヴァン デル ウェルヴェン
http://www.in-nomine.org/ | http://www.rangaku.org/ | GPG: 2EAC625B
Want ik kan niet leven zonder alles of niets...

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "Trac Development" group.
To post to this group, send email to trac-dev <at> googlegroups.com
To unsubscribe from this group, send email to trac-dev-unsubscribe <at> googlegroups.com
For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en
-~----------~----~----~----~------~----~------~--~---

headers

osimons | 1 May 23:15

[Trac-dev] Re: Patches I use


On May 1, 4:17 pm, Ted Gifford <tedford...@gmail.com> wrote:
> Here's two patches I use that I don't see in trunk. Is it better to
> submit them in the tracker?
>
> 1. I mentioned this one in trac-users. It redirects to the raw download
> for attachments that aren't rendered (wiki probably isn't the best
> section of config...)

I see you already found a ticket for this (#5718). Good.

> 2. Added data argument to match post_process_request api, and pass None
> for post_process requests arguments.
>
> --- c:\tracdev\trac\trac\versioncontrol\api.py    2008-04-30
> 16:50:43.740287600 -0400
> +++ C:\Python25\lib\site-packages\trac\versioncontrol\api.py
> 2008-04-30 17:02:30.371867600 -0400
> @@ -82,8 +82,8 @@
>                                "(%(error)s)", error=e.message))
>          return handler
>
> -    def post_process_request(self, req, template, content_type):
> -        return (template, content_type)
> +    def post_process_request(self, req, template, data, content_type):
> +        return (template, data, content_type)
>
>      # IResourceManager methods
>

(Continue reading)