Developer mailing list for the Trac Project

Rob Guttman | 16 May 2012 14:58

[Trac-dev] [ANN] CodeReviewer plugin

Gerrit is a great idea for a code review tool but it ended up being a poor fit for our internal (non-open source project) needs. I've used and considered others (e.g., Crucible, Review Board, GitHub), but what I really wanted for my team was something simple, lightweight and better integrated into our existing Trac ticket workflow. So I built this plugin:

http://trac-hacks.org/wiki/CodeReviewerPlugin

Hope others find this useful. Feedback welcome.

Cheers.

- Rob

--
You received this message because you are subscribed to the Google Groups "Trac Development" group.
To post to this group, send email to trac-dev <at> googlegroups.com.
To unsubscribe from this group, send email to trac-dev+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en.

headers

Ethan Jucovy | 16 May 2012 16:33

[Trac] Re: [Trac-dev] [ANN] CodeReviewer plugin

On Wed, May 16, 2012 at 8:58 AM, Rob Guttman <robguttman-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:

Gerrit is a great idea for a code review tool but it ended up being a poor fit for our internal (non-open source project) needs. I've used and considered others (e.g., Crucible, Review Board, GitHub), but what I really wanted for my team was something simple, lightweight and better integrated into our existing Trac ticket workflow. So I built this plugin:

http://trac-hacks.org/wiki/CodeReviewerPlugin

Hope others find this useful. Feedback welcome.

This looks really great. I've recently been feeling a need for something like this for internal projects myself. The CommitTicketReferenceMacro and automatic comments on tickets referenced in the reviewed changeset are really nice touches and I think will make this exactly what I need. I'm going to try it out -- thanks a lot for releasing this!

-Ethan

--
You received this message because you are subscribed to the Google Groups "Trac Users" group.
To post to this group, send email to trac-users-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
To unsubscribe from this group, send email to trac-users+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/trac-users?hl=en.

headers

Olemis Lang | 16 May 2012 17:30

Re: [Trac] Re: [Trac-dev] [ANN] CodeReviewer plugin

On 5/16/12, Ethan Jucovy <ethan.jucovy@...> wrote:
> On Wed, May 16, 2012 at 8:58 AM, Rob Guttman <robguttman@...> wrote:
>
>> Gerrit <http://code.google.com/p/gerrit/> is a great idea for a code
>> review tool but it ended up being a poor fit for our internal (non-open
>> source project) needs.   I've used and considered others (e.g., Crucible,
>> Review Board, GitHub), but what I really wanted for my team was something
>> simple, lightweight and better integrated into our existing Trac ticket
>> workflow.   So I built this plugin:
>>
>>   http://trac-hacks.org/wiki/CodeReviewerPlugin
>>
>> Hope others find this useful.  Feedback welcome.
>>
>
> This looks really great.  I've recently been feeling a need for something
> like this for internal projects myself.  The CommitTicketReferenceMacro and
> automatic comments on tickets referenced in the reviewed changeset are
> really nice touches
>
[...]

I second that !
Great !

-- 
Regards,

Olemis.

Blog ES: http://simelo-es.blogspot.com/
Blog EN: http://simelo-en.blogspot.com/

Featured article:

--

-- 
You received this message because you are subscribed to the Google Groups "Trac Users" group.
To post to this group, send email to trac-users@...
To unsubscribe from this group, send email to trac-users+unsubscribe@...
For more options, visit this group at http://groups.google.com/group/trac-users?hl=en.

headers

Mitar | 14 Jul 2012 00:48

Re: [Trac-dev] [ANN] CodeReviewer plugin

Hi!

But this works only for whole commits and not for each line? I find
GitHub line commenting very very useful and have not found a good
solution for internal Trac projects.

Mitar

On Wed, May 16, 2012 at 5:58 AM, Rob Guttman <robguttman <at> gmail.com> wrote:
> Gerrit is a great idea for a code review tool but it ended up being a poor
> fit for our internal (non-open source project) needs.   I've used and
> considered others (e.g., Crucible, Review Board, GitHub), but what I really
> wanted for my team was something simple, lightweight and better integrated
> into our existing Trac ticket workflow.   So I built this plugin:
>
>   http://trac-hacks.org/wiki/CodeReviewerPlugin
>
> Hope others find this useful.  Feedback welcome.
>
> Cheers.
> - Rob
>
> --
> You received this message because you are subscribed to the Google Groups
> "Trac Development" group.
> To post to this group, send email to trac-dev <at> googlegroups.com.
> To unsubscribe from this group, send email to
> trac-dev+unsubscribe <at> googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/trac-dev?hl=en.

--

-- 
You received this message because you are subscribed to the Google Groups "Trac Development" group.
To post to this group, send email to trac-dev <at> googlegroups.com.
To unsubscribe from this group, send email to trac-dev+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en.

headers

Rob Guttman | 14 Jul 2012 01:04

Re: [Trac-dev] [ANN] CodeReviewer plugin

Agreed, line commenting is on wish list. There *are* better alternatives out there, but this (rather new) plugin integrates well with our current Trac workflow.

I'm willing to add line commenting and other features where there's interest. Please create trac-hack tickets for what you would like to see.

Sent from Galaxy Nexus

On Jul 13, 2012 6:48 PM, "Mitar" <mmitar <at> gmail.com> wrote:

Hi!

But this works only for whole commits and not for each line? I find
GitHub line commenting very very useful and have not found a good
solution for internal Trac projects.

Mitar

On Wed, May 16, 2012 at 5:58 AM, Rob Guttman <robguttman <at> gmail.com> wrote:
> Gerrit is a great idea for a code review tool but it ended up being a poor
> fit for our internal (non-open source project) needs. I've used and
> considered others (e.g., Crucible, Review Board, GitHub), but what I really
> wanted for my team was something simple, lightweight and better integrated
> into our existing Trac ticket workflow. So I built this plugin:
>
> http://trac-hacks.org/wiki/CodeReviewerPlugin
>
> Hope others find this useful. Feedback welcome.
>
> Cheers.
> - Rob
>
> --
> You received this message because you are subscribed to the Google Groups
> "Trac Development" group.
> To post to this group, send email to trac-dev <at> googlegroups.com.
> To unsubscribe from this group, send email to
> trac-dev+unsubscribe <at> googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/trac-dev?hl=en.

--
You received this message because you are subscribed to the Google Groups "Trac Development" group.
To post to this group, send email to trac-dev <at> googlegroups.com.
To unsubscribe from this group, send email to trac-dev+unsubscribe <at> googlegroups.com.
For more options, visit this group at http://groups.google.com/group/trac-dev?hl=en.