Cornelius | 9 Sep 2008 18:13
Picon
Gravatar

[PATCH] fix Win32 edit_file problem

i set SVN_EDITOR as vim , svk should launch my vim to edit log message when i commit , but I encountered this problem:

"Can't Spawn cmd.exe: no such file or directory"


it seems that "system {$editor[0]} ( .. ) " can't work on windows.
this patch should let it works.
--
Best Regards.
Cornelius
Attachment (edit_file.patch): text/x-diff, 755 bytes
_______________________________________________
svk-devel mailing list
svk-devel <at> bestpractical.com
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/svk-devel
Cornelius | 10 Sep 2008 21:10
Picon
Gravatar

Re: [PATCH] fix Win32 edit_file problem

updated, use can_run( ) to get full path of binary.
you can just "set SVN_EDITOR=vim" or "set SVN_EDITOR=notepad" to launch your editor on Linux or Windows.

Best Regards.
Cornelius


On Wed, Sep 10, 2008 at 12:13 AM, Cornelius <cornelius.howl <at> gmail.com> wrote:
i set SVN_EDITOR as vim , svk should launch my vim to edit log message when i commit , but I encountered this problem:

"Can't Spawn cmd.exe: no such file or directory"


it seems that "system {$editor[0]} ( .. ) " can't work on windows.
this patch should let it works.
--
Best Regards.
Cornelius

Attachment (Util.pm.diff): text/x-diff, 1114 bytes
_______________________________________________
svk-devel mailing list
svk-devel <at> bestpractical.com
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/svk-devel
Cheng-Lung Sung | 12 Sep 2008 09:58
Picon
Favicon
Gravatar

Re: [PATCH] fix Win32 edit_file problem

Hi Cornelius,

    The patch is revised and committed in r3087. Thank you.

Regards,

On Thu, Sep 11, 2008 at 03:10:05AM +0800, Cornelius wrote:
> updated, use can_run( ) to get full path of binary.
> you can just "set SVN_EDITOR=vim" or "set SVN_EDITOR=notepad" to launch your
> editor on Linux or Windows.
> 
> Best Regards.
> Cornelius
> 
> 
> On Wed, Sep 10, 2008 at 12:13 AM, Cornelius <cornelius.howl <at> gmail.com>wrote:
> 
> > i set SVN_EDITOR as vim , svk should launch my vim to edit log message when
> > i commit , but I encountered this problem:
> >
> > "Can't Spawn cmd.exe: no such file or directory"
> > <http://twitter.com/c9s/statuses/913940627>
> >
> > it seems that "system {$editor[0]} ( .. ) " can't work on windows.
> > this patch should let it works.
> > --
> > Best Regards.
> > Cornelius
> >

--

-- 
Alan Cheng-Lung Sung - clsung <at> 
_______________________________________________
svk-devel mailing list
svk-devel <at> bestpractical.com
http://lists.bestpractical.com/cgi-bin/mailman/listinfo/svk-devel


Gmane