j.glisse | 4 May 16:28 2012
Picon

[PATCH] drm/radeon: don't mess with hot plug detect for eDP or LVDS connector

From: Jerome Glisse <jglisse <at> redhat.com>

It seems imac pannel doesn't like whe we change the hot plug setup
and then refuse to work. This should fix :
https://bugzilla.redhat.com/show_bug.cgi?id=726143

Signed-off-by: Matthew Garrett <mjg <at> redhat.com>
Signed-off-by: Jerome Glisse <jglisse <at> redhat.com>
---
 drivers/gpu/drm/radeon/r600.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/radeon/r600.c b/drivers/gpu/drm/radeon/r600.c
index 4fbc590..5fd0490 100644
--- a/drivers/gpu/drm/radeon/r600.c
+++ b/drivers/gpu/drm/radeon/r600.c
 <at>  <at>  -713,6 +713,14  <at>  <at>  void r600_hpd_init(struct radeon_device *rdev)
 	list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
 		struct radeon_connector *radeon_connector = to_radeon_connector(connector);

+		if (connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
+		    connector->connector_type == DRM_MODE_CONNECTOR_LVDS) {
+			/* don't try to enable HDP on eDP or LVDS help to avoid
+			 * issue such as:
+			 * https://bugzilla.redhat.com/show_bug.cgi?id=726143
+			 */
+			continue;
+		}
 		if (ASIC_IS_DCE3(rdev)) {
 			u32 tmp = DC_HPDx_CONNECTION_TIMER(0x9c4) | DC_HPDx_RX_INT_TIMER(0xfa);
(Continue reading)

Michel Dänzer | 4 May 16:44 2012
Face
Picon

Re: [PATCH] drm/radeon: don't mess with hot plug detect for eDP or LVDS connector

On Fre, 2012-05-04 at 10:28 -0400, j.glisse <at> gmail.com wrote: 
> From: Jerome Glisse <jglisse <at> redhat.com>
> 
> It seems imac pannel doesn't like whe we change the hot plug setup
> and then refuse to work. This should fix :
> https://bugzilla.redhat.com/show_bug.cgi?id=726143
> 
> Signed-off-by: Matthew Garrett <mjg <at> redhat.com>
> Signed-off-by: Jerome Glisse <jglisse <at> redhat.com>
[...] 
> +		if (connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
> +		    connector->connector_type == DRM_MODE_CONNECTOR_LVDS) {
> +			/* don't try to enable HDP on eDP or LVDS help to avoid

I think this should say 'HPD', not 'HDP'.

--

-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer
_______________________________________________
dri-devel mailing list
dri-devel <at> lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
Jerome Glisse | 4 May 17:01 2012
Picon

Re: [PATCH] drm/radeon: don't mess with hot plug detect for eDP or LVDS connector

On Fri, May 4, 2012 at 10:44 AM, Michel Dänzer <michel <at> daenzer.net> wrote:
> On Fre, 2012-05-04 at 10:28 -0400, j.glisse <at> gmail.com wrote:
>> From: Jerome Glisse <jglisse <at> redhat.com>
>>
>> It seems imac pannel doesn't like whe we change the hot plug setup
>> and then refuse to work. This should fix :
>> https://bugzilla.redhat.com/show_bug.cgi?id=726143
>>
>> Signed-off-by: Matthew Garrett <mjg <at> redhat.com>
>> Signed-off-by: Jerome Glisse <jglisse <at> redhat.com>
> [...]
>> +             if (connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
>> +                 connector->connector_type == DRM_MODE_CONNECTOR_LVDS) {
>> +                     /* don't try to enable HDP on eDP or LVDS help to avoid
>
> I think this should say 'HPD', not 'HDP'.

It should :) v2 on its way

>
> --
> Earthling Michel Dänzer           |                   http://www.amd.com
> Libre software enthusiast         |          Debian, X and DRI developer

Gmane