Nicolas George | 17 Jun 2012 22:23
Favicon

[PATCH] ffprobe: dump AVPacket.convergence_duration.


Signed-off-by: Nicolas George <nicolas.george <at> normalesup.org>
---
 doc/ffprobe.xsd |    2 ++
 ffprobe.c       |    2 ++
 2 files changed, 4 insertions(+)

diff --git a/doc/ffprobe.xsd b/doc/ffprobe.xsd
index 7f12a36..3a4a8cc 100644
--- a/doc/ffprobe.xsd
+++ b/doc/ffprobe.xsd
 <at>  <at>  -39,6 +39,8  <at>  <at> 
       <xsd:attribute name="dts_time"      type="xsd:float" />
       <xsd:attribute name="duration"      type="xsd:long"  />
       <xsd:attribute name="duration_time" type="xsd:float" />
+      <xsd:attribute name="convergence_duration"      type="xsd:long"  />
+      <xsd:attribute name="convergence_duration_time" type="xsd:float" />
       <xsd:attribute name="size"          type="xsd:long" use="required" />
       <xsd:attribute name="pos"           type="xsd:long"  />
       <xsd:attribute name="flags"         type="xsd:string" use="required" />
diff --git a/ffprobe.c b/ffprobe.c
index 0e34f6b..f65e460 100644
--- a/ffprobe.c
+++ b/ffprobe.c
 <at>  <at>  -1581,6 +1581,8  <at>  <at>  static void show_packet(WriterContext *w, AVFormatContext *fmt_ctx, AVPacket *pk
     print_time("dts_time",        pkt->dts, &st->time_base);
     print_duration_ts("duration",        pkt->duration);
     print_duration_time("duration_time", pkt->duration, &st->time_base);
+    print_duration_ts("convergence_duration", pkt->convergence_duration);
+    print_duration_time("convergence_duration_time", pkt->convergence_duration, &st->time_base);
(Continue reading)

Paul B Mahol | 17 Jun 2012 23:24
Picon
Gravatar

Re: [PATCH] ffprobe: dump AVPacket.convergence_duration.

On 6/17/12, Nicolas George <nicolas.george <at> normalesup.org> wrote:
>
> Signed-off-by: Nicolas George <nicolas.george <at> normalesup.org>
> ---
>  doc/ffprobe.xsd |    2 ++
>  ffprobe.c       |    2 ++
>  2 files changed, 4 insertions(+)
>

LGTM
Stefano Sabatini | 18 Jun 2012 01:17
Picon

Re: [PATCH] ffprobe: dump AVPacket.convergence_duration.

On date Sunday 2012-06-17 22:23:11 +0200, Nicolas George encoded:
> 
> Signed-off-by: Nicolas George <nicolas.george <at> normalesup.org>
> ---
>  doc/ffprobe.xsd |    2 ++
>  ffprobe.c       |    2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/doc/ffprobe.xsd b/doc/ffprobe.xsd
> index 7f12a36..3a4a8cc 100644
> --- a/doc/ffprobe.xsd
> +++ b/doc/ffprobe.xsd
>  <at>  <at>  -39,6 +39,8  <at>  <at> 
>        <xsd:attribute name="dts_time"      type="xsd:float" />
>        <xsd:attribute name="duration"      type="xsd:long"  />
>        <xsd:attribute name="duration_time" type="xsd:float" />
> +      <xsd:attribute name="convergence_duration"      type="xsd:long"  />
> +      <xsd:attribute name="convergence_duration_time" type="xsd:float" />
>        <xsd:attribute name="size"          type="xsd:long" use="required" />
>        <xsd:attribute name="pos"           type="xsd:long"  />
>        <xsd:attribute name="flags"         type="xsd:string" use="required" />
> diff --git a/ffprobe.c b/ffprobe.c
> index 0e34f6b..f65e460 100644
> --- a/ffprobe.c
> +++ b/ffprobe.c
>  <at>  <at>  -1581,6 +1581,8  <at>  <at>  static void show_packet(WriterContext *w, AVFormatContext *fmt_ctx, AVPacket *pk
>      print_time("dts_time",        pkt->dts, &st->time_base);
>      print_duration_ts("duration",        pkt->duration);
>      print_duration_time("duration_time", pkt->duration, &st->time_base);
> +    print_duration_ts("convergence_duration", pkt->convergence_duration);
(Continue reading)

Nicolas George | 18 Jun 2012 10:00
Favicon

Re: [PATCH] ffprobe: dump AVPacket.convergence_duration.

Le primidi 1er messidor, an CCXX, Stefano Sabatini a écrit :
> LGTM as well.

Thanks, pushed.

> I wonder if we should add fields to the end of the list in order to
> avoid to break the order of items (on the other hand keeping related
> fields close is better).

My guess is that we will not manage to keep it stable in the long run,
especially with the fork adding fields as well, so I kept related fields
close.

Regards,

--

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Gmane