Stefano Sabatini | 1 Jul 2012 19:04
Picon

[PATCH] lavf/segment: add debugging log in case of invalid filename template

Better rather than silently exit.
---
 libavformat/segment.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/libavformat/segment.c b/libavformat/segment.c
index de2118e..d44de1f 100644
--- a/libavformat/segment.c
+++ b/libavformat/segment.c
 <at>  <at>  -97,8 +97,10  <at>  <at>  static int segment_start(AVFormatContext *s)
         seg->number %= seg->wrap;

     if (av_get_frame_filename(oc->filename, sizeof(oc->filename),
-                              s->filename, seg->number++) < 0)
+                              s->filename, seg->number++) < 0) {
+        av_log(oc, AV_LOG_ERROR, "Invalid segment filename template '%s'\n", s->filename);
         return AVERROR(EINVAL);
+    }

     if ((err = avio_open2(&oc->pb, oc->filename, AVIO_FLAG_WRITE,
                           &s->interrupt_callback, NULL)) < 0)
--

-- 
1.7.5.4
Michael Niedermayer | 2 Jul 2012 00:38
Picon
Picon

Re: [PATCH] lavf/segment: add debugging log in case of invalid filename template

On Sun, Jul 01, 2012 at 07:04:34PM +0200, Stefano Sabatini wrote:
> Better rather than silently exit.
> ---
>  libavformat/segment.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)

LGTM

[...]
--

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Stefano Sabatini | 3 Jul 2012 23:29
Picon

Re: [PATCH] lavf/segment: add debugging log in case of invalid filename template

On date Monday 2012-07-02 00:38:34 +0200, Michael Niedermayer encoded:
> On Sun, Jul 01, 2012 at 07:04:34PM +0200, Stefano Sabatini wrote:
> > Better rather than silently exit.
> > ---
> >  libavformat/segment.c |    4 +++-
> >  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> LGTM

Pushed.
--

-- 
FFmpeg = Fancy and Fundamental Mournful Pitiful Enlightening Geek

Gmane