Nicolas George | 31 Jul 2012 11:54
Favicon

[PATCH] ffprobe: adapt XML schema to -show_data option.

Fix trac ticket #1588.

Signed-off-by: Nicolas George <nicolas.george <at> normalesup.org>
---
 doc/ffprobe.xsd |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/ffprobe.xsd b/doc/ffprobe.xsd
index 3a4a8cc..162149a 100644
--- a/doc/ffprobe.xsd
+++ b/doc/ffprobe.xsd
 <at>  <at>  -44,6 +44,7  <at>  <at> 
       <xsd:attribute name="size"          type="xsd:long" use="required" />
       <xsd:attribute name="pos"           type="xsd:long"  />
       <xsd:attribute name="flags"         type="xsd:string" use="required" />
+      <xsd:attribute name="data"          type="xsd:string" />
     </xsd:complexType>

     <xsd:complexType name="frameType">
 <at>  <at>  -92,6 +93,7  <at>  <at> 
       <xsd:attribute name="codec_time_base"  type="xsd:string" use="required"/>
       <xsd:attribute name="codec_tag"        type="xsd:string" use="required"/>
       <xsd:attribute name="codec_tag_string" type="xsd:string" use="required"/>
+      <xsd:attribute name="extradata"        type="xsd:string" />

       <!-- video attributes -->
       <xsd:attribute name="width"                type="xsd:int"/>
--

-- 
1.7.10.4
(Continue reading)

Stefano Sabatini | 31 Jul 2012 14:05
Picon

Re: [PATCH] ffprobe: adapt XML schema to -show_data option.

On date Tuesday 2012-07-31 11:54:20 +0200, Nicolas George encoded:
> Fix trac ticket #1588.
> 
> Signed-off-by: Nicolas George <nicolas.george <at> normalesup.org>
> ---
>  doc/ffprobe.xsd |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/doc/ffprobe.xsd b/doc/ffprobe.xsd
> index 3a4a8cc..162149a 100644
> --- a/doc/ffprobe.xsd
> +++ b/doc/ffprobe.xsd
>  <at>  <at>  -44,6 +44,7  <at>  <at> 
>        <xsd:attribute name="size"          type="xsd:long" use="required" />
>        <xsd:attribute name="pos"           type="xsd:long"  />
>        <xsd:attribute name="flags"         type="xsd:string" use="required" />
> +      <xsd:attribute name="data"          type="xsd:string" />
>      </xsd:complexType>
>  
>      <xsd:complexType name="frameType">
>  <at>  <at>  -92,6 +93,7  <at>  <at> 
>        <xsd:attribute name="codec_time_base"  type="xsd:string" use="required"/>
>        <xsd:attribute name="codec_tag"        type="xsd:string" use="required"/>
>        <xsd:attribute name="codec_tag_string" type="xsd:string" use="required"/>
> +      <xsd:attribute name="extradata"        type="xsd:string" />
>  
>        <!-- video attributes -->
>        <xsd:attribute name="width"                type="xsd:int"/>
[...]

(Continue reading)

Nicolas George | 31 Jul 2012 14:50
Favicon

Re: [PATCH] ffprobe: adapt XML schema to -show_data option.

Le quartidi 14 thermidor, an CCXX, Stefano Sabatini a écrit :
> That's not enough, you need to move show_tags *before*
> writer_print_data(), since show_tags will close the stream element.

True. I tested only with files without tags.

> Too bad we all missed it during review.

It was not a regression, so this is not really a problem.

New patch sent.

Regards,

--

-- 
  Nicolas George
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel <at> ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Gmane