Matthieu Bouron | 2 Jul 21:33 2013
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Tue, Jul 2, 2013 at 7:46 PM, Michael Niedermayer <michaelni <at> gmx.at>wrote:

> On Sun, Jun 30, 2013 at 04:15:46PM +0200, Matthieu Bouron wrote:
> > Cover art muxing is done by introducing the -cover_stream_index option
> > which takes an output stream index as argument.
> > The stream used for the cover art is not muxed as a track in the
> > resulting file.
> > ---
> >  libavformat/movenc.c     | 157
> +++++++++++++++++++++++++++++++++++++++++++----
> >  libavformat/movenc.h     |   5 ++
> >  libavformat/movenchint.c |   1 +
> >  3 files changed, 152 insertions(+), 11 deletions(-)
> >
> > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > index 5577530..f411493 100644
> > --- a/libavformat/movenc.c
> > +++ b/libavformat/movenc.c
> >  <at>  <at>  -63,6 +63,7  <at>  <at>  static const AVOption options[] = {
> >      { "ism_lookahead", "Number of lookahead entries for ISM files",
> offsetof(MOVMuxContext, ism_lookahead), AV_OPT_TYPE_INT, {.i64 = 0}, 0,
> INT_MAX, AV_OPT_FLAG_ENCODING_PARAM},
> >      { "use_editlist", "use edit list", offsetof(MOVMuxContext,
> use_editlist), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 1,
> AV_OPT_FLAG_ENCODING_PARAM},
> >      { "video_track_timescale", "set timescale of all video tracks",
> offsetof(MOVMuxContext, video_track_timescale), AV_OPT_TYPE_INT, {.i64 =
> 0}, 0, INT_MAX, AV_OPT_FLAG_ENCODING_PARAM},
> > +    { "cover_stream_index", "video stream index to use for cover art",
> offsetof(MOVMuxContext, cover_stream_index), AV_OPT_TYPE_INT, {.i64 = -1},
(Continue reading)

Michael Niedermayer | 2 Jul 22:43 2013
Picon
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Tue, Jul 02, 2013 at 09:33:04PM +0200, Matthieu Bouron wrote:
> On Tue, Jul 2, 2013 at 7:46 PM, Michael Niedermayer <michaelni <at> gmx.at>wrote:
> 
> > On Sun, Jun 30, 2013 at 04:15:46PM +0200, Matthieu Bouron wrote:
> > > Cover art muxing is done by introducing the -cover_stream_index option
> > > which takes an output stream index as argument.
> > > The stream used for the cover art is not muxed as a track in the
> > > resulting file.
> > > ---
> > >  libavformat/movenc.c     | 157
> > +++++++++++++++++++++++++++++++++++++++++++----
> > >  libavformat/movenc.h     |   5 ++
> > >  libavformat/movenchint.c |   1 +
> > >  3 files changed, 152 insertions(+), 11 deletions(-)
> > >
> > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > > index 5577530..f411493 100644
> > > --- a/libavformat/movenc.c
> > > +++ b/libavformat/movenc.c
> > >  <at>  <at>  -63,6 +63,7  <at>  <at>  static const AVOption options[] = {
> > >      { "ism_lookahead", "Number of lookahead entries for ISM files",
> > offsetof(MOVMuxContext, ism_lookahead), AV_OPT_TYPE_INT, {.i64 = 0}, 0,
> > INT_MAX, AV_OPT_FLAG_ENCODING_PARAM},
> > >      { "use_editlist", "use edit list", offsetof(MOVMuxContext,
> > use_editlist), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 1,
> > AV_OPT_FLAG_ENCODING_PARAM},
> > >      { "video_track_timescale", "set timescale of all video tracks",
> > offsetof(MOVMuxContext, video_track_timescale), AV_OPT_TYPE_INT, {.i64 =
> > 0}, 0, INT_MAX, AV_OPT_FLAG_ENCODING_PARAM},
> > > +    { "cover_stream_index", "video stream index to use for cover art",
(Continue reading)

Matthieu Bouron | 3 Jul 12:08 2013
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Tue, Jul 02, 2013 at 10:43:39PM +0200, Michael Niedermayer wrote:
> On Tue, Jul 02, 2013 at 09:33:04PM +0200, Matthieu Bouron wrote:
> > On Tue, Jul 2, 2013 at 7:46 PM, Michael Niedermayer <michaelni <at> gmx.at>wrote:
> > 
> > > On Sun, Jun 30, 2013 at 04:15:46PM +0200, Matthieu Bouron wrote:
> > > > Cover art muxing is done by introducing the -cover_stream_index option
> > > > which takes an output stream index as argument.
> > > > The stream used for the cover art is not muxed as a track in the
> > > > resulting file.
> > > > ---
> > > >  libavformat/movenc.c     | 157
> > > +++++++++++++++++++++++++++++++++++++++++++----
> > > >  libavformat/movenc.h     |   5 ++
> > > >  libavformat/movenchint.c |   1 +
> > > >  3 files changed, 152 insertions(+), 11 deletions(-)
> > > >
> > > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > > > index 5577530..f411493 100644
> > > > --- a/libavformat/movenc.c
> > > > +++ b/libavformat/movenc.c
> > > >  <at>  <at>  -63,6 +63,7  <at>  <at>  static const AVOption options[] = {
> > > >      { "ism_lookahead", "Number of lookahead entries for ISM files",
> > > offsetof(MOVMuxContext, ism_lookahead), AV_OPT_TYPE_INT, {.i64 = 0}, 0,
> > > INT_MAX, AV_OPT_FLAG_ENCODING_PARAM},
> > > >      { "use_editlist", "use edit list", offsetof(MOVMuxContext,
> > > use_editlist), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 1,
> > > AV_OPT_FLAG_ENCODING_PARAM},
> > > >      { "video_track_timescale", "set timescale of all video tracks",
> > > offsetof(MOVMuxContext, video_track_timescale), AV_OPT_TYPE_INT, {.i64 =
> > > 0}, 0, INT_MAX, AV_OPT_FLAG_ENCODING_PARAM},
(Continue reading)

Michael Niedermayer | 3 Jul 22:50 2013
Picon
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Wed, Jul 03, 2013 at 12:08:38PM +0200, Matthieu Bouron wrote:
> On Tue, Jul 02, 2013 at 10:43:39PM +0200, Michael Niedermayer wrote:
> > On Tue, Jul 02, 2013 at 09:33:04PM +0200, Matthieu Bouron wrote:
> > > On Tue, Jul 2, 2013 at 7:46 PM, Michael Niedermayer <michaelni <at> gmx.at>wrote:
> > > 
> > > > On Sun, Jun 30, 2013 at 04:15:46PM +0200, Matthieu Bouron wrote:
> > > > > Cover art muxing is done by introducing the -cover_stream_index option
> > > > > which takes an output stream index as argument.
> > > > > The stream used for the cover art is not muxed as a track in the
> > > > > resulting file.
> > > > > ---
> > > > >  libavformat/movenc.c     | 157
> > > > +++++++++++++++++++++++++++++++++++++++++++----
> > > > >  libavformat/movenc.h     |   5 ++
> > > > >  libavformat/movenchint.c |   1 +
> > > > >  3 files changed, 152 insertions(+), 11 deletions(-)
> > > > >
> > > > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > > > > index 5577530..f411493 100644
> > > > > --- a/libavformat/movenc.c
> > > > > +++ b/libavformat/movenc.c
> > > > >  <at>  <at>  -63,6 +63,7  <at>  <at>  static const AVOption options[] = {
> > > > >      { "ism_lookahead", "Number of lookahead entries for ISM files",
> > > > offsetof(MOVMuxContext, ism_lookahead), AV_OPT_TYPE_INT, {.i64 = 0}, 0,
> > > > INT_MAX, AV_OPT_FLAG_ENCODING_PARAM},
> > > > >      { "use_editlist", "use edit list", offsetof(MOVMuxContext,
> > > > use_editlist), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 1,
> > > > AV_OPT_FLAG_ENCODING_PARAM},
> > > > >      { "video_track_timescale", "set timescale of all video tracks",
> > > > offsetof(MOVMuxContext, video_track_timescale), AV_OPT_TYPE_INT, {.i64 =
(Continue reading)

Matthieu Bouron | 4 Jul 13:20 2013
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Wed, Jul 3, 2013 at 10:50 PM, Michael Niedermayer <michaelni <at> gmx.at>wrote:

> On Wed, Jul 03, 2013 at 12:08:38PM +0200, Matthieu Bouron wrote:
> > On Tue, Jul 02, 2013 at 10:43:39PM +0200, Michael Niedermayer wrote:
> > > On Tue, Jul 02, 2013 at 09:33:04PM +0200, Matthieu Bouron wrote:
> > > > On Tue, Jul 2, 2013 at 7:46 PM, Michael Niedermayer <
> michaelni <at> gmx.at>wrote:
> > > >
> > > > > On Sun, Jun 30, 2013 at 04:15:46PM +0200, Matthieu Bouron wrote:
> > > > > > Cover art muxing is done by introducing the -cover_stream_index
> option
> > > > > > which takes an output stream index as argument.
> > > > > > The stream used for the cover art is not muxed as a track in the
> > > > > > resulting file.
> > > > > > ---
> > > > > >  libavformat/movenc.c     | 157
> > > > > +++++++++++++++++++++++++++++++++++++++++++----
> > > > > >  libavformat/movenc.h     |   5 ++
> > > > > >  libavformat/movenchint.c |   1 +
> > > > > >  3 files changed, 152 insertions(+), 11 deletions(-)
> > > > > >
> > > > > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > > > > > index 5577530..f411493 100644
> > > > > > --- a/libavformat/movenc.c
> > > > > > +++ b/libavformat/movenc.c
> > > > > >  <at>  <at>  -63,6 +63,7  <at>  <at>  static const AVOption options[] = {
> > > > > >      { "ism_lookahead", "Number of lookahead entries for ISM
> files",
> > > > > offsetof(MOVMuxContext, ism_lookahead), AV_OPT_TYPE_INT, {.i64 =
> 0}, 0,
(Continue reading)

Matthieu Bouron | 5 Jul 14:18 2013
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Thu, Jul 04, 2013 at 01:20:56PM +0200, Matthieu Bouron wrote:
> On Wed, Jul 3, 2013 at 10:50 PM, Michael Niedermayer <michaelni <at> gmx.at>wrote:
> 
> > On Wed, Jul 03, 2013 at 12:08:38PM +0200, Matthieu Bouron wrote:
> > > On Tue, Jul 02, 2013 at 10:43:39PM +0200, Michael Niedermayer wrote:
> > > > On Tue, Jul 02, 2013 at 09:33:04PM +0200, Matthieu Bouron wrote:
> > > > > On Tue, Jul 2, 2013 at 7:46 PM, Michael Niedermayer <
> > michaelni <at> gmx.at>wrote:
> > > > >
> > > > > > On Sun, Jun 30, 2013 at 04:15:46PM +0200, Matthieu Bouron wrote:
> > > > > > > Cover art muxing is done by introducing the -cover_stream_index
> > option
> > > > > > > which takes an output stream index as argument.
> > > > > > > The stream used for the cover art is not muxed as a track in the
> > > > > > > resulting file.
> > > > > > > ---
> > > > > > >  libavformat/movenc.c     | 157
> > > > > > +++++++++++++++++++++++++++++++++++++++++++----
> > > > > > >  libavformat/movenc.h     |   5 ++
> > > > > > >  libavformat/movenchint.c |   1 +
> > > > > > >  3 files changed, 152 insertions(+), 11 deletions(-)
> > > > > > >
> > > > > > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > > > > > > index 5577530..f411493 100644
> > > > > > > --- a/libavformat/movenc.c
> > > > > > > +++ b/libavformat/movenc.c
> > > > > > >  <at>  <at>  -63,6 +63,7  <at>  <at>  static const AVOption options[] = {
> > > > > > >      { "ism_lookahead", "Number of lookahead entries for ISM
> > files",
> > > > > > offsetof(MOVMuxContext, ism_lookahead), AV_OPT_TYPE_INT, {.i64 =
(Continue reading)

Matthieu Bouron | 9 Jul 12:22 2013
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Fri, Jul 05, 2013 at 02:18:57PM +0200, Matthieu Bouron wrote:
> On Thu, Jul 04, 2013 at 01:20:56PM +0200, Matthieu Bouron wrote:
> > On Wed, Jul 3, 2013 at 10:50 PM, Michael Niedermayer <michaelni <at> gmx.at>wrote:
> > 
> > > On Wed, Jul 03, 2013 at 12:08:38PM +0200, Matthieu Bouron wrote:
> > > > On Tue, Jul 02, 2013 at 10:43:39PM +0200, Michael Niedermayer wrote:
> > > > > On Tue, Jul 02, 2013 at 09:33:04PM +0200, Matthieu Bouron wrote:
> > > > > > On Tue, Jul 2, 2013 at 7:46 PM, Michael Niedermayer <
> > > michaelni <at> gmx.at>wrote:
> > > > > >
> > > > > > > On Sun, Jun 30, 2013 at 04:15:46PM +0200, Matthieu Bouron wrote:
> > > > > > > > Cover art muxing is done by introducing the -cover_stream_index
> > > option
> > > > > > > > which takes an output stream index as argument.
> > > > > > > > The stream used for the cover art is not muxed as a track in the
> > > > > > > > resulting file.
> > > > > > > > ---
> > > > > > > >  libavformat/movenc.c     | 157
> > > > > > > +++++++++++++++++++++++++++++++++++++++++++----
> > > > > > > >  libavformat/movenc.h     |   5 ++
> > > > > > > >  libavformat/movenchint.c |   1 +
> > > > > > > >  3 files changed, 152 insertions(+), 11 deletions(-)
> > > > > > > >
> > > > > > > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > > > > > > > index 5577530..f411493 100644
> > > > > > > > --- a/libavformat/movenc.c
> > > > > > > > +++ b/libavformat/movenc.c
> > > > > > > >  <at>  <at>  -63,6 +63,7  <at>  <at>  static const AVOption options[] = {
> > > > > > > >      { "ism_lookahead", "Number of lookahead entries for ISM
> > > files",
(Continue reading)

Matthieu Bouron | 10 Jul 09:48 2013
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Tue, Jul 9, 2013 at 12:22 PM, Matthieu Bouron
<matthieu.bouron <at> gmail.com>wrote:

> On Fri, Jul 05, 2013 at 02:18:57PM +0200, Matthieu Bouron wrote:
> > On Thu, Jul 04, 2013 at 01:20:56PM +0200, Matthieu Bouron wrote:
> > New patch attached tested with chapters + subtitles + cover art +
> rtphint.
>
> Rebased patch attached.
>

Ping
Matthieu Bouron | 17 Jul 14:36 2013
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Wed, Jul 10, 2013 at 7:48 AM, Matthieu Bouron
<matthieu.bouron <at> gmail.com>wrote:

>
> On Tue, Jul 9, 2013 at 12:22 PM, Matthieu Bouron <
> matthieu.bouron <at> gmail.com> wrote:
>
>> On Fri, Jul 05, 2013 at 02:18:57PM +0200, Matthieu Bouron wrote:
>> > On Thu, Jul 04, 2013 at 01:20:56PM +0200, Matthieu Bouron wrote:
>> > New patch attached tested with chapters + subtitles + cover art +
>> rtphint.
>>
>> Rebased patch attached.
>>
>
> Ping
>
> Ping
Michael Niedermayer | 17 Jul 17:39 2013
Picon
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Tue, Jul 09, 2013 at 12:22:50PM +0200, Matthieu Bouron wrote:
> On Fri, Jul 05, 2013 at 02:18:57PM +0200, Matthieu Bouron wrote:
> > On Thu, Jul 04, 2013 at 01:20:56PM +0200, Matthieu Bouron wrote:
> > > On Wed, Jul 3, 2013 at 10:50 PM, Michael Niedermayer <michaelni <at> gmx.at>wrote:
> > > 
> > > > On Wed, Jul 03, 2013 at 12:08:38PM +0200, Matthieu Bouron wrote:
> > > > > On Tue, Jul 02, 2013 at 10:43:39PM +0200, Michael Niedermayer wrote:
> > > > > > On Tue, Jul 02, 2013 at 09:33:04PM +0200, Matthieu Bouron wrote:
> > > > > > > On Tue, Jul 2, 2013 at 7:46 PM, Michael Niedermayer <
> > > > michaelni <at> gmx.at>wrote:
> > > > > > >
> > > > > > > > On Sun, Jun 30, 2013 at 04:15:46PM +0200, Matthieu Bouron wrote:
> > > > > > > > > Cover art muxing is done by introducing the -cover_stream_index
> > > > option
> > > > > > > > > which takes an output stream index as argument.
> > > > > > > > > The stream used for the cover art is not muxed as a track in the
> > > > > > > > > resulting file.
> > > > > > > > > ---
> > > > > > > > >  libavformat/movenc.c     | 157
> > > > > > > > +++++++++++++++++++++++++++++++++++++++++++----
> > > > > > > > >  libavformat/movenc.h     |   5 ++
> > > > > > > > >  libavformat/movenchint.c |   1 +
> > > > > > > > >  3 files changed, 152 insertions(+), 11 deletions(-)
> > > > > > > > >
> > > > > > > > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > > > > > > > > index 5577530..f411493 100644
> > > > > > > > > --- a/libavformat/movenc.c
> > > > > > > > > +++ b/libavformat/movenc.c
> > > > > > > > >  <at>  <at>  -63,6 +63,7  <at>  <at>  static const AVOption options[] = {
> > > > > > > > >      { "ism_lookahead", "Number of lookahead entries for ISM
(Continue reading)

Matthieu Bouron | 17 Jul 18:21 2013
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Wed, Jul 17, 2013 at 05:39:18PM +0200, Michael Niedermayer wrote:
> On Tue, Jul 09, 2013 at 12:22:50PM +0200, Matthieu Bouron wrote:
> > On Fri, Jul 05, 2013 at 02:18:57PM +0200, Matthieu Bouron wrote:
> > > On Thu, Jul 04, 2013 at 01:20:56PM +0200, Matthieu Bouron wrote:
> > > > On Wed, Jul 3, 2013 at 10:50 PM, Michael Niedermayer <michaelni <at> gmx.at>wrote:
> > > > 
> > > > > On Wed, Jul 03, 2013 at 12:08:38PM +0200, Matthieu Bouron wrote:
> > > > > > On Tue, Jul 02, 2013 at 10:43:39PM +0200, Michael Niedermayer wrote:
> > > > > > > On Tue, Jul 02, 2013 at 09:33:04PM +0200, Matthieu Bouron wrote:
> > > > > > > > On Tue, Jul 2, 2013 at 7:46 PM, Michael Niedermayer <
> > > > > michaelni <at> gmx.at>wrote:
> > > > > > > >
> > > > > > > > > On Sun, Jun 30, 2013 at 04:15:46PM +0200, Matthieu Bouron wrote:
> > > > > > > > > > Cover art muxing is done by introducing the -cover_stream_index
> > > > > option
> > > > > > > > > > which takes an output stream index as argument.
> > > > > > > > > > The stream used for the cover art is not muxed as a track in the
> > > > > > > > > > resulting file.
> > > > > > > > > > ---
> > > > > > > > > >  libavformat/movenc.c     | 157
> > > > > > > > > +++++++++++++++++++++++++++++++++++++++++++----
> > > > > > > > > >  libavformat/movenc.h     |   5 ++
> > > > > > > > > >  libavformat/movenchint.c |   1 +
> > > > > > > > > >  3 files changed, 152 insertions(+), 11 deletions(-)
> > > > > > > > > >
> > > > > > > > > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > > > > > > > > > index 5577530..f411493 100644
> > > > > > > > > > --- a/libavformat/movenc.c
> > > > > > > > > > +++ b/libavformat/movenc.c
> > > > > > > > > >  <at>  <at>  -63,6 +63,7  <at>  <at>  static const AVOption options[] = {
(Continue reading)

Matthieu Bouron | 22 Jul 11:42 2013
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Wed, Jul 17, 2013 at 04:21:16PM +0000, Matthieu Bouron wrote:
> On Wed, Jul 17, 2013 at 05:39:18PM +0200, Michael Niedermayer wrote:
> > On Tue, Jul 09, 2013 at 12:22:50PM +0200, Matthieu Bouron wrote:
> > > On Fri, Jul 05, 2013 at 02:18:57PM +0200, Matthieu Bouron wrote:
> > > > On Thu, Jul 04, 2013 at 01:20:56PM +0200, Matthieu Bouron wrote:
> > > > > On Wed, Jul 3, 2013 at 10:50 PM, Michael Niedermayer <michaelni <at> gmx.at>wrote:
> > > > > 
> > > > > > On Wed, Jul 03, 2013 at 12:08:38PM +0200, Matthieu Bouron wrote:
> > > > > > > On Tue, Jul 02, 2013 at 10:43:39PM +0200, Michael Niedermayer wrote:
> > > > > > > > On Tue, Jul 02, 2013 at 09:33:04PM +0200, Matthieu Bouron wrote:
> > > > > > > > > On Tue, Jul 2, 2013 at 7:46 PM, Michael Niedermayer <
> > > > > > michaelni <at> gmx.at>wrote:
> > > > > > > > >
> > > > > > > > > > On Sun, Jun 30, 2013 at 04:15:46PM +0200, Matthieu Bouron wrote:
> > > > > > > > > > > Cover art muxing is done by introducing the -cover_stream_index
> > > > > > option
> > > > > > > > > > > which takes an output stream index as argument.
> > > > > > > > > > > The stream used for the cover art is not muxed as a track in the
> > > > > > > > > > > resulting file.
> > > > > > > > > > > ---
> > > > > > > > > > >  libavformat/movenc.c     | 157
> > > > > > > > > > +++++++++++++++++++++++++++++++++++++++++++----
> > > > > > > > > > >  libavformat/movenc.h     |   5 ++
> > > > > > > > > > >  libavformat/movenchint.c |   1 +
> > > > > > > > > > >  3 files changed, 152 insertions(+), 11 deletions(-)
> > > > > > > > > > >
> > > > > > > > > > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > > > > > > > > > > index 5577530..f411493 100644
> > > > > > > > > > > --- a/libavformat/movenc.c
> > > > > > > > > > > +++ b/libavformat/movenc.c
(Continue reading)

Matthieu Bouron | 27 Jul 19:27 2013
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Mon, Jul 22, 2013 at 09:42:43AM +0000, Matthieu Bouron wrote:
> On Wed, Jul 17, 2013 at 04:21:16PM +0000, Matthieu Bouron wrote:
> > On Wed, Jul 17, 2013 at 05:39:18PM +0200, Michael Niedermayer wrote:
> > > On Tue, Jul 09, 2013 at 12:22:50PM +0200, Matthieu Bouron wrote:
> > > > On Fri, Jul 05, 2013 at 02:18:57PM +0200, Matthieu Bouron wrote:
> > > > > On Thu, Jul 04, 2013 at 01:20:56PM +0200, Matthieu Bouron wrote:
> > > > > > On Wed, Jul 3, 2013 at 10:50 PM, Michael Niedermayer <michaelni <at> gmx.at>wrote:
> > > > > > 
> > > > > > > On Wed, Jul 03, 2013 at 12:08:38PM +0200, Matthieu Bouron wrote:
> > > > > > > > On Tue, Jul 02, 2013 at 10:43:39PM +0200, Michael Niedermayer wrote:
> > > > > > > > > On Tue, Jul 02, 2013 at 09:33:04PM +0200, Matthieu Bouron wrote:
> > > > > > > > > > On Tue, Jul 2, 2013 at 7:46 PM, Michael Niedermayer <
> > > > > > > michaelni <at> gmx.at>wrote:
> > > > > > > > > >
> > > > > > > > > > > On Sun, Jun 30, 2013 at 04:15:46PM +0200, Matthieu Bouron wrote:
> > > > > > > > > > > > Cover art muxing is done by introducing the -cover_stream_index
> > > > > > > option
> > > > > > > > > > > > which takes an output stream index as argument.
> > > > > > > > > > > > The stream used for the cover art is not muxed as a track in the
> > > > > > > > > > > > resulting file.
> > > > > > > > > > > > ---
> > > > > > > > > > > >  libavformat/movenc.c     | 157
> > > > > > > > > > > +++++++++++++++++++++++++++++++++++++++++++----
> > > > > > > > > > > >  libavformat/movenc.h     |   5 ++
> > > > > > > > > > > >  libavformat/movenchint.c |   1 +
> > > > > > > > > > > >  3 files changed, 152 insertions(+), 11 deletions(-)
> > > > > > > > > > > >
> > > > > > > > > > > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > > > > > > > > > > > index 5577530..f411493 100644
> > > > > > > > > > > > --- a/libavformat/movenc.c
(Continue reading)

Matthieu Bouron | 27 Jul 21:37 2013
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Sat, Jul 27, 2013 at 07:27:11PM +0200, Matthieu Bouron wrote:
> On Mon, Jul 22, 2013 at 09:42:43AM +0000, Matthieu Bouron wrote:
> > On Wed, Jul 17, 2013 at 04:21:16PM +0000, Matthieu Bouron wrote:
> > > On Wed, Jul 17, 2013 at 05:39:18PM +0200, Michael Niedermayer wrote:
> > > > On Tue, Jul 09, 2013 at 12:22:50PM +0200, Matthieu Bouron wrote:
> > > > > On Fri, Jul 05, 2013 at 02:18:57PM +0200, Matthieu Bouron wrote:
> > > > > > On Thu, Jul 04, 2013 at 01:20:56PM +0200, Matthieu Bouron wrote:
> > > > > > > On Wed, Jul 3, 2013 at 10:50 PM, Michael Niedermayer <michaelni <at> gmx.at>wrote:
> > > > > > > 
> > > > > > > > On Wed, Jul 03, 2013 at 12:08:38PM +0200, Matthieu Bouron wrote:
> > > > > > > > > On Tue, Jul 02, 2013 at 10:43:39PM +0200, Michael Niedermayer wrote:
> > > > > > > > > > On Tue, Jul 02, 2013 at 09:33:04PM +0200, Matthieu Bouron wrote:
> > > > > > > > > > > On Tue, Jul 2, 2013 at 7:46 PM, Michael Niedermayer <
> > > > > > > > michaelni <at> gmx.at>wrote:
> > > > > > > > > > >
> > > > > > > > > > > > On Sun, Jun 30, 2013 at 04:15:46PM +0200, Matthieu Bouron wrote:
> > > > > > > > > > > > > Cover art muxing is done by introducing the -cover_stream_index
> > > > > > > > option
> > > > > > > > > > > > > which takes an output stream index as argument.
> > > > > > > > > > > > > The stream used for the cover art is not muxed as a track in the
> > > > > > > > > > > > > resulting file.
> > > > > > > > > > > > > ---
> > > > > > > > > > > > >  libavformat/movenc.c     | 157
> > > > > > > > > > > > +++++++++++++++++++++++++++++++++++++++++++----
> > > > > > > > > > > > >  libavformat/movenc.h     |   5 ++
> > > > > > > > > > > > >  libavformat/movenchint.c |   1 +
> > > > > > > > > > > > >  3 files changed, 152 insertions(+), 11 deletions(-)
> > > > > > > > > > > > >
> > > > > > > > > > > > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c
> > > > > > > > > > > > > index 5577530..f411493 100644
(Continue reading)

Matthieu Bouron | 28 Jul 17:28 2013
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Sat, Jul 27, 2013 at 09:37:25PM +0200, Matthieu Bouron wrote:
> 
> BTW, updated patch attached (fixing an indentation mistake + return
> immediately after storing attached pic in mov_write_packet function).

Updated and rebased patch attached (take psp check into account + fix a
warning).

[...]
From 5180daf02567e91f47190e3ef33a5b792db68f62 Mon Sep 17 00:00:00 2001
From: Matthieu Bouron <matthieu.bouron <at> gmail.com>
Date: Thu, 27 Jun 2013 18:12:50 +0200
Subject: [PATCH] lavf/movenc: support iTunes cover art

Video streams with AV_DISPOSITON_ATTACHED_PIC will be used as cover arts
and won't be muxed as normal tracks in the resulting file.
---
 libavformat/movenc.c     | 200 +++++++++++++++++++++++++++++++++++++++++------
 libavformat/movenc.h     |  10 ++-
 libavformat/movenchint.c |  14 +++-
 3 files changed, 195 insertions(+), 29 deletions(-)

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 42ec3f2..08bdbc5 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
 <at>  <at>  -104,6 +104,15  <at>  <at>  static int is_co64_required(const MOVTrack *track)
     return 0;
(Continue reading)

Matthieu Bouron | 31 Jul 20:25 2013
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Sun, Jul 28, 2013 at 05:28:30PM +0200, Matthieu Bouron wrote:
> On Sat, Jul 27, 2013 at 09:37:25PM +0200, Matthieu Bouron wrote:
> > 
> > BTW, updated patch attached (fixing an indentation mistake + return
> > immediately after storing attached pic in mov_write_packet function).
> 
> Updated and rebased patch attached (take psp check into account + fix a
> warning).

Sorry to bring this up again, but i would like to know if this patch has
any chances to be accepted since the tradeoff of this feature is
"instrusive" code (required to discard apic streams from being referenced
as mov/mp4 tracks).

Reviews and comments welcomed :)

Matthieu

[...]
Paul B Mahol | 31 Jul 20:48 2013
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On 7/31/13, Matthieu Bouron <matthieu.bouron <at> gmail.com> wrote:
> On Sun, Jul 28, 2013 at 05:28:30PM +0200, Matthieu Bouron wrote:
>> On Sat, Jul 27, 2013 at 09:37:25PM +0200, Matthieu Bouron wrote:
>> >
>> > BTW, updated patch attached (fixing an indentation mistake + return
>> > immediately after storing attached pic in mov_write_packet function).
>>
>> Updated and rebased patch attached (take psp check into account + fix a
>> warning).
>
> Sorry to bring this up again, but i would like to know if this patch has
> any chances to be accepted since the tradeoff of this feature is
> "instrusive" code (required to discard apic streams from being referenced
> as mov/mp4 tracks).
>
> Reviews and comments welcomed :)

Well, apic streams just confuse users, but as you may already know final
design decisions are made by Michael.

>
> Matthieu
>
> [...]
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel <at> ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
(Continue reading)

Michael Niedermayer | 1 Aug 03:54 2013
Picon
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Wed, Jul 31, 2013 at 07:25:22PM +0100, Matthieu Bouron wrote:
> On Sun, Jul 28, 2013 at 05:28:30PM +0200, Matthieu Bouron wrote:
> > On Sat, Jul 27, 2013 at 09:37:25PM +0200, Matthieu Bouron wrote:
> > > 
> > > BTW, updated patch attached (fixing an indentation mistake + return
> > > immediately after storing attached pic in mov_write_packet function).
> > 
> > Updated and rebased patch attached (take psp check into account + fix a
> > warning).
> 
> Sorry to bring this up again, but i would like to know if this patch has
> any chances to be accepted since the tradeoff of this feature is
> "instrusive" code (required to discard apic streams from being referenced
> as mov/mp4 tracks).
> 
> Reviews and comments welcomed :)

If you take over maintaince of the mov muxer then you can just push
the change to your repository and ask me to merge it.

I already maintain quite abit of code and loosing the 1:1 relation
of streams in a moderately complex muxer has the potential of
increasing the maintaince burden for that code. Iam thus not entirely
happy about that ...

So basically iam happy to apply this but it must not increas the
maintaince burden on my side. the mov muxer either should get a
new maintainer or some other part of the codebase that i maintain
should get a new maintainer or some other responsibility i have should
be taken over by someone else. 
(Continue reading)

Matthieu Bouron | 2 Aug 22:51 2013
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Thu, Aug 01, 2013 at 03:54:45AM +0200, Michael Niedermayer wrote:
> On Wed, Jul 31, 2013 at 07:25:22PM +0100, Matthieu Bouron wrote:
> > On Sun, Jul 28, 2013 at 05:28:30PM +0200, Matthieu Bouron wrote:
> > > On Sat, Jul 27, 2013 at 09:37:25PM +0200, Matthieu Bouron wrote:
> > > > 
> > > > BTW, updated patch attached (fixing an indentation mistake + return
> > > > immediately after storing attached pic in mov_write_packet function).
> > > 
> > > Updated and rebased patch attached (take psp check into account + fix a
> > > warning).
> > 
> > Sorry to bring this up again, but i would like to know if this patch has
> > any chances to be accepted since the tradeoff of this feature is
> > "instrusive" code (required to discard apic streams from being referenced
> > as mov/mp4 tracks).
> > 
> > Reviews and comments welcomed :)
> 
> If you take over maintaince of the mov muxer then you can just push
> the change to your repository and ask me to merge it.
> 
> I already maintain quite abit of code and loosing the 1:1 relation
> of streams in a moderately complex muxer has the potential of
> increasing the maintaince burden for that code. Iam thus not entirely
> happy about that ...
> 
> So basically iam happy to apply this but it must not increas the
> maintaince burden on my side. the mov muxer either should get a
> new maintainer or some other part of the codebase that i maintain
> should get a new maintainer or some other responsibility i have should
(Continue reading)

Michael Niedermayer | 3 Aug 00:34 2013
Picon
Picon

Re: [PATCH 3/3] lavf/movenc: support iTunes cover art

On Fri, Aug 02, 2013 at 09:51:12PM +0100, Matthieu Bouron wrote:
> On Thu, Aug 01, 2013 at 03:54:45AM +0200, Michael Niedermayer wrote:
> > On Wed, Jul 31, 2013 at 07:25:22PM +0100, Matthieu Bouron wrote:
> > > On Sun, Jul 28, 2013 at 05:28:30PM +0200, Matthieu Bouron wrote:
> > > > On Sat, Jul 27, 2013 at 09:37:25PM +0200, Matthieu Bouron wrote:
> > > > > 
> > > > > BTW, updated patch attached (fixing an indentation mistake + return
> > > > > immediately after storing attached pic in mov_write_packet function).
> > > > 
> > > > Updated and rebased patch attached (take psp check into account + fix a
> > > > warning).
> > > 
> > > Sorry to bring this up again, but i would like to know if this patch has
> > > any chances to be accepted since the tradeoff of this feature is
> > > "instrusive" code (required to discard apic streams from being referenced
> > > as mov/mp4 tracks).
> > > 
> > > Reviews and comments welcomed :)
> > 
> > If you take over maintaince of the mov muxer then you can just push
> > the change to your repository and ask me to merge it.
> > 
> > I already maintain quite abit of code and loosing the 1:1 relation
> > of streams in a moderately complex muxer has the potential of
> > increasing the maintaince burden for that code. Iam thus not entirely
> > happy about that ...
> > 
> > So basically iam happy to apply this but it must not increas the
> > maintaince burden on my side. the mov muxer either should get a
> > new maintainer or some other part of the codebase that i maintain
(Continue reading)


Gmane