headers
Anuradha Suraparaju | 7 Jul 14:37

[PATCH] Add Dirac support to ffmpeg

**Dirac patch for ffmpeg
**Tested with ffmpeg cvs (as of July 7, 2007 10:00am) and 
  FFMpeg-20050707
**Author(s): Andrew Kennedy (dirac_dev <at> users.sourceforge.net) (main)
             Anuradha Suraparaju (asuraparaju <at> users.sourceforge.net) 
             (minor mods)

Dirac is an open-source video codec currently under development. Both
the encoder and decoder have been integrated with ffmpeg. This patch is
only a basic integration such that only the salient paremeters are
currently passed from ffmpeg to Dirac. As Dirac develops, especially
with the integration of  a formalised bit-stream syntax,  then more
complex screnarios can be dealt with. Encoded Dirac files, with the
right patch, can be played back using MPlayer.

Please feel free to modify/add-to the code. 

These are the instructions for enabling Dirac support in ffmpeg source
code.

1. Download Dirac from sourceforge and build and install Dirac
   cvs -d:pserver:anonymous <at> cvs.sourceforge.net:/cvsroot/dirac login 

    cvs -z3 -d:pserver:anonymous <at> cvs.sourceforge.net:/cvsroot/dirac co
-P compress

   cd compress
   ./bootstrap
   ./configure 
   make
(Continue reading)

Permalink | Reply |
headers
Diego Biurrun | 8 Jul 12:56

Re: [PATCH] Add Dirac support to ffmpeg

On Thu, Jul 07, 2005 at 01:38:23PM +0100, Anuradha Suraparaju wrote:
> --- ffmpeg-cvs/libavcodec/dirac.c	1970-01-01 01:00:00.000000000 +0100
> +++ ffmpeg-cvs-dirac/libavcodec/dirac.c	2005-07-07 12:07:51.400177835 +0100
> @@ -0,0 +1,510 @@
> +/**
> + * @file dirac.c
> + * Dirac codec support via dirac_encoder.
> + * @author Andrew Kennedy <dirac <at> rd.bbc.co.uk>
> + * www.sourceforge.net/projects/dirac
> + *
> + * This file is part of libavcodec.
> + *
> + * This library is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.

Since the dirac code is GPLed, you have to make it depend on the
--enable-gpl switch in configure.

Diego
Permalink | Reply |
headers
Anuradha Suraparaju | 8 Jul 13:29

Re: [PATCH] Add Dirac support to ffmpeg

Sorry. I should have checked the licence text before submitting the
patch. We didn't mean to release the code as GPL. Is it OK if I change
it to Lesser GPL and resubmit the patch? 

Thanks,
Anuradha Suraparaju 
On Fri, 2005-07-08 at 12:56 +0200, Diego Biurrun wrote:
> On Thu, Jul 07, 2005 at 01:38:23PM +0100, Anuradha Suraparaju wrote:
> > --- ffmpeg-cvs/libavcodec/dirac.c	1970-01-01 01:00:00.000000000 +0100
> > +++ ffmpeg-cvs-dirac/libavcodec/dirac.c	2005-07-07 12:07:51.400177835 +0100
> > @@ -0,0 +1,510 @@
> > +/**
> > + * @file dirac.c
> > + * Dirac codec support via dirac_encoder.
> > + * @author Andrew Kennedy <dirac <at> rd.bbc.co.uk>
> > + * www.sourceforge.net/projects/dirac
> > + *
> > + * This file is part of libavcodec.
> > + *
> > + * This library is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> 
> Since the dirac code is GPLed, you have to make it depend on the
> --enable-gpl switch in configure.
> 
> Diego
> 
> _______________________________________________
(Continue reading)

Permalink | Reply |
headers
Diego Biurrun | 9 Jul 00:35

Re: [PATCH] Add Dirac support to ffmpeg

On Fri, Jul 08, 2005 at 12:29:52PM +0100, Anuradha Suraparaju wrote:
> Sorry. I should have checked the licence text before submitting the
> patch. We didn't mean to release the code as GPL. Is it OK if I change
> it to Lesser GPL and resubmit the patch? 

You have two possibilities:

1) Resubmit as LGPL.
2) Resubmit under --enable-gpl.

Both are acceptable AFAIK.

Diego

P.S.: Please don't top-post.
Permalink | Reply |
headers
| 9 Jul 00:50
Favicon

Re: [PATCH] Add Dirac support to ffmpeg

> On Fri, Jul 08, 2005 at 12:29:52PM +0100, Anuradha Suraparaju wrote:
> > Sorry. I should have checked the licence text before submitting the
> > patch. We didn't mean to release the code as GPL. Is it OK if I 
> > change
> > it to Lesser GPL and resubmit the patch? 
> 
> You have two possibilities:
> 
> 1) Resubmit as LGPL.

That is only possible if you are the only author of the patch (or all 
authors agree).

> 2) Resubmit under --enable-gpl.
> 
> Both are acceptable AFAIK.

1) is preferable though, ffmpeg licence is officially LGPL.

François.
Permalink | Reply |
headers
matthieu castet | 9 Jul 09:50
Favicon

Re: [PATCH] Add Dirac support to ffmpeg

Hi,

François Revol wrote:
>>On Fri, Jul 08, 2005 at 12:29:52PM +0100, Anuradha Suraparaju wrote:
>>
>>>Sorry. I should have checked the licence text before submitting the
>>>patch. We didn't mean to release the code as GPL. Is it OK if I 
>>>change
>>>it to Lesser GPL and resubmit the patch? 
>>
>>You have two possibilities:
>>
>>1) Resubmit as LGPL.
> 
> 
> That is only possible if you are the only author of the patch (or all 
> authors agree).
> 
and if dirac library is compatible with LGPL
Permalink | Reply |
headers
Anuradha Suraparaju | 11 Jul 11:26

Re: [PATCH] Add Dirac support to ffmpeg

On Sat, 2005-07-09 at 09:50 +0200, matthieu castet wrote:
> Hi,
> 
> François Revol wrote:
> >>On Fri, Jul 08, 2005 at 12:29:52PM +0100, Anuradha Suraparaju wrote:
> >>
> >>>Sorry. I should have checked the licence text before submitting the
> >>>patch. We didn't mean to release the code as GPL. Is it OK if I 
> >>>change
> >>>it to Lesser GPL and resubmit the patch? 
> >>
> >>You have two possibilities:
> >>
> >>1) Resubmit as LGPL.
> > 
> > 
> > That is only possible if you are the only author of the patch (or all 
> > authors agree).
> > 
> and if dirac library is compatible with LGPL
Dirac library is released under the Mozilla Triple License and allows
for relicensing under the GPL or LGPL.
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel <at> mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/ffmpeg-devel
--

--
Permalink | Reply |
headers
Anuradha Suraparaju | 11 Jul 11:28

Re: [PATCH] Add Dirac support to ffmpeg

On Sat, 2005-07-09 at 00:50 +0200, François Revol wrote:
> > On Fri, Jul 08, 2005 at 12:29:52PM +0100, Anuradha Suraparaju wrote:
> > > Sorry. I should have checked the licence text before submitting the
> > > patch. We didn't mean to release the code as GPL. Is it OK if I 
> > > change
> > > it to Lesser GPL and resubmit the patch? 
> > 
> > You have two possibilities:
> > 
> > 1) Resubmit as LGPL.
> 
> That is only possible if you are the only author of the patch (or all 
> authors agree).
> 
> > 2) Resubmit under --enable-gpl.
> > 
> > Both are acceptable AFAIK.
> 
> 1) is preferable though, ffmpeg licence is officially LGPL.
> 
> François.
Will resubmit the patch once all authors agree to changes to the
licence.
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel <at> mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/ffmpeg-devel
--

--
(Continue reading)

Permalink | Reply |
headers
Michael Niedermayer | 10 Jul 00:46

Re: [PATCH] Add Dirac support to ffmpeg

Hi

On Thursday 07 July 2005 14:38, Anuradha Suraparaju wrote:
> **Dirac patch for ffmpeg
> **Tested with ffmpeg cvs (as of July 7, 2007 10:00am) and
>   FFMpeg-20050707
> **Author(s): Andrew Kennedy (dirac_dev <at> users.sourceforge.net) (main)
>              Anuradha Suraparaju (asuraparaju <at> users.sourceforge.net)
>              (minor mods)
>
> Dirac is an open-source video codec currently under development. Both
> the encoder and decoder have been integrated with ffmpeg. This patch is
> only a basic integration such that only the salient paremeters are
> currently passed from ffmpeg to Dirac. As Dirac develops, especially
> with the integration of  a formalised bit-stream syntax,  then more
> complex screnarios can be dealt with. Encoded Dirac files, with the
> right patch, can be played back using MPlayer.
[...]

> +dirac_encoder_presets_t GetDiracPreset(AVCodecContext *avccontext)

shouldnt that and a few other functions be static to avoid namespace 
pollution, or are they used outside dirac.c?

> +       default:
> +               av_log (avccontext, AV_LOG_ERROR, "this codec supports only 
YUV420P\n");
> +               return format420;
> +       
> +       }
(Continue reading)

Permalink | Reply |
headers
Anuradha Suraparaju | 11 Jul 11:30

Re: [PATCH] Add Dirac support to ffmpeg

Michael,
Thanks for the prompt reply. We will resubmit the patch after applying
your comments.

Regards,
Anuradha Suraparaju
On Sun, 2005-07-10 at 00:46 +0200, Michael Niedermayer wrote:
> Hi
> 
> On Thursday 07 July 2005 14:38, Anuradha Suraparaju wrote:
> > **Dirac patch for ffmpeg
> > **Tested with ffmpeg cvs (as of July 7, 2007 10:00am) and
> >   FFMpeg-20050707
> > **Author(s): Andrew Kennedy (dirac_dev <at> users.sourceforge.net) (main)
> >              Anuradha Suraparaju (asuraparaju <at> users.sourceforge.net)
> >              (minor mods)
> >
> > Dirac is an open-source video codec currently under development. Both
> > the encoder and decoder have been integrated with ffmpeg. This patch is
> > only a basic integration such that only the salient paremeters are
> > currently passed from ffmpeg to Dirac. As Dirac develops, especially
> > with the integration of  a formalised bit-stream syntax,  then more
> > complex screnarios can be dealt with. Encoded Dirac files, with the
> > right patch, can be played back using MPlayer.
> [...]
> 
> > +dirac_encoder_presets_t GetDiracPreset(AVCodecContext *avccontext)
> 
> shouldnt that and a few other functions be static to avoid namespace 
> pollution, or are they used outside dirac.c?
(Continue reading)

Permalink | Reply |

Gmane