Michał Sawicz | 19 Dec 2010 02:44
Gravatar

[PATCH 0/3] Some minor fixes

Hi everyone, as a hello to the community and to the list I have some minor
fixes I found when scanning through the code. See patches down the thread
and expect some more bombing tonight.

Cheers
--
Michał (Saviq) Sawicz <michal <at> sawicz.net>

------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
gnome-subtitles-general mailing list
gnome-subtitles-general <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/gnome-subtitles-general
Michał Sawicz | 19 Dec 2010 02:44
Gravatar

[PATCH 2/3] Set BackupTimeSpinButton's value

---
 src/GnomeSubtitles/Dialog/PreferencesDialog.cs |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/GnomeSubtitles/Dialog/PreferencesDialog.cs b/src/GnomeSubtitles/Dialog/PreferencesDialog.cs
index 20152a0..4072722 100644
--- a/src/GnomeSubtitles/Dialog/PreferencesDialog.cs
+++ b/src/GnomeSubtitles/Dialog/PreferencesDialog.cs
 <at>  <at>  -159,7 +159,9  <at>  <at>  public class PreferencesDialog : GladeDialog {
 	private void SetAutoBackup () {
 		bool autoBackupEnabled = Base.Config.PrefsBackupAutoBackup;
 		autoBackupCheckButton.Active = autoBackupEnabled;
+
 		autoBackupTimeSpinButton.Sensitive = autoBackupEnabled;
+		autoBackupTimeSpinButton.Value = (int)Base.Config.PrefsBackupBackupTime / 60;
 	}

 	private void ResetDialogToDefaults () {
--

-- 
1.7.3.1

------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
Pedro Castro | 1 Jan 2011 19:23
Gravatar

Re: [PATCH 2/3] Set BackupTimeSpinButton's value

Hi Michal, patch commited.


Happy new year,
Cheers,

--
Pedro Castro
http://www.pedrocastro.org


On Sun, Dec 19, 2010 at 1:44 AM, Michał Sawicz <michal-4QgiNd05UfasTnJN9+BGXg@public.gmane.org> wrote:
---
 src/GnomeSubtitles/Dialog/PreferencesDialog.cs |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/GnomeSubtitles/Dialog/PreferencesDialog.cs b/src/GnomeSubtitles/Dialog/PreferencesDialog.cs
index 20152a0..4072722 100644
--- a/src/GnomeSubtitles/Dialog/PreferencesDialog.cs
+++ b/src/GnomeSubtitles/Dialog/PreferencesDialog.cs
<at> <at> -159,7 +159,9 <at> <at> public class PreferencesDialog : GladeDialog {
       private void SetAutoBackup () {
               bool autoBackupEnabled = Base.Config.PrefsBackupAutoBackup;
               autoBackupCheckButton.Active = autoBackupEnabled;
+
               autoBackupTimeSpinButton.Sensitive = autoBackupEnabled;
+               autoBackupTimeSpinButton.Value = (int)Base.Config.PrefsBackupBackupTime / 60;
       }

       private void ResetDialogToDefaults () {
--
1.7.3.1


------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
gnome-subtitles-general mailing list
gnome-subtitles-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/gnome-subtitles-general

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
gnome-subtitles-general mailing list
gnome-subtitles-general@...
https://lists.sourceforge.net/lists/listinfo/gnome-subtitles-general
Michał Sawicz | 19 Dec 2010 02:44
Gravatar

[PATCH 1/3] Fix typo in method name

---
 src/Glade/PreferencesDialog.glade              |    2 +-
 src/GnomeSubtitles/Dialog/PreferencesDialog.cs |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Glade/PreferencesDialog.glade b/src/Glade/PreferencesDialog.glade
index fa005fc..2a9ce44 100644
--- a/src/Glade/PreferencesDialog.glade
+++ b/src/Glade/PreferencesDialog.glade
 <at>  <at>  -309,7 +309,7  <at>  <at> 
                             <property name="width_chars">2</property>
                             <property name="adjustment">1 1 100 1 2 0</property>
                             <property name="numeric">True</property>
-                            <signal name="value_changed" handler="OnAutoBackupTimeSpinButonValueChanged"/>
+                            <signal name="value_changed" handler="OnAutoBackupTimeSpinButtonValueChanged"/>
                           </widget>
                           <packing>
                             <property name="expand">False</property>
diff --git a/src/GnomeSubtitles/Dialog/PreferencesDialog.cs b/src/GnomeSubtitles/Dialog/PreferencesDialog.cs
index 7eaf421..20152a0 100644
--- a/src/GnomeSubtitles/Dialog/PreferencesDialog.cs
+++ b/src/GnomeSubtitles/Dialog/PreferencesDialog.cs
 <at>  <at>  -297,7 +297,7  <at>  <at>  public class PreferencesDialog : GladeDialog {
 		Base.Backup.ReCheck();
 	}
 	
-	private void OnAutoBackupTimeSpinButonValueChanged (object o, EventArgs args) {
+	private void OnAutoBackupTimeSpinButtonValueChanged (object o, EventArgs args) {
 		Base.Config.PrefsBackupBackupTime = (o as SpinButton).ValueAsInt * 60; //seconds
 		Base.Backup.ReCheck();
 	}
--

-- 
1.7.3.1

------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
Pedro Castro | 1 Jan 2011 19:29
Gravatar

Re: [PATCH 1/3] Fix typo in method name

Also committed.


Cheers,
--
Pedro Castro
http://www.pedrocastro.org


On Sun, Dec 19, 2010 at 1:44 AM, Michał Sawicz <michal-4QgiNd05UfasTnJN9+BGXg@public.gmane.org> wrote:
---
 src/Glade/PreferencesDialog.glade              |    2 +-
 src/GnomeSubtitles/Dialog/PreferencesDialog.cs |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Glade/PreferencesDialog.glade b/src/Glade/PreferencesDialog.glade
index fa005fc..2a9ce44 100644
--- a/src/Glade/PreferencesDialog.glade
+++ b/src/Glade/PreferencesDialog.glade
<at> <at> -309,7 +309,7 <at> <at>
                            <property name="width_chars">2</property>
                            <property name="adjustment">1 1 100 1 2 0</property>
                            <property name="numeric">True</property>
-                            <signal name="value_changed" handler="OnAutoBackupTimeSpinButonValueChanged"/>
+                            <signal name="value_changed" handler="OnAutoBackupTimeSpinButtonValueChanged"/>
                          </widget>
                          <packing>
                            <property name="expand">False</property>
diff --git a/src/GnomeSubtitles/Dialog/PreferencesDialog.cs b/src/GnomeSubtitles/Dialog/PreferencesDialog.cs
index 7eaf421..20152a0 100644
--- a/src/GnomeSubtitles/Dialog/PreferencesDialog.cs
+++ b/src/GnomeSubtitles/Dialog/PreferencesDialog.cs
<at> <at> -297,7 +297,7 <at> <at> public class PreferencesDialog : GladeDialog {
               Base.Backup.ReCheck();
       }

-       private void OnAutoBackupTimeSpinButonValueChanged (object o, EventArgs args) {
+       private void OnAutoBackupTimeSpinButtonValueChanged (object o, EventArgs args) {
               Base.Config.PrefsBackupBackupTime = (o as SpinButton).ValueAsInt * 60; //seconds
               Base.Backup.ReCheck();
       }
--
1.7.3.1


------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
gnome-subtitles-general mailing list
gnome-subtitles-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/gnome-subtitles-general

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
gnome-subtitles-general mailing list
gnome-subtitles-general@...
https://lists.sourceforge.net/lists/listinfo/gnome-subtitles-general
Michał Sawicz | 19 Dec 2010 02:44
Gravatar

[PATCH 3/3] Add missing WidgetName and its sensitivity

---
 src/GnomeSubtitles/Ui/Menus.cs       |    1 +
 src/GnomeSubtitles/Ui/WidgetNames.cs |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/GnomeSubtitles/Ui/Menus.cs b/src/GnomeSubtitles/Ui/Menus.cs
index ddbb4e9..5da7fb5 100644
--- a/src/GnomeSubtitles/Ui/Menus.cs
+++ b/src/GnomeSubtitles/Ui/Menus.cs
 <at>  <at>  -128,6 +128,7  <at>  <at>  public class Menus {
 		SetStylesSensitivity(sensitivity);
 		SetSensitivity(WidgetNames.EditDeleteSubtitles, sensitivity);
 		SetSensitivity(WidgetNames.EditInsertSubtitleBefore, sensitivity);
+		SetSensitivity(WidgetNames.EditInsertSubtitleAfter, sensitivity);
 		SetSensitivity(WidgetNames.DeleteSubtitlesButton, sensitivity);
 	}
 	
diff --git a/src/GnomeSubtitles/Ui/WidgetNames.cs b/src/GnomeSubtitles/Ui/WidgetNames.cs
index 8647b06..720edc3 100644
--- a/src/GnomeSubtitles/Ui/WidgetNames.cs
+++ b/src/GnomeSubtitles/Ui/WidgetNames.cs
 <at>  <at>  -50,6 +50,7  <at>  <at>  public class WidgetNames {
 	public const string EditFormatUnderline = "editFormatUnderline";
 	public const string EditInsertSubtitleMenu = "editInsertSubtitleMenu";
 	public const string EditInsertSubtitleBefore = "editInsertSubtitleBefore";
+	public const string EditInsertSubtitleAfter = "editInsertSubtitleAfter";
 	public const string EditDeleteSubtitles = "editDeleteSubtitles";
 	
 	/* View Menu */
--

-- 
1.7.3.1

------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
Pedro Castro | 29 Dec 2010 03:57
Gravatar

Re: [PATCH 3/3] Add missing WidgetName and its sensitivity

Michał,


You've spotted an interesting crash bug. I've opened a bug in our bugzilla and added my comments there:

Do you want to give it a try?

Regards,

--
Pedro Castro
http://www.pedrocastro.org


On Sun, Dec 19, 2010 at 1:44 AM, Michał Sawicz <michal-4QgiNd05UfasTnJN9+BGXg@public.gmane.org> wrote:
---
 src/GnomeSubtitles/Ui/Menus.cs       |    1 +
 src/GnomeSubtitles/Ui/WidgetNames.cs |    1 +
 2 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/GnomeSubtitles/Ui/Menus.cs b/src/GnomeSubtitles/Ui/Menus.cs
index ddbb4e9..5da7fb5 100644
--- a/src/GnomeSubtitles/Ui/Menus.cs
+++ b/src/GnomeSubtitles/Ui/Menus.cs
<at> <at> -128,6 +128,7 <at> <at> public class Menus {
               SetStylesSensitivity(sensitivity);
               SetSensitivity(WidgetNames.EditDeleteSubtitles, sensitivity);
               SetSensitivity(WidgetNames.EditInsertSubtitleBefore, sensitivity);
+               SetSensitivity(WidgetNames.EditInsertSubtitleAfter, sensitivity);
               SetSensitivity(WidgetNames.DeleteSubtitlesButton, sensitivity);
       }

diff --git a/src/GnomeSubtitles/Ui/WidgetNames.cs b/src/GnomeSubtitles/Ui/WidgetNames.cs
index 8647b06..720edc3 100644
--- a/src/GnomeSubtitles/Ui/WidgetNames.cs
+++ b/src/GnomeSubtitles/Ui/WidgetNames.cs
<at> <at> -50,6 +50,7 <at> <at> public class WidgetNames {
       public const string EditFormatUnderline = "editFormatUnderline";
       public const string EditInsertSubtitleMenu = "editInsertSubtitleMenu";
       public const string EditInsertSubtitleBefore = "editInsertSubtitleBefore";
+       public const string EditInsertSubtitleAfter = "editInsertSubtitleAfter";
       public const string EditDeleteSubtitles = "editDeleteSubtitles";

       /* View Menu */
--
1.7.3.1


------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
gnome-subtitles-general mailing list
gnome-subtitles-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/gnome-subtitles-general

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
gnome-subtitles-general mailing list
gnome-subtitles-general@...
https://lists.sourceforge.net/lists/listinfo/gnome-subtitles-general
Michał Sawicz | 29 Dec 2010 12:00
Gravatar

Re: [PATCH 3/3] Add missing WidgetName and its sensitivity

Dnia 2010-12-29, śro o godzinie 02:57 +0000, Pedro Castro pisze:
> Do you want to give it a try? 

Sure, that works. In that case, to maintain consistency, we should also
allow prepending subtitles when there's no selection. The attached patch
implements that.

Cheers
--

-- 
Michał (Saviq) Sawicz <michal@...>
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
gnome-subtitles-general mailing list
gnome-subtitles-general@...
https://lists.sourceforge.net/lists/listinfo/gnome-subtitles-general
Pedro Castro | 30 Dec 2010 04:31
Gravatar

Re: [PATCH 3/3] Add missing WidgetName and its sensitivity

You're right. Patch applied with small changes (you actually made me find another bug in old code). Be sure to check the latest commit.


Regards,

--
Pedro Castro
http://www.pedrocastro.org


On Wed, Dec 29, 2010 at 11:00 AM, Michał Sawicz <michal-4QgiNd05UfasTnJN9+BGXg@public.gmane.org> wrote:
Dnia 2010-12-29, śro o godzinie 02:57 +0000, Pedro Castro pisze:
> Do you want to give it a try?

Sure, that works. In that case, to maintain consistency, we should also
allow prepending subtitles when there's no selection. The attached patch
implements that.

Cheers
--
Michał (Saviq) Sawicz <michal <at> sawicz.net>

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
gnome-subtitles-general mailing list
gnome-subtitles-general@...
https://lists.sourceforge.net/lists/listinfo/gnome-subtitles-general
Michał Sawicz | 30 Dec 2010 08:47
Gravatar

Re: [PATCH 3/3] Add missing WidgetName and its sensitivity

Dnia 2010-12-30, czw o godzinie 03:31 +0000, Pedro Castro pisze:
> (you actually made me find another bug in old code).

Ah yes, I initially tried to use InsertFirstSubtitle..., but the first
ones got mixed up somehow and I thought that only works for first as in
the only one.

Glad you got that.

Cheers
--

-- 
Michał (Saviq) Sawicz <michal@...>
------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and, 
should the need arise, upgrade to a full multi-node Oracle RAC database 
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
gnome-subtitles-general mailing list
gnome-subtitles-general@...
https://lists.sourceforge.net/lists/listinfo/gnome-subtitles-general
Pedro Castro | 20 Dec 2010 00:23
Gravatar

Re: [PATCH 0/3] Some minor fixes

Hi Michał,


Welcome to the project. That appears to have been a pretty productive night. ;-) 

I shall be taking a look at those patches during this week, thanks for your contribution!

Cheers,
--
Pedro Castro
http://www.pedrocastro.org


On Sun, Dec 19, 2010 at 1:44 AM, Michał Sawicz <michal-4QgiNd05UfasTnJN9+BGXg@public.gmane.org> wrote:
Hi everyone, as a hello to the community and to the list I have some minor
fixes I found when scanning through the code. See patches down the thread
and expect some more bombing tonight.

Cheers
--
Michał (Saviq) Sawicz <michal <at> sawicz.net>


------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
gnome-subtitles-general mailing list
gnome-subtitles-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/gnome-subtitles-general

------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
gnome-subtitles-general mailing list
gnome-subtitles-general@...
https://lists.sourceforge.net/lists/listinfo/gnome-subtitles-general

Gmane