Ichthyostega | 1 Mar 2011 07:51
Picon

Re: Announcement: New Lumiera website is online

Francesco Siddi schrieb:
>> the "+" signs are in a <SPAN> which got float:right, but for some reason it
>>  wraps into the next line.....

> I "fixed" that in the staging website like this:

> #menu ul>li>a { }

Hello Francesco,

cool, that fix is a huge improvement. I picked that immediately to master.

>> Ichthyo:... better solution: also do the hiding/unfolding just by adding a 
>> class, in the same way as we do the highlighting of the current element. 
>> Because then it could be directed always to the menu entry as active
>> element (and the children are contained in that element anyway). Using this
>> approach, the actual display:hidden would be given through the CSS with a
>> so called "contextual selector", i.e. only applying to the child elements 
>> directly within the styled menu entry.

> That would be good (and also reusable in my second proposal for a vertical
> menu in lumiera documents)

I've implemented now these changes on the staging website. The menu folding
works now entirely based on classes and CSS, the JavaScript just adds and
removes a class on the <li> entry to be collapsed.

Moreover, I went through the stylesheet and tried to remove some redundancy
and make the usage of colours / borders a bit more consistent. IMHO it's now
less confusing and more obvious where the current selection is.
(Continue reading)


Gmane