Re: [patch] Radeon and R200 vtxfmt fixes

Felix Kühling wrote:
> Hi,
> 
> I believe I got it right this time. :) I attached three small patches
> that re-enabled the vtxfmt paths in the radeon and r200 drivers. One is
> for _tnl_Begin to call the driver's NotifyBegin callback again.
> Alternatively, if the drivers are supposed to work correctly without
> this callback, then the NotifyBegin callback should be removed from the
> respective struct and the drivers changed accordingly.
> 
> The other two patches install fallbacks for the VertexAttrib*NV
> functions in the radeon and r200 drivers and _tnl_DrawArrays instead of
> radeon/r200_fallback_DrawArrays. Also the drivers must not install their
> own ctx->Driver.NewList callback. This would override _tnl_NewList
> leading to the assertion failure in _save_NotifyBegin I reported
> earlier. I tested both, calling _tnl_NewList in radeon_NewList and not
> installing radeon_NewList at all. Both worked the same with the
> applications I tested (see below) so a fallback does not appear to be
> necessary with Keith's new display list compiler.
> 
> I tested these patches on a Radeon 7500 with flightgear, torcs, tuxracer
> (and glxgears  without noticing any problems. I can't test on R200
> (yet). My CPU doesn't have a SSE unit, so the SSE codegen stuff may still
> be broken, though I believe this is unlikely.

> If these patches are ok I'd like to commit them. Keith, I think you
> should know best. 

I've got a couple of comments, but basically things look ok.