Vinson Lee | 7 Aug 2012 09:21

[PATCH] translate: Fix typo in is_legal_int_format_combo.

Fixes same on both sides defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee <at> freedesktop.org>
---
 src/gallium/auxiliary/translate/translate_generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/auxiliary/translate/translate_generic.c b/src/gallium/auxiliary/translate/translate_generic.c
index 0b6ebf5..72099af 100644
--- a/src/gallium/auxiliary/translate/translate_generic.c
+++ b/src/gallium/auxiliary/translate/translate_generic.c
 <at>  <at>  -773,7 +773,7  <at>  <at>  is_legal_int_format_combo( const struct util_format_description *src,

    for (i = 0; i < nr; i++) {
       /* The signs must match. */
-      if (src->channel[i].type != src->channel[i].type) {
+      if (src->channel[i].type != dst->channel[i].type) {
          return FALSE;
       }

--

-- 
1.7.11.1
Jose Fonseca | 7 Aug 2012 13:14
Favicon

Re: [PATCH] translate: Fix typo in is_legal_int_format_combo.

Good catch.

Reviewed-by: Jose Fonseca <jfonseca <at> vmware.com>

----- Original Message -----
> Fixes same on both sides defect reported by Coverity.
> 
> Signed-off-by: Vinson Lee <vlee <at> freedesktop.org>
> ---
>  src/gallium/auxiliary/translate/translate_generic.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/auxiliary/translate/translate_generic.c
> b/src/gallium/auxiliary/translate/translate_generic.c
> index 0b6ebf5..72099af 100644
> --- a/src/gallium/auxiliary/translate/translate_generic.c
> +++ b/src/gallium/auxiliary/translate/translate_generic.c
>  <at>  <at>  -773,7 +773,7  <at>  <at>  is_legal_int_format_combo( const struct
> util_format_description *src,
>  
>     for (i = 0; i < nr; i++) {
>        /* The signs must match. */
> -      if (src->channel[i].type != src->channel[i].type) {
> +      if (src->channel[i].type != dst->channel[i].type) {
>           return FALSE;
>        }
>  
> --
> 1.7.11.1
> 
(Continue reading)


Gmane