Vinson Lee | 8 Aug 2012 09:15

[PATCH] st/mesa: Initialize tgsi_texture_offset Padding field.

Fixes uninitialized scalar variable defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee <at> freedesktop.org>
---
 src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
index 43c80be..39717b6 100644
--- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
+++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
 <at>  <at>  -4178,6 +4178,7  <at>  <at>  translate_tex_offset(struct st_translate *t,
    offset.SwizzleX = in_offset->SwizzleX;
    offset.SwizzleY = in_offset->SwizzleY;
    offset.SwizzleZ = in_offset->SwizzleZ;
+   offset.Padding = 0;

    return offset;
 }
--

-- 
1.7.11.1
Jose Fonseca | 8 Aug 2012 15:29
Favicon

Re: [PATCH] st/mesa: Initialize tgsi_texture_offset Padding field.

Looks good.

Jose

----- Original Message -----
> Fixes uninitialized scalar variable defect reported by Coverity.
> 
> Signed-off-by: Vinson Lee <vlee <at> freedesktop.org>
> ---
>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> index 43c80be..39717b6 100644
> --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> +++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
>  <at>  <at>  -4178,6 +4178,7  <at>  <at>  translate_tex_offset(struct st_translate *t,
>     offset.SwizzleX = in_offset->SwizzleX;
>     offset.SwizzleY = in_offset->SwizzleY;
>     offset.SwizzleZ = in_offset->SwizzleZ;
> +   offset.Padding = 0;
>  
>     return offset;
>  }
> --
> 1.7.11.1
> 
> _______________________________________________
> mesa-dev mailing list
(Continue reading)


Gmane