Re: [PATCH] vo_kva
Reimar Döffinger <Reimar.Doeffinger <at> gmx.de>
2009-03-14 14:34:59 GMT
On Sun, Mar 08, 2009 at 11:12:13PM +0900, KO Myung-Hun wrote:
> > Anyway it is your decision, I just wanted to point out that the vos that
> > I maintain will specifically try to avoid that behaviour and your vo is
> > probably going to stand out from the others by behaving differently,
> > though that is not necessarily a bad thing.
> But what you missed is that the frame window procedure is subclassed
> only if fixt23 is enabled.
Ok, but then a different name or at least a comment indicating it only
applies to T23 workarounds would be good so you know what it is there
for without having to have preinit in your head.
> > A disabled window is a window that can not receive any input, on Windows you
> > use EnableWindow(vo_window, 0); to set that state. This is usually what
> > is used to disable buttons (in addition to graying them out) so I'd
> > expect that to exist on OS/2, too - but I don't know.
> I think, it's WinEnableWindow(). But with quick test, a disabled window
> does not pass any event to other window. Anyway if I find the solution
> using this approach, I'll submit another patch later.
Just to clarify: on Windows a disabled window simply will not get input
focus, its parent window will instead, so there is no need to pass the
events on, they will be directed to the parent window directly.
> > Whether the click that moves focus/brings a window on top counts as
> > click into the window as well is a matter of OS policy, too (as evident
> > by Linux window-managers allowing to choose this).
> > So I think my point stands, but as said if it is important to you keep