Re: Moving WebKit's Linux font rendering settings lookup code to Chrome?

On Fri, Jun 15, 2012 at 1:26 PM, Daniel Erat <derat <at> chromium.org> wrote:
> I'd like to move WebKit's code for looking up per-run-of-text Linux
> font rendering settings, currently in
> WebFontInfo::renderStyleForStrike(), to a spot where it can also be
> used to look up rendering settings while drawing the Ash UI
> (http://crbug.com/125235).  Chrome's
> ui/gfx/font_render_params_linux.h, which I just added to consolidate
> various bits of code that want the _default_ rendering settings, seems
> like a reasonable place to put it.
>
> Within WebKit, PlatformSupport::getRenderStyleForStrike() either:
>
> a) calls WebFontInfo::renderStyleForStrike() directly if possible
> b) uses WebSandboxSupport to IPC to the browser to call
> WebFontInfo::renderStyleForStrike()
>
> For a), I think that I'd instead want to expose something via
> PlatformSupport that would be implemented in Chrome to call the code
> in ui/gfx directly.  If this makes sense, any suggestions about how it
> should be exposed?  I don't see any OS(UNIX) ifdefs under
> Platform/chromium/public; it looks like the preferred approach is to
> restrict interface differences to the linux/, win/, etc.
> subdirectories.  Should I add a new WebFontSupport or similarly-named
> object that just exposes this method on Linux, or is there a better
> way to handle the no-sandbox case?

That seems fine.  There's already a linux/ directory in the API for
things like this that are OS-specific.

Adam