headers
Henry Ludemann | 1 Mar 2011 03:16
Picon

Re: Stall when uploading to sftp using multi interface

Daniel Stenberg wrote:
> Thanks a lot for your patches and work on this. I'm on vacation this week so
> I won't get around to looking into these things in any detail until next
> week or so.

No worries! Enjoy your break.

> It will help to get an example application source code done for repeating
> the problems and subsequently verifying the fixes. Then we could possibly
> turn the code into a proper test case to make sure future libcurls won't
> break again in this aspect!

I sent the source of an example program on the 24th that exhibits the
problem. I'll investigate the test framework with a view to
integrating it there.
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Permalink | Reply |
headers
Henry Ludemann | 3 Mar 2011 08:29
Picon

Re: Stall when uploading to sftp using multi interface

Henry Ludemann wrote:
> Daniel Stenberg wrote:
>> ... Then we could possibly
>> turn the code into a proper test case to make sure future libcurls won't
>> break again in this aspect!
>
> ... I'll investigate the test framework with a view to
> integrating it there.

I've create a test case in the curl framework as
tests/libtests/lib582.c that exhibits the problem, though I've marked
the test as DISABLED (as it's currently failing). You can pull it from
https://github.com/asdf1011/curl/tree/sftp_unit_test.

Most of my development at the moment is under Solaris, but ssh tests
are being skipped on this platform (due to
http://curl.haxx.se/mail/lib-2008-06/0188.html). That said, this test
case fails under linux as well.

Note that it only seems to fail when using curl_multi_socket_action.
If using curl_multi_perform it seems to run ok (you can make the test
occasionally pass using curl_multi_socket_action if you pass in 0 as
the evBitMask, forcing curl to recalculate the socket state).
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Permalink | Reply |
headers
Daniel Stenberg | 8 Mar 2011 00:23
Picon
Favicon
Gravatar

Re: Stall when uploading to sftp using multi interface

On Thu, 3 Mar 2011, Henry Ludemann wrote:

> I've create a test case in the curl framework as tests/libtests/lib582.c 
> that exhibits the problem, though I've marked the test as DISABLED (as it's 
> currently failing). You can pull it from 
> https://github.com/asdf1011/curl/tree/sftp_unit_test.

Excellent and thanks. I've merged it and pushed it on the master repo now so 
that anyone can get it and play with it. (As you'll notice I modified it 
slightly.)

I've not yet been able to produce a fix.

--

-- 

  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Permalink | Reply |
headers
Henry Ludemann | 8 Mar 2011 03:26
Picon

Re: Stall when uploading to sftp using multi interface

Daniel Stenberg wrote:
> Excellent and thanks. I've merged it and pushed it on the master repo now so
> that anyone can get it and play with it. (As you'll notice I modified it
> slightly.)

It looks like the source of tests/libtest/lib582.c wasn't added in the commit?

> I've not yet been able to produce a fix.

No worries, I'll continue having a look over the next few days.
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Permalink | Reply |
headers
Daniel Stenberg | 8 Mar 2011 08:46
Picon
Favicon
Gravatar

Re: Stall when uploading to sftp using multi interface

On Tue, 8 Mar 2011, Henry Ludemann wrote:

> It looks like the source of tests/libtest/lib582.c wasn't added in the 
> commit?

Oops. Fixed now!

>> I've not yet been able to produce a fix.
>
> No worries, I'll continue having a look over the next few days.

Me too...

--

-- 

  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Permalink | Reply |
headers
Daniel Stenberg | 12 Mar 2011 23:13
Picon
Favicon
Gravatar

Re: Stall when uploading to sftp using multi interface

On Tue, 8 Mar 2011, Henry Ludemann wrote:

>> I've not yet been able to produce a fix.
>
> No worries, I'll continue having a look over the next few days.

Thanks for your help and patience. I've now committed a series of fixes to the 
git repo, and I've enabled test 582 and it seems to run fine.

Of course we should check the build logs a while ahead to make sure it isn't 
only doing good in my end! Please have a go and see if you can detect any 
remaining problems.

--

-- 

  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Permalink | Reply |
headers
Daniel Stenberg | 13 Mar 2011 00:57
Picon
Favicon
Gravatar

Re: Stall when uploading to sftp using multi interface

On Sat, 12 Mar 2011, Daniel Stenberg wrote:

> Thanks for your help and patience. I've now committed a series of fixes to 
> the git repo, and I've enabled test 582 and it seems to run fine.

Argh. I was too quick to celebrate. When I run the test now without valgrind 
(./runtests -n 582) I'm back to a timeout error! :-(

I've put it back as disabled for now, and I'll keep working on it.

--

-- 

  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Permalink | Reply |
headers
Daniel Stenberg | 13 Mar 2011 23:26
Picon
Favicon
Gravatar

Re: Stall when uploading to sftp using multi interface

On Sun, 13 Mar 2011, Daniel Stenberg wrote:

> Argh. I was too quick to celebrate. When I run the test now without valgrind 
> (./runtests -n 582) I'm back to a timeout error! :-(
>
> I've put it back as disabled for now, and I'll keep working on it.

It might work now. I've enabled it now again at least and made a few more 
fixes...

--

-- 

  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Permalink | Reply |
headers
Henry Ludemann | 14 Mar 2011 03:55
Picon

Re: Stall when uploading to sftp using multi interface

> It might work now. I've enabled it now again at least and made a few more
> fixes...

I can confirm it works both in the test case and in the original
system the test case was derived from; thanks very much for your help!
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Permalink | Reply |
headers
Daniel Stenberg | 14 Mar 2011 09:15
Picon
Favicon
Gravatar

Re: Stall when uploading to sftp using multi interface

On Mon, 14 Mar 2011, Henry Ludemann wrote:

> I can confirm it works both in the test case and in the original
> system the test case was derived from; thanks very much for your help!

Lovely! There was just a stream of little quirks that made the multi_socket 
interface perform badly or wrongly with SFTP. Your helpful recipe and test 
case helped me out greatly.

--

-- 

  / daniel.haxx.se
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Permalink | Reply |
headers
chirayu joshi | 21 Mar 2011 15:14
Picon

Re: Stall when uploading to sftp using multi interface

Hi ,
I would like to create TELNET client using LIB CURL which need to
communicate with Telnet Server.Basically i need to relay data from
Telnet  server  to telnet client....PLZ provide your valuable
suggestion and feedbacks.

Your's Truely
Chirayu Joshi
-------------------------------------------------------------------
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette:  http://curl.haxx.se/mail/etiquette.html
Permalink | Reply |

Gmane