headers
Jamie Cameron | 10 Dec 2005 09:21

Re: [webmin-devel] making config change to existing module, addingpopup"select users" list

On 10/Dec/2005 09:05 Mr Duck wrote ..
> Jamie Cameron wrote:
> > That looks OK to me. What does the show__userIgnoreList function contain
> > though?
> 
>    It's pretty straight-forward.
> 
> ----CODE----
> 
> sub show_userIgnoreList
> {
>    my($preta)  = '<TEXTAREA NAME="ignore_users" COLS="35" ROWS="4">';
>    my($postta) = '</TEXTAREA>';
> 
>    return
>        $preta .
>        $config{'ignore_users'} .
>        $postta .
>        '&nbsp;' .
>        &user_chooser_button("ignore_users", 1);
> }
> 
> ----END-----

I have one suggestion here - change the $config{'ignore_users'} to $_[0]

>    I have noticed in the interim that the webmin/conf/mailboxes/config
> file does get updated when I save changes using the previously given
> parse_ function.  However, the webmin/mailboxes/config file does not.
>
(Continue reading)

Permalink | Reply |
headers
Mr Duck | 13 Dec 2005 16:40

Re: [webmin-devel] making config change to existing module, addingpopup"select users" list

Jamie Cameron wrote:
>>   return
>>       $preta .
>>       $config{'ignore_users'} .
>>       $postta .
>>       '&nbsp;' .
>>       &user_chooser_button("ignore_users", 1);
> I have one suggestion here - change the $config{'ignore_users'} to $_[0]

   OK.  I did so, and it works now. (= When I originally implemented
the function, I had it displaying all values to  <at> _ to see if anything
was passed in, but since I didn't have a value yet, nothing was shown,
and I mistakenly assumed that nothing was passed in.  Slap my hand!
(=

   Anyway, it works now, and splendidly I must say.  AFAIK, these changes
satisfy your given requirements of "well written, don't break anything,
and optional".

   The only thing that I _don't_ have, however, is multi-language
config.info files. (=

   Is there anything else that you suggest I do/check/examine/etc
before I pass the patches and stuff on to you?

   Thanks!

Mr Duck

-------------------------------------------------------
(Continue reading)

Permalink | Reply |
headers
Jamie Cameron | 13 Dec 2005 23:47

Re: [webmin-devel] making config change to existing module, addingpopup"selectusers" list

On 14/Dec/2005 02:40 Mr Duck wrote ..
> Jamie Cameron wrote:
> >>   return
> >>       $preta .
> >>       $config{'ignore_users'} .
> >>       $postta .
> >>       '&nbsp;' .
> >>       &user_chooser_button("ignore_users", 1);
> > I have one suggestion here - change the $config{'ignore_users'} to $_[0]
> 
>    OK.  I did so, and it works now. (= When I originally implemented

Excellent!

> the function, I had it displaying all values to  <at> _ to see if anything
> was passed in, but since I didn't have a value yet, nothing was shown,
> and I mistakenly assumed that nothing was passed in.  Slap my hand!
> (=
> 
>    Anyway, it works now, and splendidly I must say.  AFAIK, these changes
> satisfy your given requirements of "well written, don't break anything,
> and optional".
> 
>    The only thing that I _don't_ have, however, is multi-language
> config.info files. (=

I wouldn't worry too much .. Webmin will just display the english text
if no translation exists in the user's language.

>    Is there anything else that you suggest I do/check/examine/etc
(Continue reading)

Permalink | Reply |

Gmane