headers
Seunggyun Kim | 18 Jul 2012 07:09

[E-devel] [PATCH] elm_icon is disappeared when theme hook is called.

Dear All,

[Current Issue]
 - The elm_icon can be disappeared when theme hook is called.
   You can see the problem in the below situation.
    a) elementary_test -> Layout select
    b) elementary_config -> Fonts(toolbar) -> select some font class, font,
style, size
    c) Select "Apply" button
   then two icons in title layout are disappeared.

[Main cause]
 - when theme hook is called, internally _elm_image_smart_sizing_eval
function is called.
   The function calculates icon's min, max size. 
   But min, max size is calculated  only in case no_scale is true or
resize_down or resize_up is false.
   If application isn't set no_scale or resize_down/up, minw and minh value
is just -1.
   So when theme hooks is called then sizing_eval is called, icon's min size
is -1 and that is disappeared.

[Change Description]
 - I just added evas_object_size_hint_min_get(obj, &minw, minh) in
_elm_image_smart_sizing_eval.
    Patch is working well, but I don't think this is right solution because
that would break image(icon) min,max concept

Please review the attached patch.
(Continue reading)

Permalink | Reply |
headers
Daniel Juyung Seo | 18 Jul 2012 11:14
Picon
Gravatar

Re: [E-devel] [PATCH] elm_icon is disappeared when theme hook is called.

Yes elm_image is broken on theme change.
I don't know what the right direction of this issue is.
Anybody can review this?

Daniel Juyung Seo (SeoZ)

On Wed, Jul 18, 2012 at 2:09 PM, Seunggyun Kim <sgyun.kim <at> samsung.com> wrote:
> Dear All,
>
> [Current Issue]
>  - The elm_icon can be disappeared when theme hook is called.
>    You can see the problem in the below situation.
>     a) elementary_test -> Layout select
>     b) elementary_config -> Fonts(toolbar) -> select some font class, font,
> style, size
>     c) Select "Apply" button
>    then two icons in title layout are disappeared.
>
> [Main cause]
>  - when theme hook is called, internally _elm_image_smart_sizing_eval
> function is called.
>    The function calculates icon's min, max size.
>    But min, max size is calculated  only in case no_scale is true or
> resize_down or resize_up is false.
>    If application isn't set no_scale or resize_down/up, minw and minh value
> is just -1.
>    So when theme hooks is called then sizing_eval is called, icon's min size
> is -1 and that is disappeared.
>
> [Change Description]
(Continue reading)

Permalink | Reply |
headers
Gustavo Lima Chaves | 18 Jul 2012 18:47
Gravatar

Re: [E-devel] [PATCH] elm_icon is disappeared when theme hook is called.

* Daniel Juyung Seo <seojuyung2 <at> gmail.com> [2012-07-18 18:14:14 +0900]:

> Yes elm_image is broken on theme change.
> I don't know what the right direction of this issue is.
> Anybody can review this?

Sounds reasonable. Raster?
We gotta check image, icon and photo are OK after this.

> 
> Daniel Juyung Seo (SeoZ)
> 
> On Wed, Jul 18, 2012 at 2:09 PM, Seunggyun Kim <sgyun.kim <at> samsung.com> wrote:
> > Dear All,
> >
> > [Current Issue]
> >  - The elm_icon can be disappeared when theme hook is called.
> >    You can see the problem in the below situation.
> >     a) elementary_test -> Layout select
> >     b) elementary_config -> Fonts(toolbar) -> select some font class, font,
> > style, size
> >     c) Select "Apply" button
> >    then two icons in title layout are disappeared.
> >
> > [Main cause]
> >  - when theme hook is called, internally _elm_image_smart_sizing_eval
> > function is called.
> >    The function calculates icon's min, max size.
> >    But min, max size is calculated  only in case no_scale is true or
> > resize_down or resize_up is false.
(Continue reading)

Permalink | Reply |
headers
Carsten Haitzler | 19 Jul 2012 10:09
Favicon
Gravatar

Re: [E-devel] [PATCH] elm_icon is disappeared when theme hook is called.

On Wed, 18 Jul 2012 13:47:37 -0300 Gustavo Lima Chaves <glima <at> profusion.mobi>
said:

> * Daniel Juyung Seo <seojuyung2 <at> gmail.com> [2012-07-18 18:14:14 +0900]:
> 
> > Yes elm_image is broken on theme change.
> > I don't know what the right direction of this issue is.
> > Anybody can review this?
> 
> Sounds reasonable. Raster?
> We gotta check image, icon and photo are OK after this.

they aren't any more broken than already (photocam has a nasty now during
zoom... ugh!!!!!!!!!!)

> > 
> > Daniel Juyung Seo (SeoZ)
> > 
> > On Wed, Jul 18, 2012 at 2:09 PM, Seunggyun Kim <sgyun.kim <at> samsung.com>
> > wrote:
> > > Dear All,
> > >
> > > [Current Issue]
> > >  - The elm_icon can be disappeared when theme hook is called.
> > >    You can see the problem in the below situation.
> > >     a) elementary_test -> Layout select
> > >     b) elementary_config -> Fonts(toolbar) -> select some font class,
> > > font, style, size
> > >     c) Select "Apply" button
> > >    then two icons in title layout are disappeared.
(Continue reading)

Permalink | Reply |
headers
Carsten Haitzler | 19 Jul 2012 10:11
Favicon
Gravatar

Re: [E-devel] [PATCH] elm_icon is disappeared when theme hook is called.

On Wed, 18 Jul 2012 14:09:24 +0900 Seunggyun Kim <sgyun.kim <at> samsung.com> said:

thanks! in svn it is! :)

> Dear All,
> 
> [Current Issue]
>  - The elm_icon can be disappeared when theme hook is called.
>    You can see the problem in the below situation.
>     a) elementary_test -> Layout select
>     b) elementary_config -> Fonts(toolbar) -> select some font class, font,
> style, size
>     c) Select "Apply" button
>    then two icons in title layout are disappeared.
> 
> [Main cause]
>  - when theme hook is called, internally _elm_image_smart_sizing_eval
> function is called.
>    The function calculates icon's min, max size. 
>    But min, max size is calculated  only in case no_scale is true or
> resize_down or resize_up is false.
>    If application isn't set no_scale or resize_down/up, minw and minh value
> is just -1.
>    So when theme hooks is called then sizing_eval is called, icon's min size
> is -1 and that is disappeared.
> 
> [Change Description]
>  - I just added evas_object_size_hint_min_get(obj, &minw, minh) in
> _elm_image_smart_sizing_eval.
>     Patch is working well, but I don't think this is right solution because
(Continue reading)

Permalink | Reply |

Gmane