The AbiWord text processor developer mailing list

Fabiano Fidêncio | 9 Feb 14:23

Re: hub - r30565 - in abiword/trunk/src: af/ev/cocoa af/xap/cocoa wp/ap/cocoa


Hub,

On Thu, Dec 29, 2011 at 2:28 AM,  <cvs <at> abisource.com> wrote:
>
> Author: hub
> Date: 2011-12-29 05:28:33 +0100 (Thu, 29 Dec 2011)
> New Revision: 30565
>
> Modified:
>   abiword/trunk/src/af/ev/cocoa/ev_CocoaMenu.cpp
>   abiword/trunk/src/af/ev/cocoa/ev_CocoaToolbar.cpp
>   abiword/trunk/src/af/xap/cocoa/xap_CocoaApp.cpp
>   abiword/trunk/src/af/xap/cocoa/xap_CocoaAppController.cpp
>   abiword/trunk/src/af/xap/cocoa/xap_CocoaCompat.h
>   abiword/trunk/src/af/xap/cocoa/xap_CocoaDialog_Utilities.cpp
>   abiword/trunk/src/af/xap/cocoa/xap_CocoaDlg_ClipArt.cpp
>   abiword/trunk/src/af/xap/cocoa/xap_CocoaDlg_MessageBox.cpp
>   abiword/trunk/src/af/xap/cocoa/xap_CocoaPlugin.h
>   abiword/trunk/src/af/xap/cocoa/xap_CocoaTextView.cpp
>   abiword/trunk/src/af/xap/cocoa/xap_CocoaToolPalette.cpp
>   abiword/trunk/src/af/xap/cocoa/xap_Cocoa_NSTableUtils.cpp
>   abiword/trunk/src/af/xap/cocoa/xap_PrintingNSView.cpp
>   abiword/trunk/src/wp/ap/cocoa/ap_CocoaDialog_FormatFrame.h
>   abiword/trunk/src/wp/ap/cocoa/ap_CocoaFrameImpl.cpp
> Log:
> Warning fixes
> 64-bits fixes
>
> Modified: abiword/trunk/src/af/ev/cocoa/ev_CocoaMenu.cpp

(Continue reading)

Hub Figuière | 9 Feb 21:13

Picon

Re: hub - r30565 - in abiword/trunk/src: af/ev/cocoa af/xap/cocoa wp/ap/cocoa


No need to Cc me when posting to the list.

On 09/02/12 05:23 AM, Fabiano Fidêncio wrote:
> 
>>
>> Modified: abiword/trunk/src/af/xap/cocoa/xap_CocoaCompat.h
>> ===================================================================
>> --- abiword/trunk/src/af/xap/cocoa/xap_CocoaCompat.h    2011-12-29 03:36:35 UTC (rev 30564)
>> +++ abiword/trunk/src/af/xap/cocoa/xap_CocoaCompat.h    2011-12-29 04:28:33 UTC (rev 30565)
>> @@ -30,4 +30,11 @@
>>  typedef float CGFloat;
>>  #endif
>>
>> +
>> +#if NSINTEGER_DEFINED
>> +#else
>> +typedef int NSInteger;
>> +typedef unsigned int NSUInteger;
>>  #endif
> 
> When you have time, take a look at this:
> http://pastebin.com/9LZqULev
> 
> I think it's an OS X 10.6 running.
> Which kind of infos do you need?

As I replied privately, for the record:

Try adding in src/af/xap/cocoa/xap_CocoaCompat.h

(Continue reading)

Fabiano Fidêncio | 10 Feb 02:46

Re: hub - r30565 - in abiword/trunk/src: af/ev/cocoa af/xap/cocoa wp/ap/cocoa


Hub,

On Thu, Feb 9, 2012 at 6:13 PM, Hub Figuière <hfiguiere <at> teaser.fr> wrote:
>
> No need to Cc me when posting to the list.
>
>
> On 09/02/12 05:23 AM, Fabiano Fidêncio wrote:
>>
>>>
>>> Modified: abiword/trunk/src/af/xap/cocoa/xap_CocoaCompat.h
>>> ===================================================================
>>> --- abiword/trunk/src/af/xap/cocoa/xap_CocoaCompat.h    2011-12-29 03:36:35 UTC (rev 30564)
>>> +++ abiword/trunk/src/af/xap/cocoa/xap_CocoaCompat.h    2011-12-29 04:28:33 UTC (rev 30565)
>>> @@ -30,4 +30,11 @@
>>>  typedef float CGFloat;
>>>  #endif
>>>
>>> +
>>> +#if NSINTEGER_DEFINED
>>> +#else
>>> +typedef int NSInteger;
>>> +typedef unsigned int NSUInteger;
>>>  #endif
>>
>> When you have time, take a look at this:
>> http://pastebin.com/9LZqULev
>>
>> I think it's an OS X 10.6 running.

(Continue reading)

Hub Figuière | 10 Feb 04:35

Picon

Re: hub - r30565 - in abiword/trunk/src: af/ev/cocoa af/xap/cocoa wp/ap/cocoa


>>> When you have time, take a look at this:
>>> http://pastebin.com/9LZqULev
>>>
>>> I think it's an OS X 10.6 running.
>>> Which kind of infos do you need?
>>
>> As I replied privately, for the record:
>>
>>
>> Try adding in src/af/xap/cocoa/xap_CocoaCompat.h
>> #import <Foundation/Foundation.h>
>> This should be enough (I haven't tried)
> 
> No deal: http://pastebin.com/KUsztKeu
> But don't worry. I'm without my mac until I finish my moving, so I
> can't help so much.\

That's a different error.

I think it is RDF support that does that.

:-/

Hub

Hub Figuière | 11 Feb 07:54

Picon

RDF UI support (was: Re: hub - r30565 - in abiword/trunk/src: af/ev/cocoa af/xap/cocoa wp/ap/cocoa)


>> No deal: http://pastebin.com/KUsztKeu
>> But don't worry. I'm without my mac until I finish my moving, so I
>> can't help so much.\
>
> That's a different error.

Here s the error:

   CXXLD  libabiword-2.9.la
Undefined symbols:
   "runInsertReferenceDialog(FV_View*)", referenced from:
       ap_EditMethods::rdfInsertRef(AV_View*, EV_EditMethodCallData*) 
     in libxp.a(ap_EditMethods.o)
   "runSemanticStylesheetsDialog(FV_View*)", referenced from:
       ap_EditMethods::rdfStylesheetSettings(AV_View*, 
EV_EditMethodCallData*)       in libxp.a(ap_EditMethods.o)
ld: symbol(s) not found
collect2: ld returned 1 exit status

>
> I think it is RDF support that does that.

Congrats for opening the can of worm. That's where a bug needs to be filed.

Here is the issues:

- The ap_EditMethods are compiled in even when RDF support isn't. BAD

- runInsertReferenceDialog() and runSemanticStylesheetsDialog() are

(Continue reading)

Ben Martin | 11 Feb 09:34

Picon

Re: RDF UI support (was: Re: hub - r30565 - in abiword/trunk/src: af/ev/cocoa af/xap/cocoa wp/ap/cocoa)

On Fri, 2012-02-10 at 22:54 -0800, Hub Figuière wrote:
> 
> >> No deal: http://pastebin.com/KUsztKeu
> >> But don't worry. I'm without my mac until I finish my moving, so I
> >> can't help so much.\
> >
> > That's a different error.
> 
> Here s the error:
> 
>    CXXLD  libabiword-2.9.la
> Undefined symbols:
>    "runInsertReferenceDialog(FV_View*)", referenced from:
>        ap_EditMethods::rdfInsertRef(AV_View*, EV_EditMethodCallData*) 
>      in libxp.a(ap_EditMethods.o)
>    "runSemanticStylesheetsDialog(FV_View*)", referenced from:
>        ap_EditMethods::rdfStylesheetSettings(AV_View*, 
> EV_EditMethodCallData*)       in libxp.a(ap_EditMethods.o)
> ld: symbol(s) not found
> collect2: ld returned 1 exit status
> 
> 
> >
> > I think it is RDF support that does that.
> 
> Congrats for opening the can of worm. That's where a bug needs to be filed.
> 
> Here is the issues:
> 
> - The ap_EditMethods are compiled in even when RDF support isn't. BAD

(Continue reading)

Hub Figuière | 11 Feb 22:38

Picon

Re: RDF UI support


>> Here is the issues:
>>
>> - The ap_EditMethods are compiled in even when RDF support isn't. BAD
>>
>> - runInsertReferenceDialog() and runSemanticStylesheetsDialog() are 
>> implemented in src/text/ptbl/xp/pd_DocumentRDF.cpp which isn't compiled 
>> when RDF support isn't. GOOD
>>
>> - these two function don't belong in pd_DocumentRDF.cpp. UI do NOT 
>> beling the PD_*. Gtk code do not belong to "xp" code. BAD and BAD.
> 
> Yep. I'll fix this shortly, using the more complex method below.

Also, the patch dragging libchamplain into AbiWord break the build on
Gtk2 as libchamplain bring Gtk-whatever with it.

I'm not sure what the proper solution is.

Hub

Jean Brefort | 12 Feb 08:50

Re: RDF UI support


Also, if abiword is configured with --wih-champlain, build fails because
CFLAGS and LIBS are not correctly set in that case. We need to add an
appropriate call to pkg-config.

Regards,
Jean

Le samedi 11 février 2012 à 13:38 -0800, Hub Figuière a écrit :
> 
> >> Here is the issues:
> >>
> >> - The ap_EditMethods are compiled in even when RDF support isn't. BAD
> >>
> >> - runInsertReferenceDialog() and runSemanticStylesheetsDialog() are 
> >> implemented in src/text/ptbl/xp/pd_DocumentRDF.cpp which isn't compiled 
> >> when RDF support isn't. GOOD
> >>
> >> - these two function don't belong in pd_DocumentRDF.cpp. UI do NOT 
> >> beling the PD_*. Gtk code do not belong to "xp" code. BAD and BAD.
> > 
> > Yep. I'll fix this shortly, using the more complex method below.
> 
> Also, the patch dragging libchamplain into AbiWord break the build on
> Gtk2 as libchamplain bring Gtk-whatever with it.
> 
> I'm not sure what the proper solution is.
> 
> Hub

(Continue reading)

Ben Martin | 13 Feb 03:53

Picon

Re: RDF UI support

Hi,
  In configure.in I have a test for champlain-gtk-0.12.

  looking at configure.in I see a check with the following fragment:

champlain_req=' champlain-gtk-0.12 '
...
PKG_CHECK_MODULES(CHAMPLAIN, [ $champlain_req ],

In src/Makefile.am I link with CHAMPLAIN if it is found in the
libabiword_ <at> ABIWORD_SERIES <at> _la_LDFLAGS target.

I'm not sure which changes are needed to better detect and optionally
use champlain if found. I'm happy to make any needed changes.

On Sun, 2012-02-12 at 08:50 +0100, Jean Brefort wrote:
> Also, if abiword is configured with --wih-champlain, build fails because
> CFLAGS and LIBS are not correctly set in that case. We need to add an
> appropriate call to pkg-config.
> 
> Regards,
> Jean
> 
> Le samedi 11 février 2012 à 13:38 -0800, Hub Figuière a écrit :
> > 
> > >> Here is the issues:
> > >>
> > >> - The ap_EditMethods are compiled in even when RDF support isn't. BAD
> > >>
> > >> - runInsertReferenceDialog() and runSemanticStylesheetsDialog() are

(Continue reading)

Hub Figuière | 13 Feb 04:09

Picon

Re: RDF UI support

On 12/02/12 06:53 PM, Ben Martin wrote:
> Hi,
>   In configure.in I have a test for champlain-gtk-0.12.
> 
>   looking at configure.in I see a check with the following fragment:
> 
> champlain_req=' champlain-gtk-0.12 '
> ...
> PKG_CHECK_MODULES(CHAMPLAIN, [ $champlain_req ],
> 
> In src/Makefile.am I link with CHAMPLAIN if it is found in the
> libabiword_ <at> ABIWORD_SERIES <at> _la_LDFLAGS target.
> 
> I'm not sure which changes are needed to better detect and optionally
> use champlain if found. I'm happy to make any needed changes.

The problem lies down to the fact the libchamplain seems to not
distinguish linking against gtk2 or gtk3, and will drag whichever it is
linked against. I don't know whether they support both version or just
one, but if they support one it might be interesting to know which is
the cut-off and use that depending on the requested version of gtk.

Also I do believe that this also do NOT belong to XP code nor to "PD_".

Hub

Ben Martin | 13 Feb 04:14

Picon

Re: RDF UI support

On Sun, 2012-02-12 at 19:09 -0800, Hub Figuière wrote:
> On 12/02/12 06:53 PM, Ben Martin wrote:
> > Hi,
> >   In configure.in I have a test for champlain-gtk-0.12.
> > 
> >   looking at configure.in I see a check with the following fragment:
> > 
> > champlain_req=' champlain-gtk-0.12 '
> > ...
> > PKG_CHECK_MODULES(CHAMPLAIN, [ $champlain_req ],
> > 
> > In src/Makefile.am I link with CHAMPLAIN if it is found in the
> > libabiword_ <at> ABIWORD_SERIES <at> _la_LDFLAGS target.
> > 
> > I'm not sure which changes are needed to better detect and optionally
> > use champlain if found. I'm happy to make any needed changes.
> 
> 
> The problem lies down to the fact the libchamplain seems to not
> distinguish linking against gtk2 or gtk3, and will drag whichever it is
> linked against. I don't know whether they support both version or just
> one, but if they support one it might be interesting to know which is
> the cut-off and use that depending on the requested version of gtk.

I've got a little configure.in magic for that part, committing soon.

> 
> Also I do believe that this also do NOT belong to XP code nor to "PD_".

Definitely. I will be moving that gui part out of there shortly.

(Continue reading)

Ben Martin | 13 Feb 04:50

Picon

Re: RDF UI support

On Mon, 2012-02-13 at 13:14 +1000, Ben Martin wrote:
> On Sun, 2012-02-12 at 19:09 -0800, Hub Figuière wrote:
> > On 12/02/12 06:53 PM, Ben Martin wrote:
> > > Hi,
> > >   In configure.in I have a test for champlain-gtk-0.12.
> > > 
> > >   looking at configure.in I see a check with the following fragment:
> > > 
> > > champlain_req=' champlain-gtk-0.12 '
> > > ...
> > > PKG_CHECK_MODULES(CHAMPLAIN, [ $champlain_req ],
> > > 
> > > In src/Makefile.am I link with CHAMPLAIN if it is found in the
> > > libabiword_ <at> ABIWORD_SERIES <at> _la_LDFLAGS target.
> > > 
> > > I'm not sure which changes are needed to better detect and optionally
> > > use champlain if found. I'm happy to make any needed changes.
> > 
> > 
> > The problem lies down to the fact the libchamplain seems to not
> > distinguish linking against gtk2 or gtk3, and will drag whichever it is
> > linked against. I don't know whether they support both version or just
> > one, but if they support one it might be interesting to know which is
> > the cut-off and use that depending on the requested version of gtk.
> 
> I've got a little configure.in magic for that part, committing soon.
> 

ok, r30638 introduces a little test for that. If we are building gtk3
and libchamp is linked to gtk2 then we should no longer try to build

(Continue reading)

Jean Brefort | 13 Feb 08:50

Re: RDF UI support


The test should be in the with-champlain test. At the moment, if you
have libchamplain and configure --without-champlain, you end using
champlain, and after configure --with-champlain build just fails.
The only sane case is when you don't have any champlain related arg.
I probably should patch this myself 

Regards,
Jean

Le lundi 13 février 2012 à 12:53 +1000, Ben Martin a écrit :
> Hi,
>   In configure.in I have a test for champlain-gtk-0.12.
> 
>   looking at configure.in I see a check with the following fragment:
> 
> champlain_req=' champlain-gtk-0.12 '
> ...
> PKG_CHECK_MODULES(CHAMPLAIN, [ $champlain_req ],
> 
> In src/Makefile.am I link with CHAMPLAIN if it is found in the
> libabiword_ <at> ABIWORD_SERIES <at> _la_LDFLAGS target.
> 
> I'm not sure which changes are needed to better detect and optionally
> use champlain if found. I'm happy to make any needed changes.
> 
> 
> On Sun, 2012-02-12 at 08:50 +0100, Jean Brefort wrote:
> > Also, if abiword is configured with --wih-champlain, build fails because
> > CFLAGS and LIBS are not correctly set in that case. We need to add an

(Continue reading)

Return

Return to gmane.editors.abiword.devel.

Search Archive

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane