rgheck | 4 Oct 19:08
Favicon
Gravatar

[PATCH] Modularize Extra Fonts


OK, so this is hardly regressions and crashes, but it's simple and 
starts to disentangle some of the mess of classes. All this does is move 
the "extra fonts" stuff in extarticle, extbook, extletter, and extreport 
into a module, and then it has the necessary lyx2lyx to make this 
painless. The format change is of course needed to drive the lyx2lyx 
conversion.

Any objections?

I think there are probably similar conversions that can be done to other 
layouts, but they'd all need format changes, too, so they'll likely have 
to wait.

Richard

Index: development/FORMAT
===================================================================
--- development/FORMAT	(revision 26729)
+++ development/FORMAT	(working copy)
@@ -1,6 +1,9 @@
 LyX file-format changes
 -----------------------

+2008-10-04 Richard Heck <rgheck@...>
+	* Format incremented to 342: modularization of "extra font" classes.
+
 2008-09-30 Uwe Stöhr <uwestoehr@...>
(Continue reading)

Uwe Stöhr | 4 Oct 22:11

Re: [PATCH] Modularize Extra Fonts

 > Any objections?

As we discussed in the thread for the extended search feature, we should come to an end with 
features and improvements for LyX 1.6.0. Your patch doesn't fix a bug, it is an enhancement.
I don't want to be impolite, but we must come to and end and start going to bug-only fix mode. I 
think your feature is not urgent, or do you want to have it in because of the needed fileformat change?

Besides this, what is the advantage of your patch? I mean I select and ext class because I need the 
extended font sizes, so what is the benefit of being forced to load additionally a module to get 
what I expect to get? The font size definitions should stay in the ext layouts.

For other layouts, do they compile? When I e.g. load your module to the UserGuide and then use the 
font size 18?

regards Uwe

Richard heck | 5 Oct 03:32
Favicon
Gravatar

Re: [PATCH] Modularize Extra Fonts

Uwe Stöhr wrote:
> For other layouts, do they compile? When I e.g. load your module to 
> the UserGuide and then use the font size 18?
>

Well, that's the important question. And you're right: They don't. So 
never mind for now. But something like this ought to work....

rh

Favicon

Re: [PATCH] Modularize Extra Fonts

Le 5 oct. 08 à 03:32, Richard heck a écrit :
> Uwe Stöhr wrote:
>> For other layouts, do they compile? When I e.g. load your module  
>> to the UserGuide and then use the font size 18?
>>
>
> Well, that's the important question. And you're right: They don't.  
> So never mind for now. But something like this ought to work....

If you want to modularize, you may have a look at literate classes. I  
suspect we could have a noweb module
instead.

JMarc

Gmane