headers
Roland Winkler | 12 Jul 2012 20:53
Picon

[BBDB] ChangeLog 2012-07-12

2012-07-12  Roland Winkler  <winkler <at> gnu.org>
	* lisp/bbdb-mua.el (bbdb-get-address-components)
	(bbdb-message-get-cache, bbdb-message-set-cache)
	(bbdb-message-rem-cache, bbdb-mua-annotate-sender)
	(bbdb-mua-annotate-recipients, bbdb-mua-edit-field)
	(bbdb-canonical-hosts, bbdb-canonicalize-mail-1)
	(bbdb-mail-redundant-p, bbdb-delete-redundant-mails)
	(bbdb-message-clean-name-default): Fix docstring.

BBDB is available at
http://savannah.nongnu.org/projects/bbdb/
To check it out, use
git clone git://git.savannah.nongnu.org/bbdb.git

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
bbdb-info <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/
Permalink | Reply |
headers
Roland Winkler | 18 Jul 2012 00:06
Picon

[BBDB] ChangeLog 2012-07-17

On Wed Jul 11 2012 Sam Steingold wrote:
> btw, when I have a record for "John Smith <foo <at> bar.com>" and I see an
> article by "John Smith <quux <at> bar.com>", bbdb shows John's record but
> does not offer to update the net field unless I try to edit the record
> with ";".  is this intentional?

BBDB now accepts a new value `update' for update-p, see the README
file. This will update existing records, but it will not attempt to
create new records. I kept the value `search' for update-p which
never modifies existing records.

When I looked into this, I had a disappointing surprise. I cannot
believe that even today some fairly basic design flaws of BBDB 2 are
popping up in BBDB 3:

BBDB uses a "message cache" for caching the BBDB records associated
with a message. I had made a silly mistake that made the cache
ineffective in BBDB 3. Well, that bug was easily fixed. But with the
cache being effective again, some fairly important other things are
not working anymore.

- The message cache contains for each message those records that
  have been recognized / created when the message was first viewed
  in the MUA. If these were the records matching the recipients
  (say, following a call of bbdb-mua-display-recipients), a
  subsequent call of bbdb-mua-display-sender again displays the
  recipients, because only those records are stored in the cache.
  Not quite the expected behavior.

- Messages are identified in the cache via `assq' and "message
(Continue reading)

Permalink | Reply |
headers
Stephen Leake | 19 Jul 2012 13:24
Favicon

Re: [BBDB] ChangeLog 2012-07-17

"Roland Winkler" <winkler <at> gnu.org> writes:

> So far, nobody noticed a bottleneck because of the broken message
> cache in BBDB 3. I am tempted to remove this feature altogether...
> (better suggestions welcome)

I suggest deleting the cache. Although the caching may have been a good
optimization when it was first introduced, things have changed since
then.

I'd much rather have bbdb work correctly, and be easy to
understand/improve, than have it work blazingly fast.

> In the meanwhile, I have changed the default value of
> bbdb-message-caching to nil.

excellent.

--

-- 
-- Stephe

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
bbdb-info <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
(Continue reading)

Permalink | Reply |
headers
Sam Steingold | 20 Jul 2012 04:39
Picon

Re: [BBDB] ChangeLog 2012-07-17

> * Roland Winkler <jvaxyre <at> tah.bet> [2012-07-17 17:06:52 -0500]:
>
> On Tue Jul 17 2012 Sam Steingold wrote:
>> I thought that bbdb-canonicalize-mail-function would do the job by
>> returning nil or "" for bad e-mail addresses, and it worked for quite
>> some time (it returned nil).
>
> Use a return value of nil to ignore a mail address.  I cannot
> promise, though, that I already identified all instances in the code
> where this can be relevant.

Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil)
  bbdb-message-search("Alex" nil)
  gnus-user-format-function-b([47052 "Common Lisp or Scheme" "Alex <muzikman127 <at> dontwantspam.com>"
"Fri, 20 Jul 2012 02:11:02 +0000 (UTC)" "<juaenl$2kmt$1 <at> adenine.netfront.net>" "" 1958 28
"mx04.eternal-september.org comp.lang.lisp:47052" nil])
  (format "%c%4s: %s%-20s %s%c" gnus-tmp-opening-bracket gnus-tmp-lines
(gnus-user-format-function-b gnus-tmp-header) (let* ((val (eval (let ((val ...)) (if (> ... 20) (if
... ... ...) val)))) (need (- 20 (string-width val)))) (if (> need 0) (concat nil val (make-string need
32)) val)) (gnus-date-iso8601 (mail-header-date gnus-tmp-header)) gnus-tmp-closing-bracket)

  may I commit this?

--8<---------------cut here---------------start------------->8---
diff --git a/lisp/bbdb-com.el b/lisp/bbdb-com.el
index 282b2b8..f37d4d0 100644
--- a/lisp/bbdb-com.el
+++ b/lisp/bbdb-com.el
 <at>  <at>  -590,9 +590,10  <at>  <at>  This function performs a fast search using `bbdb-hashtable'.
 NAME and MAIL must be strings.  See `bbdb-search' for searching
(Continue reading)

Permalink | Reply |
headers
Roland Winkler | 20 Jul 2012 07:19
Picon

[BBDB] ChangeLog 2012-07-20

On Thu Jul 19 2012 Sam Steingold wrote:
> > * Roland Winkler <jvaxyre <at> tah.bet> [2012-07-17 17:06:52 -0500]:
> > Use a return value of nil to ignore a mail address.  I cannot
> > promise, though, that I already identified all instances in the code
> > where this can be relevant.
> 
> Debugger entered--Lisp error: (wrong-type-argument char-or-string-p nil)
>   bbdb-message-search("Alex" nil)

2012-07-20  Sam Steingold  <sds <at> gnu.org>
	* lisp/bbdb-com.el (bbdb-message-search): Allow args name or mail
	to be nil.

BBDB is available at
http://savannah.nongnu.org/projects/bbdb/
To check it out, use
git clone git://git.savannah.nongnu.org/bbdb.git

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
bbdb-info <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/
(Continue reading)

Permalink | Reply |
headers
Roland Winkler | 20 Jul 2012 22:49
Picon

Re: [BBDB] ChangeLog 2012-07-20

There was a silly bug that made bbdb-annotate-message create new
records only if you did not want to do that. This should be fixed now.

2012-07-20  Roland Winkler  <winkler <at> gnu.org>
	* lisp/bbdb-mua.el (bbdb-annotate-message): Simplify. Create new
	record if update-p has not value update.

BBDB is available at
http://savannah.nongnu.org/projects/bbdb/
To check it out, use
git clone git://git.savannah.nongnu.org/bbdb.git

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
bbdb-info <at> lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bbdb-info
BBDB Home Page: http://bbdb.sourceforge.net/
Permalink | Reply |
headers
Roland Winkler | 9 Aug 2012 16:18
Picon

[BBDB] ChangeLog 2012-08-09 (remove message cache)

On Tue Jul 17 2012 Roland Winkler wrote:
> When I looked into this, I had a disappointing surprise:
> 
> BBDB uses a "message cache" for caching the BBDB records associated
> with a message. I had made a silly mistake that made the cache
> ineffective in BBDB 3. Well, that bug was easily fixed. But with the
> cache being effective again, some fairly important other things are
> not working anymore.
> 
> - The message cache contains for each message those records that
>   have been recognized / created when the message was first viewed
>   in the MUA. If these were the records matching the recipients
>   (say, following a call of bbdb-mua-display-recipients), a
>   subsequent call of bbdb-mua-display-sender again displays the
>   recipients, because only those records are stored in the cache.
>   Not quite the expected behavior.
> 
> - Messages are identified in the cache via `assq' and "message
>   keys". VM uses a message-pointer and rmail uses an integer message
>   key that work fine with assq. Yet for gnus, BBDB 2 used the
>   function bbdb/gnus-get-message-id that returns the value of the
>   "Message-ID" header of a message as a string. For BBDB 3, I even
>   copied this idea for other MUAs... Yet strings don't work with
>   assq and all the caching fails.
> 
>   Here a simple work appears to be assoc instead of assq. Yet this
>   is slower than assq, and I have doubts that then all the caching
>   is still worth the extra coding effort (in particular, when
>   properly keeping track of senders and recipients).
>
(Continue reading)

Permalink | Reply |

Gmane