headers
John J Foerch | 22 Jun 2012 00:08
Picon
Favicon
Gravatar

bug in calendar-exit (calendar-hide-window)

Hello,

In calendar, under a configuration like the following, calendar-exit
kills the frame instead of just the window containing the calendar:

(setq pop-up-windows                nil
      pop-up-frames                 t
      special-display-buffer-names  '(("*Calendar*" (same-frame . t)))
      display-buffer-mark-dedicated 'weak)

Under this configuration, pop-up-frames are used, with windows dedicated
to their buffers, but the calendar is opened in the current frame, not a
new frame.  Calendar-hide-window seems to assume that whenever dedicated
windows are being used, it is okay to delete or iconify a frame:

  (cond
   ...
   ((and (display-multi-frame-p) (window-dedicated-p window))
    (if calendar-remove-frame-by-deleting
        (delete-frame (window-frame window))
        (iconify-frame (window-frame window))))
   ...
   )

M-x version:

  GNU Emacs 23.4.1 (x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
  of 2012-04-07 on trouble, modified by Debian

Any thoughts for a solution?
(Continue reading)

Permalink | Reply |
headers
martin rudalics | 22 Jun 2012 12:22
Picon
Picon

Re: bug in calendar-exit (calendar-hide-window)

I suppose

 > (setq pop-up-windows                nil
 >       pop-up-frames                 t
 >       special-display-buffer-names  '(("*Calendar*" (same-frame . t)))
 >       display-buffer-mark-dedicated 'weak)
 >
 > Under this configuration, pop-up-frames are used, with windows dedicated
 > to their buffers, but the calendar is opened in the current frame, not a
 > new frame.  Calendar-hide-window seems to assume that whenever dedicated
 > windows are being used, it is okay to delete or iconify a frame:
 >
 >   (cond
 >    ...
 >    ((and (display-multi-frame-p) (window-dedicated-p window))
 >     (if calendar-remove-frame-by-deleting
 >         (delete-frame (window-frame window))
 >         (iconify-frame (window-frame window))))
 >    ...
 >    )
 >
 > M-x version:
 >
 >   GNU Emacs 23.4.1 (x86_64-pc-linux-gnu, X toolkit, Xaw3d scroll bars)
 >   of 2012-04-07 on trouble, modified by Debian
 >
 > Any thoughts for a solution?

The corresponding code has changed on trunk but the bug is still
present.  Note that you now have to
(Continue reading)

Permalink | Reply |
headers
Glenn Morris | 25 Jun 2012 19:04
Picon

Re: bug in calendar-exit (calendar-hide-window)


Please install your patch if you think it improves things. Thanks!
Permalink | Reply |
headers
martin rudalics | 26 Jun 2012 09:25
Picon
Picon

Re: bug in calendar-exit (calendar-hide-window)

> Please install your patch if you think it improves things.

Installed.

martin
Permalink | Reply |
headers
John J Foerch | 26 Jun 2012 15:02
Picon
Favicon
Gravatar

Re: bug in calendar-exit (calendar-hide-window)

martin rudalics <rudalics <at> gmx.at> writes:
>> Please install your patch if you think it improves things.
>
> Installed.
>
> martin

Thank you!

--

-- 
John Foerch
Permalink | Reply |

Gmane