Tom Breton (Tehom | 30 Dec 05:22

Hook request and patch

Motivating incident: I was exporting some files and I wanted to
process a file after I included it.  Using "#+INCLUDE" I could include
it and I could tell it to use "BEGIN_XXX" "END_XXX" so my code could
find it.

But I couldn't process it, because org-export-preprocess-string calls
`org-export-preprocess-hook' before it handles "#+INCLUDE".

I didn't want to move org-export-preprocess-hook because for all I
know there's a good reason it comes first.  Similarly for the timing
of "#+INCLUDE".

So I ask for a hook that is called after includes are handled.  Diffs
appended.

Another advantage: `org-update-all-dblocks' didn't seem to work in
org-export-preprocess-hook because the working buffer isn't yet in
org-mode when it's called, but works in the new hook.

Tom Breton (Tehom)

*** old-org-exp.el	2008-12-18 18:26:05.000000000 -0500
--- org-exp.el	2008-12-29 23:10:46.000000000 -0500
***************
*** 297,302 ****
--- 297,305 ----
  (defvar org-export-preprocess-hook nil
    "Hook for preprocessing an export buffer.
  Pretty much the first thing when exporting is running this hook.")
+ (defvar org-export-midprocess-hook nil
(Continue reading)

Carsten Dominik | 31 Dec 09:45
Favicon

Re: Hook request and patch

Hi Tom,

is there a reason why you did not put the hook right after
the include file moment?

- Carsten

On Dec 30, 2008, at 5:22 AM, Tom Breton (Tehom) wrote:

> Motivating incident: I was exporting some files and I wanted to
> process a file after I included it.  Using "#+INCLUDE" I could include
> it and I could tell it to use "BEGIN_XXX" "END_XXX" so my code could
> find it.
>
> But I couldn't process it, because org-export-preprocess-string calls
> `org-export-preprocess-hook' before it handles "#+INCLUDE".
>
> I didn't want to move org-export-preprocess-hook because for all I
> know there's a good reason it comes first.  Similarly for the timing
> of "#+INCLUDE".
>
> So I ask for a hook that is called after includes are handled.  Diffs
> appended.
>
> Another advantage: `org-update-all-dblocks' didn't seem to work in
> org-export-preprocess-hook because the working buffer isn't yet in
> org-mode when it's called, but works in the new hook.
>
> Tom Breton (Tehom)
>
(Continue reading)

Tom Breton (Tehom | 31 Dec 19:54

Re: Hook request and patch

> Hi Tom,
>
> is there a reason why you did not put the hook right after
> the include file moment?
>
> - Carsten

Yes, two.  But of course your judgement should take precedence.

In order to make my change slightly less severe, I put it just before
operations of a similar nature, and it seemed to me that the various "find
links" operations were most like it - but perhaps that reflects on the
particular purpose I was using it for.

And it seemed to me that putting it after the various "protect" operations
was better than putting it before them.

Tom

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode <at> gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Carsten Dominik | 1 Jan 10:04
Favicon

Re: Hook request and patch


On Dec 31, 2008, at 7:54 PM, Tom Breton (Tehom) wrote:

>> Hi Tom,
>>
>> is there a reason why you did not put the hook right after
>> the include file moment?
>>
>> - Carsten
>
> Yes, two.  But of course your judgement should take precedence.
>
> In order to make my change slightly less severe, I put it just before
> operations of a similar nature, and it seemed to me that the various  
> "find
> links" operations were most like it - but perhaps that reflects on the
> particular purpose I was using it for.
>
> And it seemed to me that putting it after the various "protect"  
> operations
> was better than putting it before them.

Hi Tom,

I had to change the name of the hook, "midprocess" does not do
it justice.  I'm not sure if you really want to do this after the
protection stuff, because it will limit the processing of your
include files.

I have now added a few more hooks at strategic locations in the
(Continue reading)


Gmane