Developer discussion for the game `Battle for Wesnoth' ()

Iurii Chernyi | 20 Jun 2012 23:50

scenario transition refactoring gsoc project - commits ahead

Hello!

As part of scenario transition refactoring gsoc project, we're going
to commit some refactoring steps soon :)
If, after that commit, something breaks, please file bug reports or
ping me or committer, we'll fix everything.

The quality of the code might not good be enough at the moment (and we
know it), but it's better to commit it soon and fix/improve later. All
the main things should work as before (and we've not changed much
yet). Please let the original committer fix the style issues, if
possible, to minimize the amount of merges we'll have to do. Due to
nature of the work, it's better to make it happen on trunk, and it's
possible to make it happen on trunk because we're only messing with a
small part of the game (scenario transitions, saves/loads, switches to
next scenario), leaving all in-game stuff as it is now.

--

-- 
Cheers, Iurii Chernyi

headers

Mark de Wever | 30 Jun 2012 21:30

Re: scenario transition refactoring gsoc project - commits ahead

On Wed, Jun 20, 2012 at 11:50:45PM +0200, Iurii Chernyi wrote:
> Hello!
> 
> As part of scenario transition refactoring gsoc project, we're going
> to commit some refactoring steps soon :)
> If, after that commit, something breaks, please file bug reports or
> ping me or committer, we'll fix everything.

Nice to see some GSoC code committed.

> 
> The quality of the code might not good be enough at the moment (and we
> know it), but it's better to commit it soon and fix/improve later. All
> the main things should work as before (and we've not changed much
> yet). Please let the original committer fix the style issues, if
> possible, to minimize the amount of merges we'll have to do.

Not really happy to leave style issues when they occur. Is there a
reason why the main development isn't happening in trunk in the first
place?

--

-- 
Regards,
Mark de Wever aka Mordante/SkeletonCrew

headers

Iurii Chernyi | 1 Jul 2012 17:13

Re: scenario transition refactoring gsoc project - commits ahead

On Jun 30, 2012 9:31 PM, "Mark de Wever" <koraq <at> xs4all.nl> wrote:
> Not really happy to leave style issues when they occur. Is there a
> reason why the main development isn't happening in trunk in the first
> place?
The main development *is* happening in trunk. The merges that I talked about are potentital merges between upstream trunk code and student's working copy.

I agree that it's not good to leave style issues in place. Still, if a style issue appears in student's code, it's far better to tell him/her about it, describing the issue, and asking to fix, than to fix it yourself. The student is here to learn ;)

_______________________________________________
Wesnoth-dev mailing list
Wesnoth-dev <at> gna.org
https://mail.gna.org/listinfo/wesnoth-dev

headers

Mark de Wever | 4 Jul 2012 21:28

Re: scenario transition refactoring gsoc project - commits ahead

On Sun, Jul 01, 2012 at 05:13:11PM +0200, Iurii Chernyi wrote:
> On Jun 30, 2012 9:31 PM, "Mark de Wever" <koraq <at> xs4all.nl> wrote:
> > Not really happy to leave style issues when they occur. Is there a
> > reason why the main development isn't happening in trunk in the first
> > place?
> The main development *is* happening in trunk. The merges that I talked
> about are potentital merges between upstream trunk code and student's
> working copy.

Ok from the original mail I concluded it was developped in another
repository.

> I agree that it's not good to leave style issues in place. Still, if a
> style issue appears in student's code, it's far better to tell him/her
> about it, describing the issue, and asking to fix, than to fix it yourself.
> The student is here to learn ;)

In general I agree, however I tend to fix several pedantic style issues.
I don't mind to explain them, but I don't think I should really bother
students with it; I also don't bother other developers with it.

On the bright side, I haven't had complains from my tests on this code
yet.

--

-- 
Regards,
Mark de Wever aka Mordante/SkeletonCrew