Huang Ying | 12 Jun 2012 05:20
Picon
Favicon

[BUGFIX] ACPI, APEI, Avoid too much error reporting in runtime

This patch fixed the following bug.

https://bugzilla.kernel.org/show_bug.cgi?id=43282

This is caused by a firmware bug checking (checking generic address
register provided by firmware) in runtime.  The checking should be
done in address mapping time instead of runtime to avoid too much
error reporting in runtime.

Reported-by: Pawel Sikora <pluto <at> agmk.net>
Signed-off-by: Huang Ying <ying.huang <at> intel.com>
Tested-by: Jean Delvare <khali <at> linux-fr.org>
Cc: stable <at> vger.kernel.org
---
 drivers/acpi/apei/apei-base.c     |   17 +++++++++++++++--
 drivers/acpi/apei/apei-internal.h |    9 +++++++++
 drivers/acpi/apei/ghes.c          |    6 +++---
 3 files changed, 27 insertions(+), 5 deletions(-)

--- a/drivers/acpi/apei/apei-base.c
+++ b/drivers/acpi/apei/apei-base.c
 <at>  <at>  -243,7 +243,7  <at>  <at>  static int pre_map_gar_callback(struct a
 	u8 ins = entry->instruction;

 	if (ctx->ins_table[ins].flags & APEI_EXEC_INS_ACCESS_REGISTER)
-		return acpi_os_map_generic_address(&entry->register_region);
+		return apei_map_generic_address(&entry->register_region);

 	return 0;
 }
(Continue reading)

Len Brown | 12 Jun 2012 06:18

Re: [BUGFIX] ACPI, APEI, Avoid too much error reporting in runtime

applied.

thanks,
-Len Brown, Intel Open Source Technology Center

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo <at> vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Xiao, Hui | 13 Jun 2012 10:03
Picon
Gravatar

Re: [BUGFIX] ACPI, APEI, Avoid too much error reporting in runtime

On 2012/6/12 12:18, Len Brown wrote:
> applied.
> 
> thanks,
> -Len Brown, Intel Open Source Technology Center
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo <at> vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
Hi all,

I've also encountered the similar bug:
  [Firmware Bug]: APEI: Invalid bit width + offset in GAR [0x1121a5000/64/0/3/0]
during einj test. 

Besides Ying's fix patch, I think its a regression caused by incorrect bit width + offset check condition
introduced by commit v3.3-5-g15afae6. I've written a fix patch for it and will send it in a separate mail soon.

Thanks,
-Hui


Gmane