Knut Neumann | 1 Oct 2002 10:07
Picon
Favicon

Re: [PATCH] unresolved symbols with ACPI_DEBUG

Hmmm....I provided pretty much the same for 2.4 yesterday. Only
difference is that I had to add a few lines to acpi/utilities/Makefile
to set ACPI_DEBUG_OUTPUT on CONFIG_ACPI_DEBUG. As I have no access to an
2.5 source tree could you check if that is necessary for 2.5 too?

-Knut

Am Die, 2002-10-01 um 09.40 schrieb Bjoern A. Zeeb:
> Hi,
> 
> following patch prevents unresolved symbols when compiling with
> ACPI_DEBUG. (I sent a quite similar patch to Andrew Grover ~2 days
> ago but I think this one is better.)
> We should always use ACPI_DEBUG_OUTPUT and not CONFIG_ACPI_DEBUG I
> think to keep things consistent across multiple directories.
> 
> 
> --- linux-20020930-175132/drivers/acpi/acpi_ksyms.c.orig	Mon Sep 30 17:55:54 2002
> +++ linux-20020930-175132/drivers/acpi/acpi_ksyms.c	Tue Oct  1 06:30:23 2002
>  <at>  <at>  -43,7 +43,7  <at>  <at> 
> 
>  /* ACPI Core Subsystem */
> 
> -#ifdef ACPI_DEBUG
> +#ifdef ACPI_DEBUG_OUTPUT
>  EXPORT_SYMBOL(acpi_dbg_layer);
>  EXPORT_SYMBOL(acpi_dbg_level);
>  EXPORT_SYMBOL(acpi_ut_debug_print_raw);
>  <at>  <at>  -52,7 +52,7  <at>  <at> 
>  EXPORT_SYMBOL(acpi_ut_value_exit);
(Continue reading)

Bjoern A. Zeeb | 1 Oct 2002 19:33

Re: [PATCH] unresolved symbols with ACPI_DEBUG

On Tue, 1 Oct 2002, Knut Neumann wrote:

Hi,

> Hmmm....I provided pretty much the same for 2.4 yesterday. Only
> difference is that I had to add a few lines to acpi/utilities/Makefile
> to set ACPI_DEBUG_OUTPUT on CONFIG_ACPI_DEBUG. As I have no access to an
> 2.5 source tree could you check if that is necessary for 2.5 too?

no it shouldn't from what I had seen. 2.5 has a new kbuild
structure/mechanismn from what I know and there were changes.

To be on the save side ... having a look ... there is an

	EXTRA_CFLAGS += $(ACPI_CFLAGS)

in utilities/Makefile and that should do the job quite fine.

PS: I do no longer have any extracted 2.4 sources around ;-)

--

-- 
Greetings

Bjoern A. Zeeb				bzeeb at Zabbadoz dot NeT
56 69 73 69 74				http://www.zabbadoz.net/

-------------------------------------------------------
This sf.net email is sponsored by: DEDICATED SERVERS only $89!
Linux or FreeBSD, FREE setup, FAST network. Get your own server 
today at http://www.ServePath.com/indexfm.htm
(Continue reading)

Grover, Andrew | 1 Oct 2002 19:34
Picon
Favicon

RE: [PATCH] unresolved symbols with ACPI_DEBUG

> Hmmm....I provided pretty much the same for 2.4 yesterday. Only
> difference is that I had to add a few lines to acpi/utilities/Makefile
> to set ACPI_DEBUG_OUTPUT on CONFIG_ACPI_DEBUG. As I have no 
> access to an
> 2.5 source tree could you check if that is necessary for 2.5 too?

OK this has now been fixed 3 times now, first by Dominik 11 days ago.

I have a bunch of queued patches that I need to apply. After those, another
release is probably warranted.

Sorry for any delay. :)

Regards -- Andy

-------------------------------------------------------
This sf.net email is sponsored by: DEDICATED SERVERS only $89!
Linux or FreeBSD, FREE setup, FAST network. Get your own server 
today at http://www.ServePath.com/indexfm.htm

Gmane