headers
Manoj Iyer | 10 Mar 2012 00:32
Favicon

[PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

The newer V series bios reports product version as 'Lenovo'
instead of 'ThinkPad'. Recoginze this new string so that
the module can load.

Signed-off-by: Manoj Iyer <manoj.iyer@...>
---
 drivers/platform/x86/thinkpad_acpi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index ea0c607..d68c000 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
 <at>  <at>  -8658,7 +8658,7  <at>  <at>  static int __must_check __init get_thinkpad_model_data(
 	}

 	s = dmi_get_system_info(DMI_PRODUCT_VERSION);
-	if (s && !strnicmp(s, "ThinkPad", 8)) {
+	if (s && !(strnicmp(s, "ThinkPad", 8) && strnicmp(s, "Lenovo", 6))) {
 		tp->model_str = kstrdup(s, GFP_KERNEL);
 		if (!tp->model_str)
 			return -ENOMEM;
--

-- 
1.7.9.1

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
(Continue reading)

Permalink | Reply |
headers
Henrique de Moraes Holschuh | 10 Mar 2012 05:28
Picon
Favicon

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

On Fri, 09 Mar 2012, Manoj Iyer wrote:
> The newer V series bios reports product version as 'Lenovo'
> instead of 'ThinkPad'. Recoginze this new string so that
> the module can load.
> 
> Signed-off-by: Manoj Iyer <manoj.iyer <at> canonical.com>
> ---
>  drivers/platform/x86/thinkpad_acpi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index ea0c607..d68c000 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
>  <at>  <at>  -8658,7 +8658,7  <at>  <at>  static int __must_check __init get_thinkpad_model_data(
>  	}
>  
>  	s = dmi_get_system_info(DMI_PRODUCT_VERSION);
> -	if (s && !strnicmp(s, "ThinkPad", 8)) {
> +	if (s && !(strnicmp(s, "ThinkPad", 8) && strnicmp(s, "Lenovo", 6))) {
>  		tp->model_str = kstrdup(s, GFP_KERNEL);
>  		if (!tp->model_str)
>  			return -ENOMEM;

So far so good, but what driver functionality works well in these new
lenovo boxes?

--

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
(Continue reading)

Permalink | Reply |
headers
Yves-Alexis Perez | 10 Mar 2012 14:58
Picon
Favicon

Re: [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

On sam., 2012-03-10 at 01:28 -0300, Henrique de Moraes Holschuh wrote:
> 
> So far so good, but what driver functionality works well in these new
> lenovo boxes? 

V-series are Ideapad, so I'm not really sure this need to be added to
thinkpad-acpi.

Regards,
--

-- 
Yves-Alexis

------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing 
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
ibm-acpi-devel mailing list
ibm-acpi-devel@...
https://lists.sourceforge.net/lists/listinfo/ibm-acpi-devel
Permalink | Reply |
headers
Henrique de Moraes Holschuh | 10 Mar 2012 17:06
Picon
Favicon

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

On Sat, 10 Mar 2012, Yves-Alexis Perez wrote:
> On sam., 2012-03-10 at 01:28 -0300, Henrique de Moraes Holschuh wrote:
> > So far so good, but what driver functionality works well in these new
> > lenovo boxes? 
> 
> V-series are Ideapad, so I'm not really sure this need to be added to
> thinkpad-acpi.

Yeah, it is not a thinkpad, not even in name.

However, it just might have enough of the thinkpad ACPI API to work,
thus my question.  What good does thinkpad-acpi do in a Lenovo Ideapad
V-series?   If it does something useful, we can support it (but it
likely needs more than just this patch to be safe).

If it doesn't do anything useful, consider this as an absolute NACK
(i.e. I will outright revert it if it lands).  Loading thinkpad-acpi on
a notebook that doesn't benefit from it is harmful in the long term, as
thinkpad-acpi can suddenly start calling weird stuff in ACPI on that box
and do something bad.   There is a real reason why we restrict IBM-era
stuff to IBM thinkpads, etc.

--

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
Permalink | Reply |
headers
Manoj Iyer | 12 Mar 2012 22:34
Favicon

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

Henrique/Yves-Alexis,

Yes, the V series systems are listed under Ideapad series on Lenovo's 
website. I initially was looking at why the Fn+F5 hotkey was not reporting 
a key event. Looking at the bios dsdt.dsl data on V480 I see

Device (HKEY)
                     {
                         Mutex (BFWM, 0x07)
                         Name (INDV, Zero)
                         Name (_HID, EisaId ("LEN0068"))
                         Method (_STA, 0, NotSerialized)

and it does not have the acpi_device_id of VPC2004 like other ideapads 
that I have seen, and seemed like the HKEY could be handled by 
thinkpad_acpi module. Product version string in DMI says "Lenovo V480" 
instead of "ThinkPad" and this was not recognized by the thinkpad_acpi 
module, thus my quirk to load the module.

After loading the module on the V480 I see:

[14511.946260] thinkpad_acpi: ThinkPad ACPI Extras v0.24
[14511.946262] thinkpad_acpi: http://ibm-acpi.sf.net/
[14511.946264] thinkpad_acpi: ThinkPad BIOS H5ET23WW (0.23 ), EC unknown
[14511.946265] thinkpad_acpi: Lenovo Lenovo V480, model 14TD010
[14511.946707] thinkpad_acpi: detected a 8-level brightness capable 
ThinkPad
[14511.952009] thinkpad_acpi: rfkill switch tpacpi_bluetooth_sw: radio is 
unblocked
[14511.953099] Registered led device: tpacpi::thinklight
(Continue reading)

Permalink | Reply |
headers
Henrique de Moraes Holschuh | 13 Mar 2012 00:02
Picon
Favicon

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

On Mon, 12 Mar 2012, Manoj Iyer wrote:
> Yes, the V series systems are listed under Ideapad series on
> Lenovo's website. I initially was looking at why the Fn+F5 hotkey
> was not reporting a key event. Looking at the bios dsdt.dsl data on
> V480 I see
> 
> Device (HKEY)
>                     {
>                         Mutex (BFWM, 0x07)
>                         Name (INDV, Zero)
>                         Name (_HID, EisaId ("LEN0068"))
>                         Method (_STA, 0, NotSerialized)
> 
> and it does not have the acpi_device_id of VPC2004 like other
> ideapads that I have seen, and seemed like the HKEY could be handled
> by thinkpad_acpi module. Product version string in DMI says "Lenovo
> V480" instead of "ThinkPad" and this was not recognized by the
> thinkpad_acpi module, thus my quirk to load the module.
> 
> After loading the module on the V480 I see:
> 
> [14511.946260] thinkpad_acpi: ThinkPad ACPI Extras v0.24
> [14511.946262] thinkpad_acpi: http://ibm-acpi.sf.net/
> [14511.946264] thinkpad_acpi: ThinkPad BIOS H5ET23WW (0.23 ), EC unknown
> [14511.946265] thinkpad_acpi: Lenovo Lenovo V480, model 14TD010
> [14511.946707] thinkpad_acpi: detected a 8-level brightness capable
> ThinkPad
> [14511.952009] thinkpad_acpi: rfkill switch tpacpi_bluetooth_sw:
> radio is unblocked
> [14511.953099] Registered led device: tpacpi::thinklight
(Continue reading)

Permalink | Reply |
headers
Manoj Iyer | 13 Mar 2012 00:57
Favicon

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

>>
>> I am trying to get this patched module tested on other thinkpad and
>> ideapads that we have to see if there are any regression or other
>> issues. So, please let me know if this something worth supporting.
>
> Yes, it looks like it is worth supporting alright.

ok great. So, as I said earlier I will try and get this patched module 
tested on other ideapads to make sure we are not breaking existing 
systems. Unfortunately the systems are with our Taiwan engineers and will 
take a couple of days for them to get back with results.

>
> --
>  "One disk to rule them all, One disk to find them. One disk to bring
>  them all and in the darkness grind them. In the Land of Redmond
>  where the shadows lie." -- The Silicon Valley Tarot
>  Henrique Holschuh
>
>

--
====================
Manoj Iyer
Ubuntu/Canonical
Hardware Enablement
====================
Permalink | Reply |
headers
Manoj Iyer | 13 Mar 2012 16:53
Favicon

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

On Mon, 12 Mar 2012, Manoj Iyer wrote:

>>> 
>>> I am trying to get this patched module tested on other thinkpad and
>>> ideapads that we have to see if there are any regression or other
>>> issues. So, please let me know if this something worth supporting.
>> 
>> Yes, it looks like it is worth supporting alright.
>
> ok great. So, as I said earlier I will try and get this patched module tested 
> on other ideapads to make sure we are not breaking existing systems. 
> Unfortunately the systems are with our Taiwan engineers and will take a 
> couple of days for them to get back with results.

The patch was tested by the following people on ThinkPads, V480, and 
ideapads, and found to work as expected. I am informed that it does not 
break existing thinkpads, and it fixes issues mentioned on the V480. Can 
you please add the following tested-by when you apply the patch to your 
tree?

Tested-by: James Ferguson <james.ferguson <at> canonical.com>
Tested-by: Dennis Chua <dennis.chua <at> canonical.com>
Tested-by: Ike Pan <ike.pan <at> canonical.com>

>
>> 
>> --
>>  "One disk to rule them all, One disk to find them. One disk to bring
>>  them all and in the darkness grind them. In the Land of Redmond
>>  where the shadows lie." -- The Silicon Valley Tarot
(Continue reading)

Permalink | Reply |
headers
Henrique de Moraes Holschuh | 13 Mar 2012 21:07
Picon
Favicon

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

On Tue, 13 Mar 2012, Manoj Iyer wrote:
> On Mon, 12 Mar 2012, Manoj Iyer wrote:
> >>> I am trying to get this patched module tested on other thinkpad and
> >>> ideapads that we have to see if there are any regression or other
> >>> issues. So, please let me know if this something worth supporting.
> >> 
> >> Yes, it looks like it is worth supporting alright.
> >
> > ok great. So, as I said earlier I will try and get this patched module tested 
> > on other ideapads to make sure we are not breaking existing systems. 
> > Unfortunately the systems are with our Taiwan engineers and will take a 
> > couple of days for them to get back with results.
> 
> The patch was tested by the following people on ThinkPads, V480, and 
> ideapads, and found to work as expected. I am informed that it does not 
> break existing thinkpads, and it fixes issues mentioned on the V480. Can 
> you please add the following tested-by when you apply the patch to your 
> tree?
> 
> Tested-by: James Ferguson <james.ferguson <at> canonical.com>
> Tested-by: Dennis Chua <dennis.chua <at> canonical.com>
> Tested-by: Ike Pan <ike.pan <at> canonical.com>

Very well,

Acked-by: Henrique de Moraes Holschuh <hmh <at> hmh.eng.br>

Matthew, can you please pick it?

--

--
(Continue reading)

Permalink | Reply |
headers
Manoj Iyer | 13 Mar 2012 21:19
Favicon

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

On Tue, 13 Mar 2012, Henrique de Moraes Holschuh wrote:

> On Tue, 13 Mar 2012, Manoj Iyer wrote:
>> On Mon, 12 Mar 2012, Manoj Iyer wrote:
>>>>> I am trying to get this patched module tested on other thinkpad and
>>>>> ideapads that we have to see if there are any regression or other
>>>>> issues. So, please let me know if this something worth supporting.
>>>>
>>>> Yes, it looks like it is worth supporting alright.
>>>
>>> ok great. So, as I said earlier I will try and get this patched module tested
>>> on other ideapads to make sure we are not breaking existing systems.
>>> Unfortunately the systems are with our Taiwan engineers and will take a
>>> couple of days for them to get back with results.
>>
>> The patch was tested by the following people on ThinkPads, V480, and
>> ideapads, and found to work as expected. I am informed that it does not
>> break existing thinkpads, and it fixes issues mentioned on the V480. Can
>> you please add the following tested-by when you apply the patch to your
>> tree?
>>
>> Tested-by: James Ferguson <james.ferguson <at> canonical.com>
>> Tested-by: Dennis Chua <dennis.chua <at> canonical.com>
>> Tested-by: Ike Pan <ike.pan <at> canonical.com>
>
> Very well,
>
> Acked-by: Henrique de Moraes Holschuh <hmh <at> hmh.eng.br>
>
> Matthew, can you please pick it?
(Continue reading)

Permalink | Reply |
headers
Matthew Garrett | 20 Mar 2012 17:03
Favicon

Re: [ibm-acpi-devel] [PATCH] thinkpad-acpi: recognize Lenovo as version string in newer V-series BIOS

On Tue, Mar 13, 2012 at 05:07:45PM -0300, Henrique de Moraes Holschuh wrote:

> Matthew, can you please pick it?

Done.

--

-- 
Matthew Garrett | mjg59 <at> srcf.ucam.org
Permalink | Reply |

Gmane