Roman Volkov | 19 Nov 15:31 2013
Picon

[PATCH 2/2] snd-oxygen: Fixes for the Xonar DG card

Fixes for the Xonar DG model of the Oxygen driver:
CS4245 CODEC now fully supported with the headphone amplifier.
Both front panel and rear jacks work.
Full support of capturing: from the microphone, line in, and aux input.
Multichannel playback routing corrected for 2.0/4.0/5.1 speakers
New mixer controls, hardware volume control supported for headphones only.

Signed-off-by: Roman I Volkov <v1ron <at> mail.ru>
---
Depends on: [PATCH 1/2] snd-oxygen: Changes for oxygen driver to fix the Xonar DG card
diff -uprN linux-3.12/sound/pci/oxygen/Makefile linux-3.12-my/sound/pci/oxygen/Makefile
--- linux-3.12/sound/pci/oxygen/Makefile	2013-11-04 03:41:51.000000000 +0400
+++ linux-3.12-my/sound/pci/oxygen/Makefile	2013-11-15 16:55:55.000000000 +0400
 <at>  <at>  -1,5 +1,5  <at>  <at> 
 snd-oxygen-lib-objs := oxygen_io.o oxygen_lib.o oxygen_mixer.o oxygen_pcm.o
-snd-oxygen-objs := oxygen.o xonar_dg.o
+snd-oxygen-objs := oxygen.o xonar_dg.o xonar_dg_mixer.o
 snd-virtuoso-objs := virtuoso.o xonar_lib.o \
 	xonar_pcm179x.o xonar_cs43xx.o xonar_wm87x6.o xonar_hdmi.o

diff -uprN linux-3.12/sound/pci/oxygen/xonar_dg.c linux-3.12-my/sound/pci/oxygen/xonar_dg.c
--- linux-3.12/sound/pci/oxygen/xonar_dg.c	2013-11-04 03:41:51.000000000 +0400
+++ linux-3.12-my/sound/pci/oxygen/xonar_dg.c	2013-11-19 01:01:07.000000000 +0400
 <at>  <at>  -2,7 +2,7  <at>  <at> 
  * card driver for the Xonar DG/DGX
  *
  * Copyright (c) Clemens Ladisch <clemens <at> ladisch.de>
- *
+ * Copyright (c) Roman Volkov <v1ron <at> mail.ru>
  *
(Continue reading)

Clemens Ladisch | 19 Nov 23:23 2013
Picon

Re: [PATCH 2/2] snd-oxygen: Fixes for the Xonar DG card

Roman Volkov wrote:
> Fixes for the Xonar DG model of the Oxygen driver:

Each of the following sentences describes a separate logical change.

> +++ linux-3.12-my/sound/pci/oxygen/xonar_dg.c	2013-11-19 01:01:07.000000000 +0400

> + * DGX card: not tested.
> + * Suspend/resume: not tested

This does not belong in the source code; if some tests succeeds, we do
not want to update the driver.

> + * SPDIF: not tested

SPDIF is handled completely by the CMI8788 itself.

> + * 128kHz doesn't work for CS4361 (multichannel playback)

Why do you expect 128 kHz to work?

> + * CS4245 Auxiliary Output is connected to the front panel headphones jack
> + * through amplifier.

The comment below already says this.

> - *   GPIO 3 <- ?
> + *   GPIO 3 <- unused (?)

Why this change?
(Continue reading)

Roman Volkov | 20 Nov 11:12 2013
Picon

Re: [PATCH 2/2] snd-oxygen: Fixes for the Xonar DG card

В Tue, 19 Nov 2013 23:23:54 +0100
Clemens Ladisch <clemens <at> ladisch.de> пишет:

> Roman Volkov wrote:
> > Fixes for the Xonar DG model of the Oxygen driver:
> 
> Each of the following sentences describes a separate logical change.

Yea, have some problems with naming :). Will try.

> > +++ linux-3.12-my/sound/pci/oxygen/xonar_dg.c	2013-11-19
> > 01:01:07.000000000 +0400
> 
> > + * DGX card: not tested.
> > + * Suspend/resume: not tested
> 
> This does not belong in the source code; if some tests succeeds, we do
> not want to update the driver.

Will move that to the patch notes.

> > + * SPDIF: not tested
> 
> SPDIF is handled completely by the CMI8788 itself.
> 
> > + * 128kHz doesn't work for CS4361 (multichannel playback)
> 
> Why do you expect 128 kHz to work?

128kHz will not work because CS4361 can't detect clocks for the
(Continue reading)


Gmane