gmane.linux.alsa.devel

alsa git: which version of ac97_codec.c am i supposed to hxr?

Hello All;

I feel confused by the presence of 2 different copies of ac97_codec.c:

   jutz-gnto ~ # find . -name ac97_codec.c
     ./alsa-driver/pci/ac97/ac97_codec.c
     ./alsa-kmirror/pci/ac97/ac97_codec.c

worse yet,they are not in sync:

jutz-gnto ~ # diff -w ./alsa-driver/pci/ac97/ac97_codec.c  
./alsa-kmirror/pci/ac97/ac97_codec.c
1d0
< #include "adriver.h"
38c37
< #include "../../alsa-kernel/pci/ac97/ac97_id.h"
---
> #include "ac97_id.h"
40c39
< #include "../../alsa-kernel/pci/ac97/ac97_patch.c"
---
> #include "ac97_patch.c"
1917d1915
< #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 0)
1929d1926
< #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 14)
1931d1927
< #endif
1953,1956d1948
< #else /* <= 2.6.0 */

(Continue reading)

headers

Jaroslav Kysela | 16 Aug 17:30

Re: alsa git: which version of ac97_codec.c am i supposed to hxr?

On Fri, 15 Aug 2008, John L. Utz III wrote:

> Hello All;
> 
> I feel confused by the presence of 2 different copies of ac97_codec.c:
> 
>    jutz-gnto ~ # find . -name ac97_codec.c
>      ./alsa-driver/pci/ac97/ac97_codec.c
>      ./alsa-kmirror/pci/ac97/ac97_codec.c
> 
> worse yet,they are not in sync:
> 
> Which of these am i supposed to use? am i supposed to change both of them  
> for some backward compatibility purpose?

Modify the alsa-kmirror code. When you run make in alsa-driver tree, the 
file from alsa-kmirror is patched to retain compatibility for older linux 
kernels. The ac97_codec.c file in alsa-driver tree is just a temporary 
file (not in our repository) used for building. See to .gitignore which 
files are temporary only.

					Jaroslav

-----
Jaroslav Kysela <perex <at> perex.cz>
Linux Kernel Sound Maintainer
ALSA Project, Red Hat, Inc.

headers

John L. Utz III | 18 Aug 20:26

Re: alsa git: which version of ac97_codec.c am i supposed to hxr?

Thankyou Jaroslav!

On Sat, 16 Aug 2008 08:30:23 -0700, Jaroslav Kysela <perex <at> perex.cz> wrote:

> On Fri, 15 Aug 2008, John L. Utz III wrote:
>
>> Hello All;
>>
>> I feel confused by the presence of 2 different copies of ac97_codec.c:
>>
>>    jutz-gnto ~ # find . -name ac97_codec.c
>>      ./alsa-driver/pci/ac97/ac97_codec.c
>>      ./alsa-kmirror/pci/ac97/ac97_codec.c
>>
>> worse yet,they are not in sync:
>>
>> Which of these am i supposed to use? am i supposed to change both of  
>> them
>> for some backward compatibility purpose?
>
> Modify the alsa-kmirror code. When you run make in alsa-driver tree, the
> file from alsa-kmirror is patched to retain compatibility for older linux
> kernels. The ac97_codec.c file in alsa-driver tree is just a temporary
> file (not in our repository) used for building. See to .gitignore which
> files are temporary only.
>
> 					Jaroslav
>
> -----
> Jaroslav Kysela <perex <at> perex.cz>

(Continue reading)