gmane.linux.alsa.devel

Bryan Wu | 5 Sep 12:20

[PATCH 0/9] ASoC Blackfin supporting (v2)


Hi Mark,

With Cliff's effort, we update this patch series quickly according to
your review.

v1-v2:
 - move ASoC Blackfin Kconfig and Makefile patch to be the last one
   in the series
 - fix coding style issues
 - The SND_SOC_DAFIMT_LEFT_J: ought to be default
 - fix other minor issues

v0-v1:
 - fix coding style issues
 - use latest ASoC API
 - split the whole patch into this 9 patches in a patchset

Thanks a lot
-Bryan

Bryan Wu | 5 Sep 12:21

[PATCH 6/9] ASoC: Blackfin: I2S CPU DAI driver

From: Cliff Cai <cliff.cai <at> analog.com>

Signed-off-by: Cliff Cai <cliff.cai <at> analog.com>
Signed-off-by: Bryan Wu <cooloney <at> kernel.org>
---
 sound/soc/blackfin/bf5xx-i2s.c |  289 ++++++++++++++++++++++++++++++++++++++++
 sound/soc/blackfin/bf5xx-i2s.h |   14 ++
 2 files changed, 303 insertions(+), 0 deletions(-)
 create mode 100644 sound/soc/blackfin/bf5xx-i2s.c
 create mode 100644 sound/soc/blackfin/bf5xx-i2s.h

diff --git a/sound/soc/blackfin/bf5xx-i2s.c b/sound/soc/blackfin/bf5xx-i2s.c
new file mode 100644
index 0000000..10fc252
--- /dev/null
+++ b/sound/soc/blackfin/bf5xx-i2s.c
@@ -0,0 +1,289 @@
+/*
+ * File:         sound/soc/blackfin/bf5xx-i2s.c
+ * Author:       Cliff Cai <Cliff.Cai <at> analog.com>
+ *
+ * Created:      Tue June 06 2008
+ * Description:  Blackfin I2S CPU DAI driver
+ *
+ * Modified:
+ *               Copyright 2008 Analog Devices Inc.
+ *
+ * Bugs:         Enter bugs at http://blackfin.uclinux.org/
+ *
+ * This program is free software; you can redistribute it and/or modify

(Continue reading)

Bryan Wu | 5 Sep 12:21

[PATCH 1/9] ASoC: add Blackfin build options to Kconfig and Makefile of sound soc framework

From: Cliff Cai <cliff.cai <at> analog.com>

Signed-off-by: Cliff Cai <cliff.cai <at> analog.com>
Signed-off-by: Bryan Wu <cooloney <at> kernel.org>
---
 sound/soc/Kconfig  |    2 +-
 sound/soc/Makefile |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/Kconfig b/sound/soc/Kconfig
index f743530..0adbc92 100644
--- a/sound/soc/Kconfig
+++ b/sound/soc/Kconfig
@@ -31,7 +31,7 @@ source "sound/soc/sh/Kconfig"
 source "sound/soc/fsl/Kconfig"
 source "sound/soc/davinci/Kconfig"
 source "sound/soc/omap/Kconfig"
-
+source "sound/soc/blackfin/Kconfig"
 # Supported codecs
 source "sound/soc/codecs/Kconfig"

diff --git a/sound/soc/Makefile b/sound/soc/Makefile
index 933a66d..d849349 100644
--- a/sound/soc/Makefile
+++ b/sound/soc/Makefile
@@ -2,4 +2,4 @@ snd-soc-core-objs := soc-core.o soc-dapm.o

 obj-$(CONFIG_SND_SOC)	+= snd-soc-core.o
 obj-$(CONFIG_SND_SOC)	+= codecs/ at32/ at91/ pxa/ s3c24xx/ sh/ fsl/ davinci/

(Continue reading)

Mark Brown | 5 Sep 14:38

Re: [PATCH 1/9] ASoC: add Blackfin build options to Kconfig and Makefile of sound soc framework

On Fri, Sep 05, 2008 at 06:21:34PM +0800, Bryan Wu wrote:

>  source "sound/soc/davinci/Kconfig"
>  source "sound/soc/omap/Kconfig"
> -
> +source "sound/soc/blackfin/Kconfig"
>  # Supported codecs
>  source "sound/soc/codecs/Kconfig"

Please don't remove the blank line here.  I'll fix this up locally.
Other than that

Acked-by: Mark Brown <broonie <at> opensource.wolfsonmicro.com>

Bryan Wu | 5 Sep 12:21

[PATCH 9/9] ASoC: Blackfin: add Blackfin arch ASoC Kconfig and Makefile

From: Cliff Cai <cliff.cai <at> analog.com>

Signed-off-by: Cliff Cai <cliff.cai <at> analog.com>
Signed-off-by: Bryan Wu <cooloney <at> kernel.org>
---
 sound/soc/blackfin/Kconfig  |   85 +++++++++++++++++++++++++++++++++++++++++++
 sound/soc/blackfin/Makefile |   20 ++++++++++
 2 files changed, 105 insertions(+), 0 deletions(-)
 create mode 100644 sound/soc/blackfin/Kconfig
 create mode 100644 sound/soc/blackfin/Makefile

diff --git a/sound/soc/blackfin/Kconfig b/sound/soc/blackfin/Kconfig
new file mode 100644
index 0000000..f98331d
--- /dev/null
+++ b/sound/soc/blackfin/Kconfig
@@ -0,0 +1,85 @@
+config SND_BF5XX_I2S
+	tristate "SoC I2S Audio for the ADI BF5xx chip"
+	depends on BLACKFIN && SND_SOC
+	help
+	  Say Y or M if you want to add support for codecs attached to
+	  the Blackfin SPORT (synchronous serial ports) interface in I2S
+	  mode (supports single stereo In/Out).
+	  You will also need to select the audio interfaces to support below.
+
+config SND_BF5XX_SOC_SSM2602
+	tristate "SoC SSM2602 Audio support for BF52x ezkit"
+	depends on SND_BF5XX_I2S
+	select SND_BF5XX_SOC_I2S

(Continue reading)

Bryan Wu | 5 Sep 12:21

[PATCH 3/9] ASoC: Blackfin: DMA Driver for AC97 sound chip

From: Cliff Cai <cliff.cai <at> analog.com>

Signed-off-by: Bryan Wu <cooloney <at> kernel.org>
Signed-off-by: Cliff Cai <cliff.cai <at> analog.com>
---
 sound/soc/blackfin/bf5xx-ac97-pcm.c |  428 +++++++++++++++++++++++++++++++++++
 sound/soc/blackfin/bf5xx-ac97-pcm.h |   29 +++
 2 files changed, 457 insertions(+), 0 deletions(-)
 create mode 100644 sound/soc/blackfin/bf5xx-ac97-pcm.c
 create mode 100644 sound/soc/blackfin/bf5xx-ac97-pcm.h

diff --git a/sound/soc/blackfin/bf5xx-ac97-pcm.c b/sound/soc/blackfin/bf5xx-ac97-pcm.c
new file mode 100644
index 0000000..69ced22
--- /dev/null
+++ b/sound/soc/blackfin/bf5xx-ac97-pcm.c
@@ -0,0 +1,428 @@
+/*
+ * File:         sound/soc/blackfin/bf5xx-ac97-pcm.c
+ * Author:       Cliff Cai <Cliff.Cai <at> analog.com>
+ *
+ * Created:      Tue June 06 2008
+ * Description:  DMA Driver for AC97 sound chip
+ *
+ * Modified:
+ *               Copyright 2008 Analog Devices Inc.
+ *
+ * Bugs:         Enter bugs at http://blackfin.uclinux.org/
+ *
+ * This program is free software; you can redistribute it and/or modify

(Continue reading)

Mark Brown | 5 Sep 14:48

Re: [PATCH 3/9] ASoC: Blackfin: DMA Driver for AC97 sound chip

On Fri, Sep 05, 2008 at 06:21:36PM +0800, Bryan Wu wrote:

> +static int bf5xx_pcm_open(struct snd_pcm_substream *substream)
> +{
> +	struct snd_pcm_runtime *runtime = substream->runtime;
> +	int ret;
> +
> +	pr_debug("%s enter\n", __func__);
> +	snd_soc_set_runtime_hwparams(substream, &bf5xx_pcm_hardware);
> +
> +	ret = snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS);
> +	if (ret < 0)
> +		goto out;

This change now goes over 80 columns...  I'll fix this up locally.

Bryan Wu | 5 Sep 12:21

[PATCH 8/9] ASoC: Blackfin: board driver for SSM2602 sound chip

From: Cliff Cai <cliff.cai <at> analog.com>

Signed-off-by: Cliff Cai <cliff.cai <at> analog.com>
Signed-off-by: Bryan Wu <cooloney <at> kernel.org>
---
 sound/soc/blackfin/bf5xx-ssm2602.c |  186 ++++++++++++++++++++++++++++++++++++
 1 files changed, 186 insertions(+), 0 deletions(-)
 create mode 100644 sound/soc/blackfin/bf5xx-ssm2602.c

diff --git a/sound/soc/blackfin/bf5xx-ssm2602.c b/sound/soc/blackfin/bf5xx-ssm2602.c
new file mode 100644
index 0000000..e15f67f
--- /dev/null
+++ b/sound/soc/blackfin/bf5xx-ssm2602.c
@@ -0,0 +1,186 @@
+/*
+ * File:         sound/soc/blackfin/bf5xx-ssm2602.c
+ * Author:       Cliff Cai <Cliff.Cai <at> analog.com>
+ *
+ * Created:      Tue June 06 2008
+ * Description:  board driver for SSM2602 sound chip
+ *
+ * Modified:
+ *               Copyright 2008 Analog Devices Inc.
+ *
+ * Bugs:         Enter bugs at http://blackfin.uclinux.org/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or

(Continue reading)

Bryan Wu | 5 Sep 12:21

[PATCH 5/9] ASoC: Blackfin: DMA Driver for I2S sound chip

From: Cliff Cai <cliff.cai <at> analog.com>

Signed-off-by: Cliff Cai <cliff.cai <at> analog.com>
Signed-off-by: Bryan Wu <cooloney <at> kernel.org>
---
 sound/soc/blackfin/bf5xx-i2s-pcm.c |  288 ++++++++++++++++++++++++++++++++++++
 sound/soc/blackfin/bf5xx-i2s-pcm.h |   29 ++++
 2 files changed, 317 insertions(+), 0 deletions(-)
 create mode 100644 sound/soc/blackfin/bf5xx-i2s-pcm.c
 create mode 100644 sound/soc/blackfin/bf5xx-i2s-pcm.h

diff --git a/sound/soc/blackfin/bf5xx-i2s-pcm.c b/sound/soc/blackfin/bf5xx-i2s-pcm.c
new file mode 100644
index 0000000..61fccf9
--- /dev/null
+++ b/sound/soc/blackfin/bf5xx-i2s-pcm.c
@@ -0,0 +1,288 @@
+/*
+ * File:         sound/soc/blackfin/bf5xx-i2s-pcm.c
+ * Author:       Cliff Cai <Cliff.Cai <at> analog.com>
+ *
+ * Created:      Tue June 06 2008
+ * Description:  DMA driver for i2s codec
+ *
+ * Modified:
+ *               Copyright 2008 Analog Devices Inc.
+ *
+ * Bugs:         Enter bugs at http://blackfin.uclinux.org/
+ *
+ * This program is free software; you can redistribute it and/or modify

(Continue reading)

Bryan Wu | 5 Sep 12:21

[PATCH 2/9] ASoC: Blackfin: SPORT peripheral interface driver

From: Cliff Cai <cliff.cai <at> analog.com>

SPORT is a serial port which can support serveral serial communication protocols.
It can be used as I2C/PCM/AC97. For further information, please look up the HRM.

Signed-off-by: Cliff Cai <cliff.cai <at> analog.com>
Signed-off-by: Bryan Wu <cooloney <at> kernel.org>
---
 sound/soc/blackfin/bf5xx-sport.c | 1028 ++++++++++++++++++++++++++++++++++++++
 sound/soc/blackfin/bf5xx-sport.h |  192 +++++++
 2 files changed, 1220 insertions(+), 0 deletions(-)
 create mode 100644 sound/soc/blackfin/bf5xx-sport.c
 create mode 100644 sound/soc/blackfin/bf5xx-sport.h

diff --git a/sound/soc/blackfin/bf5xx-sport.c b/sound/soc/blackfin/bf5xx-sport.c
new file mode 100644
index 0000000..e09afd9
--- /dev/null
+++ b/sound/soc/blackfin/bf5xx-sport.c
@@ -0,0 +1,1028 @@
+/*
+ * File:         bf5xx_sport.c
+ * Based on:
+ * Author:       Roy Huang <roy.huang <at> analog.com>
+ *
+ * Created:      Tue Sep 21 10:52:42 CEST 2004
+ * Description:
+ *               Blackfin SPORT Driver
+ *
+ *               Copyright 2004-2007 Analog Devices Inc.

(Continue reading)

Mark Brown | 5 Sep 15:10

Re: [PATCH 2/9] ASoC: Blackfin: SPORT peripheral interface driver

On Fri, Sep 05, 2008 at 06:21:35PM +0800, Bryan Wu wrote:

> +	/* Maybe the dummy buffer descriptor ring is damaged */
> +	sport->dummy_rx_desc->next_desc_addr = \
> +			(unsigned long)(sport->dummy_rx_desc+1);

Here and elsewhere in this driver you've got continuation characters
which aren't need.  I've fixed this up locally (and some additional
checkpatch/coding standards things) here and in other patches in the
series.

Otherwise the patch series looks good to go, thanks - I'm just about to
review the codec driver patch that it depends upon.

Bryan Wu | 5 Sep 12:21

[PATCH 4/9] ASoC: Blackfin: AC97 Blackfin CPU DAI driver

From: Cliff Cai <cliff.cai <at> analog.com>

Signed-off-by: Cliff Cai <cliff.cai <at> analog.com>
Signed-off-by: Bryan Wu <cooloney <at> kernel.org>
---
 sound/soc/blackfin/bf5xx-ac97.c |  407 +++++++++++++++++++++++++++++++++++++++
 sound/soc/blackfin/bf5xx-ac97.h |   36 ++++
 2 files changed, 443 insertions(+), 0 deletions(-)
 create mode 100644 sound/soc/blackfin/bf5xx-ac97.c
 create mode 100644 sound/soc/blackfin/bf5xx-ac97.h

diff --git a/sound/soc/blackfin/bf5xx-ac97.c b/sound/soc/blackfin/bf5xx-ac97.c
new file mode 100644
index 0000000..c782e31
--- /dev/null
+++ b/sound/soc/blackfin/bf5xx-ac97.c
@@ -0,0 +1,407 @@
+/*
+ * bf5xx-ac97.c -- AC97 support for the ADI blackfin chip.
+ *
+ * Author:	Roy Huang
+ * Created:	11th. June 2007
+ * Copyright:	Analog Device Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/init.h>

(Continue reading)

Bryan Wu | 5 Sep 12:21

[PATCH 7/9] ASoC: Blackfin: board driver for AD1980/1 audio codec

From: Cliff Cai <cliff.cai <at> analog.com>

Signed-off-by: Cliff Cai <cliff.cai <at> analog.com>
Signed-off-by: Bryan Wu <cooloney <at> kernel.org>
---
 sound/soc/blackfin/bf5xx-ad1980.c |  113 +++++++++++++++++++++++++++++++++++++
 1 files changed, 113 insertions(+), 0 deletions(-)
 create mode 100644 sound/soc/blackfin/bf5xx-ad1980.c

diff --git a/sound/soc/blackfin/bf5xx-ad1980.c b/sound/soc/blackfin/bf5xx-ad1980.c
new file mode 100644
index 0000000..124425d
--- /dev/null
+++ b/sound/soc/blackfin/bf5xx-ad1980.c
@@ -0,0 +1,113 @@
+/*
+ * File:         sound/soc/blackfin/bf5xx-ad1980.c
+ * Author:       Cliff Cai <Cliff.Cai <at> analog.com>
+ *
+ * Created:      Tue June 06 2008
+ * Description:  Board driver for AD1980/1 audio codec
+ *
+ * Modified:
+ *               Copyright 2008 Analog Devices Inc.
+ *
+ * Bugs:         Enter bugs at http://blackfin.uclinux.org/
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or

(Continue reading)

Mark Brown | 5 Sep 14:37

Re: [PATCH 0/9] ASoC Blackfin supporting (v2)

On Fri, Sep 05, 2008 at 06:21:33PM +0800, Bryan Wu wrote:

> With Cliff's effort, we update this patch series quickly according to
> your review.

Thanks.  Please, when sending updates to this patch series could you
send incremental patches as I asked?  There is a lot of code here, most
of which has already been acked and is not changing so showing only the
changes that have been made will greatly simplify the review process.

Bryan Wu | 5 Sep 16:00

Re: [alsa-devel] [PATCH 0/9] ASoC Blackfin supporting (v2)

On Fri, Sep 5, 2008 at 8:37 PM, Mark Brown <broonie <at> sirena.org.uk> wrote:
> On Fri, Sep 05, 2008 at 06:21:33PM +0800, Bryan Wu wrote:
>
>> With Cliff's effort, we update this patch series quickly according to
>> your review.
>
> Thanks.  Please, when sending updates to this patch series could you
> send incremental patches as I asked?  There is a lot of code here, most
> of which has already been acked and is not changing so showing only the
> changes that have been made will greatly simplify the review process.
>

Thanks, I will follow this procedure as your mentioned. I just want to
make it easier for
your git-am operation, -:)))

-Bryan

Return

Return to gmane.linux.alsa.devel.

Advertisement

Search Archive

Language

Change language

Options

Current view: Threads only / Showing only 20 lines / Not hiding cited text.
Change to All messages, whole messages, or hide cited text.

Post a message
NNTP Newsgroup
Classic Gmane web interface
XML

XML

RSS Feed
List Information

About Gmane